Skip to contentSkip to conversation

netlink: kconfig: move mmap i/o into netlink kconfig

PATCH Applied Daniel Borkmann 2 participants 2 messages May 1, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netlink: kconfig: move mmap i/o into netlink kconfig

Currently, in menuconfig, Netlink's new mmaped IO is the very first entry under the ``Networking support'' item and comes even before ``Networking options'':

[ ] Netlink: mmaped IO
Networking options --->
...

Lets move this into ``Networking options'' under netlink's Kconfig, since this might be more appropriate. Introduced by commit ccdfcc398 (``netlink: mmaped netlink: ring setup'').

---
 net/Kconfig         | 9 ---------
 net/netlink/Kconfig | 9 +++++++++
 2 files changed, 9 insertions(+), 9 deletions(-)
net/Kconfig +0 -9
index 1a22216..2ddc904 100644
@@ -23,15 +23,6 @@ menuconfig NET
 
 if NET
 
-config NETLINK_MMAP
-	bool "Netlink: mmaped IO"
-	help
-	  This option enables support for memory mapped netlink IO. This
-	  reduces overhead by avoiding copying data between kernel- and
-	  userspace.
-
-	  If unsure, say N.
-
 config WANT_COMPAT_NETLINK_MESSAGES
 	bool
 	help
net/netlink/Kconfig +9 -0
index 5d6e8c0..2c5e95e 100644
@@ -2,6 +2,15 @@
 # Netlink Sockets
 #
 
+config NETLINK_MMAP
+	bool "NETLINK: mmaped IO"
+	---help---
+	  This option enables support for memory mapped netlink IO. This
+	  reduces overhead by avoiding copying data between kernel- and
+	  userspace.
+
+	  If unsure, say N.
+
 config NETLINK_DIAG
 	tristate "NETLINK: socket monitoring interface"
 	default n
Signature · 1 line
1.7.11.7
maintainer Applied
#1 lore raw

From: Daniel Borkmann <[email protected]>
Date: Wed, 1 May 2013 13:37:20 +0200

Quoted 8 lines

Currently, in menuconfig, Netlink's new mmaped IO is the very first entry under the ``Networking support'' item and comes even before ``Networking options'':

[ ] Netlink: mmaped IO
Networking options --->
...

Quoted 5 lines

Lets move this into ``Networking options'' under netlink's Kconfig, since this might be more appropriate. Introduced by commit ccdfcc398 (``netlink: mmaped netlink: ring setup'').

Applied, thanks for fixing this up Daniel.