Skip to contentSkip to conversation

usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

PATCH In review Dan Williams 6 participants 11 messages May 1, 2013 2 messages not in the archive

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

A rebranded Novatel E371 for AT&T's LTE bands.

---
See https://bugzilla.redhat.com/show_bug.cgi?id=955426

drivers/net/usb/cdc_ether.c +7 -0
index 57136dc..299c53b 100644
@@ -615,6 +615,13 @@ static const struct usb_device_id	products [] = {
 	.driver_info = 0,
 },
 
+/* Dell Wireless 5804 (Novatel E371) - handled by qmi_wwan */
+{
+	USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x819b, USB_CLASS_COMM,
+			USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
+	.driver_info = 0,
+},
+
 /* AnyDATA ADU960S - handled by qmi_wwan */
 {
 	USB_DEVICE_AND_INTERFACE_INFO(0x16d5, 0x650a, USB_CLASS_COMM,
drivers/net/usb/qmi_wwan.c +7 -0
index 968d5d5..38734fd 100644
@@ -392,6 +392,13 @@ static const struct usb_device_id products[] = {
 					      USB_CDC_PROTO_NONE),
 		.driver_info        = (unsigned long)&qmi_wwan_info,
 	},
+	{	/* Dell Wireless 5804 (Novatel E371) */
+		USB_DEVICE_AND_INTERFACE_INFO(0x413C, 0x819b,
+					      USB_CLASS_COMM,
+					      USB_CDC_SUBCLASS_ETHERNET,
+					      USB_CDC_PROTO_NONE),
+		.driver_info        = (unsigned long)&qmi_wwan_info,
+	},
 	{	/* ADU960S */
 		USB_DEVICE_AND_INTERFACE_INFO(0x16d5, 0x650a,
 					      USB_CLASS_COMM,
drivers/usb/serial/option.c +2 -0
index 558adfc..569caf6 100644
@@ -196,6 +196,7 @@ static void option_instat_callback(struct urb *urb);
 
 #define DELL_PRODUCT_5800_MINICARD_VZW		0x8195  /* Novatel E362 */
 #define DELL_PRODUCT_5800_V2_MINICARD_VZW	0x8196  /* Novatel E362 */
+#define DELL_PRODUCT_5804_MINICARD_ATT		0x819b  /* Novatel E371 */
 
 #define KYOCERA_VENDOR_ID			0x0c88
 #define KYOCERA_PRODUCT_KPC650			0x17da
@@ -770,6 +771,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(DELL_VENDOR_ID, DELL_PRODUCT_5730_MINICARD_VZW) }, 	/* Dell Wireless 5730 Mobile Broadband EVDO/HSPA Mini-Card */
 	{ USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, DELL_PRODUCT_5800_MINICARD_VZW, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, DELL_PRODUCT_5800_V2_MINICARD_VZW, 0xff, 0xff, 0xff) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, DELL_PRODUCT_5804_MINICARD_ATT, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_E100A) },	/* ADU-E100, ADU-310 */
 	{ USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_500A) },
 	{ USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_620UW) },

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

For the qmi_wwan part:

drivers/usb/serial/option.c

Quoted 4 lines
drivers/usb/serial/option.c +0 -0
index 558adfc..569caf6 100644

Combining net and usb patches in the same commit is probably not wise?

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw

From: Bjørn Mork <[email protected]>
Date: Wed, 01 May 2013 20:33:10 +0200

Quoted 13 lines
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

For the qmi_wwan part:

Quoted 6 lines

drivers/usb/serial/option.c

Quoted 4 lines
drivers/usb/serial/option.c +0 -0
index 558adfc..569caf6 100644

Combining net and usb patches in the same commit is probably not wise?

Yes, this causes problems, please re-submit the networking portion all by itself.

#4 lore raw
Quoted 23 lines · David Miller

From: Bjørn Mork <[email protected]>
Date: Wed, 01 May 2013 20:33:10 +0200

Quoted 13 lines
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

For the qmi_wwan part:

Quoted 6 lines

drivers/usb/serial/option.c

Quoted 4 lines
drivers/usb/serial/option.c +0 -0
index 558adfc..569caf6 100644

Combining net and usb patches in the same commit is probably not wise?

Quoted 2 lines

Yes, this causes problems, please re-submit the networking portion all by itself.

Will do.

Dan

#5 lore raw
In reply to Bjørn Mork
Quoted 8 lines · Bjørn Mork
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

See the referenced bug report which prompted this:

https://bugzilla.redhat.com/show_bug.cgi?id=955426

It's definitely QMI capable.

Dan

Quoted 18 lines

For the qmi_wwan part:

drivers/usb/serial/option.c

Quoted 4 lines
drivers/usb/serial/option.c +0 -0
index 558adfc..569caf6 100644

Combining net and usb patches in the same commit is probably not wise?

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#6 lore raw
Quoted 10 lines · Dan Williams
Quoted 8 lines · Bjørn Mork
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

Quoted 5 lines

See the referenced bug report which prompted this:

https://bugzilla.redhat.com/show_bug.cgi?id=955426

It's definitely QMI capable.

Yes, absolutely.

I just assumed the E371 exists with a Novatel vendor ID as well. Which we could and should also add, if we only knew what the product ID is.

But it wasn't my intention to question the addition of the Dell rebranded E371. There's absolutely no need to let that wait. Sorry for being unclear. I am not communicating well today...

Bjørn

#7 lore raw

Vendor ID is 413c Product ID is 819b

Quoted 32 lines · Bjørn Mork
Quoted 10 lines · Dan Williams
Quoted 8 lines · Bjørn Mork
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

Quoted 5 lines

See the referenced bug report which prompted this:

https://bugzilla.redhat.com/show_bug.cgi?id=955426

It's definitely QMI capable.

Yes, absolutely.

I just assumed the E371 exists with a Novatel vendor ID as well. Which we could and should also add, if we only knew what the product ID is.

But it wasn't my intention to question the addition of the Dell rebranded E371. There's absolutely no need to let that wait. Sorry for being unclear. I am not communicating well today...

Bjørn

A message that is not in the archive (sent off-list or not yet received): CAO2Qn5m08QOBJfuvR1xAF9msw2WX0mAT64=s8VmXuO41h9dkWg@mail.gmail.com

#9 lore raw
Quoted 1 line · dag dg

Vendor ID is 413c Product ID is 819b

Bjorn meant the actual Novatel E371 device IDs...

Dan

Quoted 36 lines · Bjørn Mork
Quoted 34 lines
Quoted 10 lines · Dan Williams
Quoted 8 lines · Bjørn Mork
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

Quoted 5 lines

See the referenced bug report which prompted this:

https://bugzilla.redhat.com/show_bug.cgi?id=955426

It's definitely QMI capable.

Yes, absolutely.

I just assumed the E371 exists with a Novatel vendor ID as well. Which we could and should also add, if we only knew what the product ID is.

But it wasn't my intention to question the addition of the Dell rebranded E371. There's absolutely no need to let that wait. Sorry for being unclear. I am not communicating well today...

Bjørn

#10 lore raw

Sorry the mailing list was complaining about my HTML mode. How would I find the actual novatel E371 device ID? If I get some guidance there I'd be happy to pull the data.

Quoted 45 lines · Dan Williams
Quoted 1 line · dag dg

Vendor ID is 413c Product ID is 819b

Bjorn meant the actual Novatel E371 device IDs...

Dan

Quoted 36 lines · Bjørn Mork
Quoted 34 lines
Quoted 10 lines · Dan Williams
Quoted 8 lines · Bjørn Mork
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

Quoted 5 lines

See the referenced bug report which prompted this:

https://bugzilla.redhat.com/show_bug.cgi?id=955426

It's definitely QMI capable.

Yes, absolutely.

I just assumed the E371 exists with a Novatel vendor ID as well. Which we could and should also add, if we only knew what the product ID is.

But it wasn't my intention to question the addition of the Dell rebranded E371. There's absolutely no need to let that wait. Sorry for being unclear. I am not communicating well today...

Bjørn

#11 lore raw
Quoted 3 lines · dag dg

Sorry the mailing list was complaining about my HTML mode. How would I find the actual novatel E371 device ID? If I get some guidance there I'd be happy to pull the data.

Don't worry about it, Bjorn was just saying he wished we had that ID. You don't need to go looking for it if you don't want to.

Dan

Quoted 50 lines · Dan Williams
Quoted 45 lines · dag dg
Quoted 1 line

Vendor ID is 413c Product ID is 819b

Bjorn meant the actual Novatel E371 device IDs...

Dan

Quoted 36 lines · Bjørn Mork
Quoted 34 lines
Quoted 10 lines · Dan Williams
Quoted 8 lines · Bjørn Mork
Quoted 1 line · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either... Well, nothing we can do about that until someone reports it.

Quoted 5 lines

See the referenced bug report which prompted this:

https://bugzilla.redhat.com/show_bug.cgi?id=955426

It's definitely QMI capable.

Yes, absolutely.

I just assumed the E371 exists with a Novatel vendor ID as well. Which we could and should also add, if we only knew what the product ID is.

But it wasn't my intention to question the addition of the Dell rebranded E371. There's absolutely no need to let that wait. Sorry for being unclear. I am not communicating well today...

Bjørn

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#12 lore raw
In reply to Dan Williams
Quoted 4 lines · Dan Williams

A rebranded Novatel E371 for AT&T's LTE bands.

Skip this patch as I'll split it up, and it's also whitespace damaged to to an Evolution issue I'm sorting out. Will resubmit only the net part to netdev, and only the USB part to linux-usb.

Dan

Quoted 65 lines

---
See https://bugzilla.redhat.com/show_bug.cgi?id=955426

drivers/net/usb/cdc_ether.c +7 -0
index 57136dc..299c53b 100644
@@ -615,6 +615,13 @@ static const struct usb_device_id	products [] = {
 	.driver_info = 0,
 },
 
+/* Dell Wireless 5804 (Novatel E371) - handled by qmi_wwan */
+{
+	USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x819b, USB_CLASS_COMM,
+			USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
+	.driver_info = 0,
+},
+
 /* AnyDATA ADU960S - handled by qmi_wwan */
 {
 	USB_DEVICE_AND_INTERFACE_INFO(0x16d5, 0x650a, USB_CLASS_COMM,
drivers/net/usb/qmi_wwan.c +7 -0
index 968d5d5..38734fd 100644
@@ -392,6 +392,13 @@ static const struct usb_device_id products[] = {
 					      USB_CDC_PROTO_NONE),
 		.driver_info        = (unsigned long)&qmi_wwan_info,
 	},
+	{	/* Dell Wireless 5804 (Novatel E371) */
+		USB_DEVICE_AND_INTERFACE_INFO(0x413C, 0x819b,
+					      USB_CLASS_COMM,
+					      USB_CDC_SUBCLASS_ETHERNET,
+					      USB_CDC_PROTO_NONE),
+		.driver_info        = (unsigned long)&qmi_wwan_info,
+	},
 	{	/* ADU960S */
 		USB_DEVICE_AND_INTERFACE_INFO(0x16d5, 0x650a,
 					      USB_CLASS_COMM,
drivers/usb/serial/option.c +2 -1
index 558adfc..569caf6 100644
@@ -196,6 +196,7 @@ static void option_instat_callback(struct urb *urb);
 
 #define DELL_PRODUCT_5800_MINICARD_VZW		0x8195  /* Novatel E362 */
 #define DELL_PRODUCT_5800_V2_MINICARD_VZW	0x8196  /* Novatel E362 */
+#define DELL_PRODUCT_5804_MINICARD_ATT		0x819b  /* Novatel E371 */
 
 #define KYOCERA_VENDOR_ID			0x0c88
 #define KYOCERA_PRODUCT_KPC650			0x17da
@@ -770,6 +771,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(DELL_VENDOR_ID, DELL_PRODUCT_5730_MINICARD_VZW) }, 	/* Dell Wireless 5730 Mobile Broadband EVDO/HSPA Mini-Card */
 	{ USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, DELL_PRODUCT_5800_MINICARD_VZW, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, DELL_PRODUCT_5800_V2_MINICARD_VZW, 0xff, 0xff, 0xff) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, DELL_PRODUCT_5804_MINICARD_ATT, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_E100A) },	/* ADU-E100, ADU-310 */
 	{ USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_500A) },
 	{ USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_620UW) },
 
 
--

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html