Skip to contentSkip to conversation

fs: Fix hang with BSD accounting on frozen filesystem

PATCH Applied Jan Kara 2 participants 2 messages May 3, 2013 – May 4, 2013 VFS

lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH v2 1/1 fs: Fix hang with BSD accounting on frozen filesystem

When BSD process accounting is enabled and logs information to a filesystem which gets frozen, system easily becomes unusable because each attempt to account process information blocks. Thus e.g. every task gets blocked in exit.

It seems better to drop accounting information (which can already happen when filesystem is running out of space) instead of locking system up. So we just skip the write if the filesystem is frozen.

---
 kernel/acct.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

Hi Al!

I'm sending an updated fix for BSD process accounting hang. Can you please
merge it? Thanks!
Honza

kernel/acct.c +7 -2
index 85389fe..04606cc 100644
@@ -540,10 +540,15 @@ static void do_acct_process(struct bsd_acct_struct *acct,
 	ac.ac_swaps = encode_comp_t(0);
 
 	/*
+	 * Get freeze protection. If the fs is frozen, just skip the write
+	 * as we could deadlock the system otherwise.
+	 */
+	if (!sb_start_write_trylock(file_inode(file)->i_sb))
+		goto out;
+	/*
 	 * Kernel segment override to datasegment and write it
 	 * to the accounting file.
 	 */
-	file_start_write(file);
 	fs = get_fs();
 	set_fs(KERNEL_DS);
 	/*
@@ -555,7 +560,7 @@ static void do_acct_process(struct bsd_acct_struct *acct,
 			       sizeof(acct_t), &file->f_pos);
 	current->signal->rlim[RLIMIT_FSIZE].rlim_cur = flim;
 	set_fs(fs);
-	file_end_write(file);
+	sb_end_write(file_inode(file)->i_sb);
 out:
 	revert_creds(orig_cred);
 }
Signature · 1 line
1.7.1
maintainer Applied
#1 lore raw
Quoted 8 lines · Jan Kara

When BSD process accounting is enabled and logs information to a filesystem which gets frozen, system easily becomes unusable because each attempt to account process information blocks. Thus e.g. every task gets blocked in exit.

It seems better to drop accounting information (which can already happen when filesystem is running out of space) instead of locking system up. So we just skip the write if the filesystem is frozen.

Applied, with one modification - file_start_write_trylock() added and used instead of sb_start_write_trylock()