Skip to contentSkip to conversation

chrony: new package

PATCH New Nathan Lynch 2 participants 6 messages May 6, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 chrony: new package

---
 package/Config.in        | 1 +
 package/chrony/Config.in | 5 +++++
 package/chrony/chrony.mk | 6 ++++++
 3 files changed, 12 insertions(+)
 create mode 100644 package/chrony/Config.in
 create mode 100644 package/chrony/chrony.mk
package/Config.in +1 -0
index fe4f56b..d5719a8 100644
@@ -670,6 +670,7 @@ source "package/bind/Config.in"
 source "package/bmon/Config.in"
 source "package/bridge-utils/Config.in"
 source "package/can-utils/Config.in"
+source "package/chrony/Config.in"
 source "package/connman/Config.in"
 source "package/crda/Config.in"
 source "package/ctorrent/Config.in"
package/chrony/Config.in new file +5 -0
new file mode 100644
index 0000000..a42bd77
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_CHRONY
+	bool "chrony"
+	help
+	  Chrony is a pair of programs which are used to maintain the
+	  accuracy of the system clock.
package/chrony/chrony.mk new file +6 -0
new file mode 100644
index 0000000..b9733f9
@@ -0,0 +1,6 @@
+CHRONY_VERSION = 1.27
+CHRONY_SITE = http://download.tuxfamily.org/chrony/
+CHRONY_LICENSE = GPLv2
+CHRONY_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 chrony: new package

Dear Nathan Lynch,

Thanks, this looks almost good. A few comments below.

package/chrony/Config.in line 5

Quoted 11 lines · Nathan Lynch
package/chrony/Config.in new file +5 -0
new file mode 100644
index 0000000..a42bd77
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_CHRONY
+	bool "chrony"
+	help
+	  Chrony is a pair of programs which are used to maintain the
+	  accuracy of the system clock.

We generally want a empty new line here, and then the upstream URL of the project.

Also, did you check that this program indeed builds with a minimal uClibc toolchain (no thread, no wchar, no locale, no nothing) ?

package/chrony/chrony.mk

Quoted 6 lines
package/chrony/chrony.mk new file +0 -0
new file mode 100644
index 0000000..b9733f9
@@ -0,0 +1,6 @@

We generally like to have our nice header here, like in all other packages:

#############################################################
#

# bind
#
#############################################################

package/chrony/chrony.mk line 6

Quoted 6 lines
package/chrony/chrony.mk new file +6 -0
+CHRONY_VERSION = 1.27
+CHRONY_SITE = http://download.tuxfamily.org/chrony/
+CHRONY_LICENSE = GPLv2
+CHRONY_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))

Looks good.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 chrony: new package

Quoted 6 lines · Thomas Petazzoni

Dear Nathan Lynch,

Thanks, this looks almost good. A few comments below.

On Mon, 6 May 2013 11:12:55 -0500, Nathan Lynch wrote:

Quoted 14 lines

package/chrony/Config.in line 5

Quoted 11 lines
package/chrony/Config.in new file +5 -0
new file mode 100644
index 0000000..a42bd77
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_CHRONY
+	bool "chrony"
+	help
+	  Chrony is a pair of programs which are used to maintain the
+	  accuracy of the system clock.

We generally want a empty new line here, and then the upstream URL of the project.

Okay, will fix.

Quoted 2 lines

Also, did you check that this program indeed builds with a minimal uClibc toolchain (no thread, no wchar, no locale, no nothing) ?

Sorry, no, that was sloppy of me. I will do so for v2 and try to better specify the package's needs and dependencies. I'd be happy to try any configs you'd care to point out...

Quoted 10 lines

package/chrony/chrony.mk

Quoted 6 lines
package/chrony/chrony.mk new file +0 -0
new file mode 100644
index 0000000..b9733f9
@@ -0,0 +1,6 @@

We generally like to have our nice header here, like in all other packages:

Quoted 5 lines

#############################################################
#

# bind
#
#############################################################

Will fix.

Thanks for the review, Thomas.

#3 lore raw

PATCH 1/1 chrony: new package

Dear Nathan Lynch,

Quoted 6 lines · Nathan Lynch
Quoted 2 lines

Also, did you check that this program indeed builds with a minimal uClibc toolchain (no thread, no wchar, no locale, no nothing) ?

Sorry, no, that was sloppy of me. I will do so for v2 and try to better specify the package's needs and dependencies. I'd be happy to try any configs you'd care to point out...

You can try a very minimal build: no thread, no wchar, no locale, no C++, no nothing. If it builds, you're all set. If your package doesn't build, then something is missing.

If you don't want to spend too much time building toolchains, you can use:

http://autobuild.buildroot.org/toolchains/tarballs/br-arm-basic.tar.bz2
as an external toolchain that is minimal (no C++, no wchar, no locale, no largefile, etc. but it has thread support)

http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-nothread.tar.bz2
as an external that has everything (C++, wchar, locale, largefile, etc.), but doesn't has thread support.

If your package builds with both, then normally you should be all set.

And anyway, since those toolchains are the ones used on the autobuilders, if your package doesn't build in some configuration, it won't be catched by the autobuilders anyway :-)

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 chrony: new package

Quoted 22 lines · Thomas Petazzoni

Dear Nathan Lynch,

Quoted 6 lines · Nathan Lynch
Quoted 2 lines

Also, did you check that this program indeed builds with a minimal uClibc toolchain (no thread, no wchar, no locale, no nothing) ?

Sorry, no, that was sloppy of me. I will do so for v2 and try to better specify the package's needs and dependencies. I'd be happy to try any configs you'd care to point out...

You can try a very minimal build: no thread, no wchar, no locale, no C++, no nothing. If it builds, you're all set. If your package doesn't build, then something is missing.

If you don't want to spend too much time building toolchains, you can use:

http://autobuild.buildroot.org/toolchains/tarballs/br-arm-basic.tar.bz2
as an external toolchain that is minimal (no C++, no wchar, no locale, no largefile, etc. but it has thread support)

Quoted 5 lines

http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-nothread.tar.bz2
as an external that has everything (C++, wchar, locale, largefile, etc.), but doesn't has thread support.

If your package builds with both, then normally you should be all set.

Thank you for this guidance. I verified that the package builds with both of these and found no issues (I did realize it needs MMU, however). I will do similarly for future package submissions.

v2 with the rest of your feedback addressed on its way.

#5 lore raw

PATCH 1/1 chrony: new package

Dear Nathan Lynch,

Quoted 5 lines · Nathan Lynch

Thank you for this guidance. I verified that the package builds with both of these and found no issues (I did realize it needs MMU, however). I will do similarly for future package submissions.

v2 with the rest of your feedback addressed on its way.

Thanks a lot!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com