Skip to contentSkip to conversation

ckmake: make --check-exports default

PATCH In review Luis R. Rodriguez 2 participants 2 messages May 6, 2013 – May 7, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 4/4 ckmake: make --check-exports default

From: "Luis R. Rodriguez" <[email protected]>

Remove --check-exports as an option and now just enable it by default.

---
 devel/ckmake |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
devel/ckmake +1 -3
index 0b738e5..61f9864 100755
@@ -180,7 +180,7 @@ def process_kernel(num, kset, cmdline_args):
 
 		log_file.close()
 		status = p.returncode
-		if status == 0 and cmdline_args.check_exports:
+		if status == 0
 			warn = re.compile('^WARNING:.*undefined.*')
 			log_file = open(log_file_name, 'r')
 			for l in log_file:
@@ -413,8 +413,6 @@ if __name__ == "__main__":
 			    help='Build allyesconfig rather than only backport code.')
 	parser.add_argument('--defconfig', metavar='<name>', type=str,
 			    help='Build this defconfig rather than only backport code.')
-	parser.add_argument('--check-exports', const=True, default=False, action="store_const",
-			    help='Check for linker warnings indicating exported symbols are missing.')
 	args = parser.parse_args()
 
 	if not os.path.exists(modules):
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 14 lines · Luis R. Rodriguez

From: "Luis R. Rodriguez" <[email protected]>

Remove --check-exports as an option and now just enable it by default.

---
 devel/ckmake |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
devel/ckmake +0 -0
index 0b738e5..61f9864 100755

devel/ckmake def process_kernel(num, kset, cmdline_args): · line 183

Quoted 5 lines
devel/ckmake +1 -1
@@ -180,7 +180,7 @@ def process_kernel(num, kset, cmdline_args):
 
 		log_file.close()
 		status = p.returncode
-		if status == 0 and cmdline_args.check_exports:
+		if status == 0

with that fixed (missing colon) of course

johannes