powerpc: Fix MAX_STACK_TRACE_ENTRIES too low warning again
PATCH 1/1 powerpc: Fix MAX_STACK_TRACE_ENTRIES too low warning again
Saw this warning again, and this time from the ret_from_fork path.
It seems we could clear the back chain earlier in copy_thread(), which could cover both path, and also fix potential lockdep usage in schedule_tail(), or exception occurred before we clear the back chain.
--- arch/powerpc/kernel/entry_32.S | 2 -- arch/powerpc/kernel/entry_64.S | 2 -- arch/powerpc/kernel/process.c | 1 + 3 files changed, 1 insertions(+), 4 deletions(-)
arch/powerpc/kernel/entry_32.S +0 -2
@@ -439,8 +439,6 @@ ret_from_fork: ret_from_kernel_thread: REST_NVGPRS(r1) bl schedule_tail - li r3,0 - stw r3,0(r1) mtlr r14 mr r3,r15 PPC440EP_ERR42
arch/powerpc/kernel/entry_64.S +0 -2
@@ -376,8 +376,6 @@ _GLOBAL(ret_from_fork) _GLOBAL(ret_from_kernel_thread) bl .schedule_tail REST_NVGPRS(r1) - li r3,0 - std r3,0(r1) ld r14, 0(r14) mtlr r14 mr r3,r15
arch/powerpc/kernel/process.c +1 -0
@@ -973,6 +973,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,*/ sp -=sizeof (struct pt_regs ); kregs = (struct pt_regs *) sp; + kregs->gpr[1 ] =0 ; sp -=STACK_FRAME_OVERHEAD ; p->thread.ksp = sp; p->thread.ksp_limit = (unsigned long)task_stack_page(p) +
Signature · 1 line
1.7.1
Quoted 5 lines · Li Zhong
Saw this warning again, and this time from the
ret_from_forkpath.It seems we could clear the back chain earlier in
copy_thread(), which could cover both path, and also fix potential lockdep usage inschedule_tail(), or exception occurred before we clear the back chain.
Sorry, I made some mistake, please ignore this patch...
It seems clearing the back chain shouldn't use kregs->gpr[1] below, it should be ((unsigned long*)sp)[0]. I'll send an updated version.
Thanks, Zhong
Quoted 46 lines
Signed-off-by Li Zhong <[email protected]>--- arch/powerpc/kernel/entry_32.S | 2 -- arch/powerpc/kernel/entry_64.S | 2 -- arch/powerpc/kernel/process.c | 1 + 3 files changed, 1 insertions(+), 4 deletions(-)arch/powerpc/kernel/entry_32.S +0
-2@@ -439,8 +439,6 @@ ret_from_fork: ret_from_kernel_thread: REST_NVGPRS(r1) bl schedule_tail - li r3,0 - stw r3,0(r1) mtlr r14 mr r3,r15 PPC440EP_ERR42arch/powerpc/kernel/entry_64.S +0
-2@@ -376,8 +376,6 @@ _GLOBAL(ret_from_fork) _GLOBAL(ret_from_kernel_thread) bl .schedule_tail REST_NVGPRS(r1) - li r3,0 - std r3,0(r1) ld r14, 0(r14) mtlr r14 mr r3,r15arch/powerpc/kernel/process.c +1
-0@@ -973,6 +973,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,*/ sp -=sizeof (struct pt_regs ); kregs = (struct pt_regs *) sp; + kregs->gpr[1 ] =0 ; sp -=STACK_FRAME_OVERHEAD ; p->thread.ksp = sp; p->thread.ksp_limit = (unsigned long)task_stack_page(p) +
PATCH v2 1/1 powerpc: Fix MAX_STACK_TRACE_ENTRIES too low warning again
In reply to Li ZhongSaw this warning again, and this time from the ret_from_fork path.
It seems we could clear the back chain earlier in copy_thread(), which could cover both path, and also fix potential lockdep usage in schedule_tail(), or exception occurred before we clear the back chain.
---
arch/powerpc/kernel/entry_32.S | 2 -- arch/powerpc/kernel/entry_64.S | 2 -- arch/powerpc/kernel/process.c | 1 + 3 files changed, 1 insertion(+), 4 deletions(-)
arch/powerpc/kernel/entry_32.S +0 -2
@@ -439,8 +439,6 @@ ret_from_fork: ret_from_kernel_thread: REST_NVGPRS(r1) bl schedule_tail - li r3,0 - stw r3,0(r1) mtlr r14 mr r3,r15 PPC440EP_ERR42
arch/powerpc/kernel/entry_64.S +0 -2
@@ -376,8 +376,6 @@ _GLOBAL(ret_from_fork) _GLOBAL(ret_from_kernel_thread) bl .schedule_tail REST_NVGPRS(r1) - li r3,0 - std r3,0(r1) ld r14, 0(r14) mtlr r14 mr r3,r15
arch/powerpc/kernel/process.c +1 -0
@@ -971,6 +971,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,* do some house keeping and then return from the fork or clone * system call, using the stack frame created above. */ + ((unsigned long *)sp)[0 ] =0 ; sp -=sizeof (struct pt_regs ); kregs = (struct pt_regs *) sp; sp -=STACK_FRAME_OVERHEAD ;