Fix test 298 to work for non-XFS filesystems
PATCH 1/2 Fix test 298 to work for non-XFS filesystems
Call to xfs_io in test 298 forgot to specify -F flag so it failed for non-XFS filesystems.
--- tests/shared/298 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/shared/298 +1 -1
@@ -49,7 +49,7 @@ _cleanup() get_holes() { - $XFS_IO_PROG -c fiemap $1 | grep hole | $SED_PROG 's/.*\[\(.*\)\.\.\(.*\)\].*/\1 \2/' + $XFS_IO_PROG -F -c fiemap $1 | grep hole | $SED_PROG 's/.*\[\(.*\)\.\.\(.*\)\].*/\1 \2/' } get_free_sectors()
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 2/2 Make test 306 use null and zero device nodes on SCRATCH_MNT
In one place of test 306, we mistakenly used /dev/null and /dev/zero instead of equivalent devices created on tested filesystem. So we were not really testing the functionality we intended.
--- tests/generic/306 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/generic/306 +2 -2
@@ -73,9 +73,9 @@ _scratch_mount -o ro || _fail "Could not mount scratch readonly" echo "== try to create new file" touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch echo "== pwrite to null device" -$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io +$XFS_IO_PROG -F -c "pwrite 0 512" $DEVNULL | _filter_xfs_io echo "== pread from zero device" -$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io +$XFS_IO_PROG -F -c "pread 0 512" $DEVZERO | _filter_xfs_io echo "== truncating write to null device" echo foo > $DEVNULL 2>&1 | _filter_scratch
Signature · 6 lines
1.8.1.4 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 2/2] Make test 306 use null and zero device nodes on SCRATCH_MNT
Quoted 5 lines · Jan Kara
In one place of test 306, we mistakenly used
/dev/nulland/dev/zeroinstead of equivalent devices created on tested filesystem. So we were not really testing the functionality we intended.Signed-off-by Jan Kara <[email protected]>
Ugh. A fine mistake on my part. Thanks for catching that, cripes!
Quoted 11 lines
--- tests/generic/306 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tests/generic/306 +0
-0@@ -73,9 +73,9 @@ _scratch_mount -o ro || _fail "Could not mount scratch readonly" echo "== try to create new file"
tests/generic/306 _scratch_mount -o ro || _fail "Could not mount scratch readonly" · line 81
Quoted 10 lines
tests/generic/306 +2
-2touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch echo "== pwrite to null device" -$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io +$XFS_IO_PROG -F -c "pwrite 0 512" $DEVNULL | _filter_xfs_io echo "== pread from zero device" -$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io +$XFS_IO_PROG -F -c "pread 0 512" $DEVZERO | _filter_xfs_io echo "== truncating write to null device" echo foo > $DEVNULL 2>&1 | _filter_scratch
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 2/2] Make test 306 use null and zero device nodes on SCRATCH_MNT
In reply to Jan KaraThis patch has been committed:
commit 2941898570ccdb32ab5af89c0b25147231489973
Author: Jan Kara <[email protected]> Date: Tue May 14 07:02:50 2013 -0500
Make test 306 use null and zero device nodes on SCRATCH_MNT
Thanks
--Rich
Quoted 4 lines · Jan Kara
In one place of test 306, we mistakenly used
/dev/nulland/dev/zeroinstead of equivalent devices created on tested filesystem. So we were not really testing the functionality we intended.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 4 lines · Jan Kara
Call to
xfs_ioin test 298 forgot to specify -F flag so it failed for non-XFS filesystems.Signed-off-by Jan Kara <[email protected]>
See Eric's recent patch series to fix this.
http://oss.sgi.com/pipermail/xfs/2013-May/026057.html
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs