mtd: nand_base: Only use GET/SET FEATURES command on chips that support them.
Subsystems (2)
PATCH 1/1 mtd: nand_base: Only use GET/SET FEATURES command on chips that support them.
From: David Mosberger <[email protected]>
Spansion's S34MLx chips support ONFI but not the GET/SET FEATURES calls.
Signed-off-by David Mosberger <[email protected]>
Reviewed-by Huang Shijie <[email protected]>
--- drivers/mtd/nand/nand_base.c | 8 ++++++-- include/linux/mtd/nand.h | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-)
drivers/mtd/nand/nand_base.c +6 -2
@@ -2720,7 +2720,9 @@ static int nand_onfi_set_features(struct mtd_info *mtd, struct nand_chip *chip, {int status; -if (!chip->onfi_version) +if (!chip->onfi_version || + !(le16_to_cpu (chip->onfi_params.opt_cmd) + &ONFI_OPT_CMD_SET_GET_FEATURES ))return -EINVAL ; chip->cmdfunc (mtd,NAND_CMD_SET_FEATURES , addr,-1 );
@@ -2741,7 +2743,9 @@ static int nand_onfi_set_features(struct mtd_info *mtd, struct nand_chip *chip,static int nand_onfi_get_features (struct mtd_info *mtd,struct nand_chip *chip,int addr,uint8_t *subfeature_param) { -if (!chip->onfi_version) +if (!chip->onfi_version || + !(le16_to_cpu (chip->onfi_params.opt_cmd) + &ONFI_OPT_CMD_SET_GET_FEATURES ))return -EINVAL ;/* clear the sub feature parameters */
include/linux/mtd/nand.h +3 -0
@@ -217,6 +217,9 @@ struct nand_chip;/* ONFI subfeature parameters length */ #define ONFI_SUBFEATURE_PARAM_LEN 4 +/* ONFI optional commands SET/GET FEATURES supported? */ +#define ONFI_OPT_CMD_SET_GET_FEATURES (1 << 2) +struct nand_onfi_params {/* rev info and features block */ /* 'O' 'N' 'F' 'I' */
Signature · 1 line
1.7.5.4