Skip to contentSkip to conversation

hid: remove duplicate ID for D-WAV eGalax 0x7224

PATCH In review Andy Shevchenko 4 participants 5 messages May 7, 2013 – May 13, 2013 1 message not in the archive HID

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1367936944-1624?= =?ISO-8859-1?Q?9-2-git-send-ema?= =?ISO-8859-1?Q?il-andriy.shevch?= [email protected]?= =?ISO-8859-1?Q?.com=1B[B=1B[B=1B[B

#1 lore raw

PATCH v2 1/1 hid: remove duplicate ID for D-WAV eGalax 0x7224

---
 drivers/hid/hid-ids.h | 1 -
 1 file changed, 1 deletion(-)
drivers/hid/hid-ids.h +0 -1
index 2378a0b..a5520ba 100644
@@ -268,7 +268,6 @@
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207	0x7207
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C	0x720c
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
-#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A	0x722A
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E	0x725e
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262	0x7262
Signature · 1 line
1.8.2.rc0.22.gb3600c3
#2 lore raw
Quoted 2 lines · Andy Shevchenko

---

I bet it will be easier to track for Jiri if you resend the full series:
- the egalax reordering
- the remove of the duplicate ID

As mentioned previously, also remove the entry in hid-multitouch (the one containing MT_CLS_EGALAX, not the _SERIAL one).

Cheers,
Benjamin

Quoted 16 lines
 drivers/hid/hid-ids.h | 1 -
 1 file changed, 1 deletion(-)
drivers/hid/hid-ids.h +0 -1
index 2378a0b..a5520ba 100644
@@ -268,7 +268,6 @@
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207	0x7207
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C	0x720c
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
-#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A	0x722A
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E	0x725e
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262	0x7262
#3 lore raw
Quoted 10 lines · Benjamin Tissoires
Quoted 2 lines · Andy Shevchenko

---

I bet it will be easier to track for Jiri if you resend the full series:
- the egalax reordering
- the remove of the duplicate ID

As mentioned previously, also remove the entry in hid-multitouch (the one containing MT_CLS_EGALAX, not the _SERIAL one).

Then it repeats v1, doesn't it?

The difference between MT_USB_DEVICE and HID_USB_DEVICE macros is in .group member. Does it somehow affect device matching?

Quoted 21 lines

Cheers,
Benjamin

Quoted 16 lines
 drivers/hid/hid-ids.h | 1 -
 1 file changed, 1 deletion(-)
drivers/hid/hid-ids.h +0 -1
index 2378a0b..a5520ba 100644
@@ -268,7 +268,6 @@
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207	0x7207
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C	0x720c
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
-#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A	0x722A
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E	0x725e
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262	0x7262
Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#4 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Benjamin Tissoires
Quoted 2 lines · Andy Shevchenko

---

Quoted 8 lines
Quoted 6 lines

I bet it will be easier to track for Jiri if you resend the full series:
- the egalax reordering
- the remove of the duplicate ID

As mentioned previously, also remove the entry in hid-multitouch (the one containing MT_CLS_EGALAX, not the _SERIAL one).

Then it repeats v1, doesn't it?

I can not speak for Jiri, but IMO, it's easier to say:
"Hey Jiri, pick up the patch series v3 for this topic", instead of "Hey Jiri, please pick the patch 1 from v1 and patch 2 from v4 about this topic."

So I would say yes, repeat v1 but add a comment in the cover letter explaining the changes (for example, no changes in patch 1/2, patch 2/2 amended like this and that).

Quoted 4 lines

The difference between MT_USB_DEVICE and HID_USB_DEVICE macros is in .group member. Does it somehow affect device matching?

It does internally to some extend, but it won't change the final handling. MT_USB_DEVICE is cleaner because it will ask to grab only the MT interface. HID_USB_DEVICE will introduce a race with hid-generic to handle the non-MT interfaces, which are not present in the eGalax case IIRC. So basically, we just missed that HID_USB_ / MT_USB_ problem when including the patch upstream.

Cheers,
Benjamin

#5 lore raw
Quoted 16 lines · Benjamin Tissoires
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Benjamin Tissoires
Quoted 2 lines · Andy Shevchenko

---

Quoted 8 lines
Quoted 6 lines

I bet it will be easier to track for Jiri if you resend the full series:
- the egalax reordering
- the remove of the duplicate ID

As mentioned previously, also remove the entry in hid-multitouch (the one containing MT_CLS_EGALAX, not the _SERIAL one).

Then it repeats v1, doesn't it?

Quoted 8 lines

I can not speak for Jiri, but IMO, it's easier to say:
"Hey Jiri, pick up the patch series v3 for this topic", instead of "Hey Jiri, please pick the patch 1 from v1 and patch 2 from v4 about this topic."

So I would say yes, repeat v1 but add a comment in the cover letter explaining the changes (for example, no changes in patch 1/2, patch 2/2 amended like this and that).

Yes, exactly, please just do a fresh resend of the series with all the feedback incorporated.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs