ASoC: da7213: Fix setting dmic_samplephase and dmic_clk_rate
Subsystems (3)
PATCH 1/1 ASoC: da7213: Fix setting dmic_samplephase and dmic_clk_rate
When set dmic_samplephase and dmic_clk_rate bits for dmic_cfg, current code checks pdata->dmic_data_sel which is wrong.
---
This looks like a copy-paste bug.
sound/soc/codecs/da7213.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/da7213.c +4 -4
@@ -1488,17 +1488,17 @@ static int da7213_probe(struct snd_soc_codec *codec) DA7213_DMIC_DATA_SEL_SHIFT);break ; } -switch (pdata->dmic_data_sel) { +switch (pdata->dmic_samplephase) {case DA7213_DMIC_SAMPLE_ON_CLKEDGE :case DA7213_DMIC_SAMPLE_BETWEEN_CLKEDGE : - dmic_cfg |= (pdata->dmic_data_sel << + dmic_cfg |= (pdata->dmic_samplephase <<DA7213_DMIC_SAMPLEPHASE_SHIFT );break ; } -switch (pdata->dmic_data_sel) { +switch (pdata->dmic_clk_rate) {case DA7213_DMIC_CLK_3_0MHZ :case DA7213_DMIC_CLK_1_5MHZ : - dmic_cfg |= (pdata->dmic_data_sel << + dmic_cfg |= (pdata->dmic_clk_rate <<DA7213_DMIC_CLK_RATE_SHIFT );break ; }
Signature · 1 line
1.8.1.2
Quoted 2 lines · Axel Lin
When set
dmic_samplephaseanddmic_clk_ratebits fordmic_cfg, current code checkspdata->dmic_data_selwhich is wrong.
Applied, thanks.
Apologies. Completely missed this e-mail.
Good spot. Thanks for the update.
Quoted 47 lines
-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: 09 May 2013 14:14
To: Mark Brown
Cc: Liam Girdwood; Opensource [Adam Thomson]; [email protected]
Subject: [PATCH RFT] ASoC: da7213: Fix settingdmic_samplephaseanddmic_clk_rateWhen set
dmic_samplephaseanddmic_clk_ratebits fordmic_cfg, current code checkspdata->dmic_data_selwhich is wrong.Signed-off-by Axel Lin <[email protected]>---
This looks like a copy-paste bug.sound/soc/codecs/da7213.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)sound/soc/codecs/da7213.c +4
-5@@ -1488,17 +1488,17 @@ static int da7213_probe(struct snd_soc_codec *codec) DA7213_DMIC_DATA_SEL_SHIFT);break ; } -switch (pdata->dmic_data_sel) { +switch (pdata->dmic_samplephase) {case DA7213_DMIC_SAMPLE_ON_CLKEDGE :case DA7213_DMIC_SAMPLE_BETWEEN_CLKEDGE : - dmic_cfg |= (pdata->dmic_data_sel << + dmic_cfg |= (pdata->dmic_samplephase <<DA7213_DMIC_SAMPLEPHASE_SHIFT );break ; } -switch (pdata->dmic_data_sel) { +switch (pdata->dmic_clk_rate) {case DA7213_DMIC_CLK_3_0MHZ :case DA7213_DMIC_CLK_1_5MHZ : - dmic_cfg |= (pdata->dmic_data_sel << + dmic_cfg |= (pdata->dmic_clk_rate <<DA7213_DMIC_CLK_RATE_SHIFT );break ; } --1.8.1.2