sched: use this_rq() helper
PATCH 1/1 sched: use this_rq() helper
It is a few instructions more efficent to and slightly more readable to use this_rq()-> instead of cpu_rq(smp_processor_id()->
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Signed-off-by Nathan Zimmer <[email protected]>
--- kernel/sched/fair.c | 6 ++---- kernel/sched/rt.c | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-)
kernel/sched/fair.c +2 -4
@@ -5418,10 +5418,9 @@ static inline void nohz_balance_exit_idle(int cpu)static inline void set_cpu_sd_state_busy (void ) {struct sched_domain *sd; -int cpu =smp_processor_id ();rcu_read_lock (); - sd =rcu_dereference_check_sched_domain (cpu_rq (cpu)->sd); + sd =rcu_dereference_check_sched_domain (this_rq ()->sd);if (!sd || !sd->nohz_idle) goto unlock;
@@ -5436,10 +5435,9 @@ unlock:void set_cpu_sd_state_idle (void ) {struct sched_domain *sd; -int cpu =smp_processor_id ();rcu_read_lock (); - sd =rcu_dereference_check_sched_domain (cpu_rq (cpu)->sd); + sd =rcu_dereference_check_sched_domain (this_rq ()->sd);if (!sd || sd->nohz_idle) goto unlock;
kernel/sched/rt.c +1 -1
@@ -472,7 +472,7 @@ static int rt_se_boosted(struct sched_rt_entity *rt_se)#ifdef CONFIG_SMP static inline const struct cpumask *sched_rt_period_mask (void ) { -return cpu_rq (smp_processor_id ())->rd->span; +return this_rq ()->rd->span; }#else static inline const struct cpumask *sched_rt_period_mask (void )
Signature · 1 line
1.8.2.1
Quoted 2 lines · Nathan Zimmer
It is a few instructions more efficent to and slightly more readable to use this_rq()-> instead of cpu_rq(smp_processor_id()->
If you've taken the trouble of actually measuring this, including the measurement results is appreciated.
But yes, it also makes the code slightly smaller.
Thanks!
Acked-by Peter Zijlstra <[email protected]>
tip-bot for Nathan Zimmer
merge bot[tip:sched/core] sched: Use this_rq() helper
In reply to Nathan Zimmersched: Use this_rq() helper
Commit-ID: 424c93fe4cbe719e7fd7169248d2b648c493b68d Gitweb: http://git.kernel.org/tip/424c93fe4cbe719e7fd7169248d2b648c493b68d Author: Nathan Zimmer <[email protected]> AuthorDate: Thu, 9 May 2013 11:24:03 -0500 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 10 May 2013 10:35:56 +0200
sched: Use this_rq() helper
It is a few instructions more efficent to and slightly more readable to use this_rq()-> instead of cpu_rq(smp_processor_id())-> .
Size comparison of kernel/sched/fair.o:
text data bss dec hex filename
27972 122 26 28120 6dd8 fair.o.before 27956 122 26 28104 6dc8 fair.o.after
Signed-off-by Nathan Zimmer <[email protected]>
Cc Peter Zijlstra <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- kernel/sched/fair.c | 6 ++---- kernel/sched/rt.c | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-)
kernel/sched/fair.c +2 -4
@@ -5418,10 +5418,9 @@ static inline void nohz_balance_exit_idle(int cpu)static inline void set_cpu_sd_state_busy (void ) {struct sched_domain *sd; -int cpu =smp_processor_id ();rcu_read_lock (); - sd =rcu_dereference_check_sched_domain (cpu_rq (cpu)->sd); + sd =rcu_dereference_check_sched_domain (this_rq ()->sd);if (!sd || !sd->nohz_idle) goto unlock;
@@ -5436,10 +5435,9 @@ unlock:void set_cpu_sd_state_idle (void ) {struct sched_domain *sd; -int cpu =smp_processor_id ();rcu_read_lock (); - sd =rcu_dereference_check_sched_domain (cpu_rq (cpu)->sd); + sd =rcu_dereference_check_sched_domain (this_rq ()->sd);if (!sd || sd->nohz_idle) goto unlock;
kernel/sched/rt.c +1 -1
@@ -472,7 +472,7 @@ static int rt_se_boosted(struct sched_rt_entity *rt_se)#ifdef CONFIG_SMP static inline const struct cpumask *sched_rt_period_mask (void ) { -return cpu_rq (smp_processor_id ())->rd->span; +return this_rq ()->rd->span; }#else static inline const struct cpumask *sched_rt_period_mask (void )