Skip to contentSkip to conversation

xfrm6: release dev before returning error

PATCH In review Cong Wang 2 participants 2 messages May 10, 2013 – May 12, 2013

Subsystems (3)
lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH 1/1 xfrm6: release dev before returning error

From: Cong Wang <[email protected]>

We forget to call dev_put() on error path in xfrm6_fill_dst(), its caller doesn't handle this.

Cc Herbert Xu <[email protected]>
Cc Steffen Klassert <[email protected]>
Cc David S. Miller <[email protected]>

---

net/ipv6/xfrm6_policy.c +3 -1
index 4ef7bdb..23ed03d 100644
@@ -103,8 +103,10 @@ static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev,
 	dev_hold(dev);
 
 	xdst->u.rt6.rt6i_idev = in6_dev_get(dev);
-	if (!xdst->u.rt6.rt6i_idev)
+	if (!xdst->u.rt6.rt6i_idev) {
+		dev_put(dev);
 		return -ENODEV;
+	}
 
 	rt6_transfer_peer(&xdst->u.rt6, rt);