sparse, llvm: fix link errors
Subsystems (2)
PATCH 1/1 sparse, llvm: fix link errors
This patch fixes the following link errors.
libLLVMSupport.a(Signals.o): In function `llvm::sys::PrintStackTrace(_IO_FILE*)':
Signals.inc:269: undefined reference to `dladdr'
Signals.inc:281: undefined reference to `dladdr'
--- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
@@ -84,14 +84,14 @@ HAVE_LLVM=no else LLVM_PROGS := sparse-llvm $(LLVM_PROGS): LD := g++ -LDFLAGS += $(shell llvm-config --ldflags) +LLVM_LDFLAGS := $(shell llvm-config --ldflags) LLVM_CFLAGS := $(shell llvm-config --cflags | sed -e "s/-DNDEBUG//g") LLVM_LIBS := $(shell llvm-config --libs) PROGRAMS += $(LLVM_PROGS) INST_PROGRAMS += sparse-llvm sparsec sparse-llvm_EXTRA_DEPS := sparse-llvm.o sparse-llvm.o $(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS) -sparse-llvm_EXTRA_OBJS := $(LLVM_LIBS) +sparse-llvm_EXTRA_OBJS := $(LLVM_LIBS) $(LLVM_LDFLAGS) endif endif
Signature · 1 line
1.8.1.2
Christopher Li
maintainerReview
Quoted 9 lines · Xi Wang
This patch fixes the following link errors.
libLLVMSupport.a(Signals.o): In function `llvm::sys::PrintStackTrace(_IO_FILE*)':
Signals.inc:269: undefined reference to `dladdr'
Signals.inc:281: undefined reference to `dladdr'(quoted diff) +1
-1-sparse-llvm_EXTRA_OBJS := $(LLVM_LIBS) +sparse-llvm_EXTRA_OBJS := $(LLVM_LIBS) $(LLVM_LDFLAGS)
The EXTRA_OBJS is only mean for real objects.
the LDFLAGS should be not belong to here.
I can't duplicate the link error myself.
It seems that you only want the LLVM_LDFLAGS apply to sparse-llvm only.
Can you try this patch?
Thanks
Chris
Makefile +1 -1
@@ -84,7 +84,7 @@ HAVE_LLVM=no else LLVM_PROGS := sparse-llvm $(LLVM_PROGS): LD := g++ -LDFLAGS += $(shell llvm-config --ldflags) +$(LLVM_PROGS): LDFLAGS += $(shell llvm-config --ldflags) LLVM_CFLAGS := $(shell llvm-config --cflags | sed -e "s/-DNDEBUG//g") LLVM_LIBS := $(shell llvm-config --libs) PROGRAMS += $(LLVM_PROGS)
Quoted 8 lines · Christopher Li
The
EXTRA_OBJSis only mean for real objects.
the LDFLAGS should be not belong to here.I can't duplicate the link error myself.
It seems that you only want theLLVM_LDFLAGSapply to sparse-llvm only.Can you try this patch?
This doesn't work for me.
The problem is that -ldl (llvm --ldflags) must come _after_ -lLLVMSupport (llvm --libs).
Can we move LDFLAGS?
Makefile +2 -2
@@ -84,7 +84,7 @@ HAVE_LLVM=no else LLVM_PROGS := sparse-llvm $(LLVM_PROGS): LD := g++ -LDFLAGS += $(shell llvm-config --ldflags) +$(LLVM_PROGS): LDFLAGS += $(shell llvm-config --ldflags) LLVM_CFLAGS := $(shell llvm-config --cflags | sed -e "s/-DNDEBUG//g") LLVM_LIBS := $(shell llvm-config --libs) PROGRAMS += $(LLVM_PROGS)
@@ -173,7 +173,7 @@ compile_EXTRA_DEPS = compile-i386.o $(foreach p,$(PROGRAMS),$(eval $(p): $($(p)_EXTRA_DEPS) $(LIBS))) $(PROGRAMS): % : %.o - $(QUIET_LINK)$(LD) $(LDFLAGS) -o $@ $^ $($@_EXTRA_OBJS) + $(QUIET_LINK)$(LD) -o $@ $^ $($@_EXTRA_OBJS) $(LDFLAGS) $(LIB_FILE): $(LIB_OBJS) $(QUIET_AR)$(AR) rcs $@ $(LIB_OBJS)
Christopher Li
maintainerQuoted 8 lines · Xi Wang
This doesn't work for me.
The problem is that -ldl (
llvm --ldflags) must come _after_ -lLLVMSupport (llvm --libs).Can we move LDFLAGS?
Sorry for the late reply.
In that case, your first patch is actually cleaner. I apply your first patch instead. Change pushed.
BTW, Pekka, I notice that "sparse-llvm_EXTRA_DEPS" is redundant with the next line, which also have sparse-llvm.o. Am I miss some thing?
sparse-llvm_EXTRA_DEPS := sparse-llvm.o
sparse-llvm.o $(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS)
Chris
Quoted 6 lines · Christopher Li
BTW, Pekka, I notice that "sparse-llvm_EXTRA_DEPS" is redundant with the next line, which also have sparse-llvm.o. Am I miss some thing?
sparse-llvm_EXTRA_DEPS := sparse-llvm.o
sparse-llvm.o $(sparse-llvm_EXTRA_DEPS):BASIC_CFLAGS+= $(LLVM_CFLAGS)
No, I you're not missing anything. Feel free to drop it.