Skip to contentSkip to conversation

GFS2: two minor quota fixups

PATCH New Bob Peterson 2 participants 2 messages May 10, 2013 – May 13, 2013 1 message not in the archive GFS2 file system

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 GFS2: two minor quota fixups

Hi,

This patch fixes two regression problems that Abhi found in the GFS2 quota code.

Regards,

Bob Peterson
Red Hat File Systems

---

fs/gfs2/quota.c +2 -2
index c7c840e..c253b13 100644
@@ -121,7 +121,7 @@ static u64 qd2index(struct gfs2_quota_data *qd)
 {
 	struct kqid qid = qd->qd_id;
 	return (2 * (u64)from_kqid(&init_user_ns, qid)) +
-		(qid.type == USRQUOTA) ? 0 : 1;
+		((qid.type == USRQUOTA) ? 0 : 1);
 }
 
 static u64 qd2offset(struct gfs2_quota_data *qd)
@@ -721,7 +721,7 @@ get_a_page:
 			goto unlock_out;
 	}
 
-	gfs2_trans_add_meta(ip->i_gl, bh);
+	gfs2_trans_add_data(ip->i_gl, bh);
 
 	kaddr = kmap_atomic(page);
 	if (offset + sizeof(struct gfs2_quota) > PAGE_CACHE_SIZE)
#2 lore raw

PATCH 1/1 GFS2: two minor quota fixups

Hi,

Now in the -nmw tree. Thanks,

Steve.

Quoted 35 lines · Bob Peterson

Hi,

This patch fixes two regression problems that Abhi found in the GFS2 quota code.

Regards,

Bob Peterson
Red Hat File Systems

---

fs/gfs2/quota.c +2 -2
index c7c840e..c253b13 100644
@@ -121,7 +121,7 @@ static u64 qd2index(struct gfs2_quota_data *qd)
 {
 	struct kqid qid = qd->qd_id;
 	return (2 * (u64)from_kqid(&init_user_ns, qid)) +
-		(qid.type == USRQUOTA) ? 0 : 1;
+		((qid.type == USRQUOTA) ? 0 : 1);
 }
 
 static u64 qd2offset(struct gfs2_quota_data *qd)
@@ -721,7 +721,7 @@ get_a_page:
 			goto unlock_out;
 	}
 
-	gfs2_trans_add_meta(ip->i_gl, bh);
+	gfs2_trans_add_data(ip->i_gl, bh);
 
 	kaddr = kmap_atomic(page);
 	if (offset + sizeof(struct gfs2_quota) > PAGE_CACHE_SIZE)