Skip to contentSkip to conversation

Intel TXT driver

PATCH Superseded Qiaowei Ren 9 participants 23 messages May 13, 2013 – Apr 12, 2022

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Intel TXT driver

Changeslog from v1:
* remove tboot log code
* add terms description in commit log and comment at the top of the driver
* check whether a platform has TXT support before registering a device

This module is expected to be a better tool to access below resources
- TXT config space
- SMX parameter

Intel TXT (Trusted Execution Technology) will provide higher assurance of system configuration and initial state as well as data reset protection. It also helps solve real end user concerns about having confidence that their hardware is running the VMM or kernel that it was configured with, especially since they may be responsible for providing such assurances to VMs and services running on it.

See Documentation/intel_txt.txt for more information about Intel TXT.

Intel TXT configuration registers are a subset of chipset registers. These chipset registers that interact with SMX are accessed from two regions of memory, which represent the public and private configuration spaces, by system software using memory read/write protocols.

Safer Mode Extensions (SMX) provide a processor's programming interface in an Intel TXT platform for system software to establish a measured environment within the platform to support trust decisions by end users.

With this module, it will be easier to access TXT related information.

Qiaowei Ren (3):
driver: add TXT driver in kernel
driver: provide sysfs interfaces to access TXT config space
driver: provide sysfs interfaces to access SMX parameter

 Documentation/ABI/testing/sysfs-platform-intel-txt |  382 ++++++++
 drivers/platform/x86/Kconfig                       |    2 +
 drivers/platform/x86/Makefile                      |    1 +
 drivers/platform/x86/intel_txt/Kconfig             |   27 +
 drivers/platform/x86/intel_txt/Makefile            |    5 +
 drivers/platform/x86/intel_txt/txt-config.c        | 1029 ++++++++++++++++++++
 drivers/platform/x86/intel_txt/txt-config.h        |  138 +++
 drivers/platform/x86/intel_txt/txt-parameter.c     |  254 +++++
 drivers/platform/x86/intel_txt/txt-parameter.h     |   39 +
 drivers/platform/x86/intel_txt/txt-sysfs.c         |   79 ++
 10 files changed, 1956 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-platform-intel-txt
 create mode 100644 drivers/platform/x86/intel_txt/Kconfig
 create mode 100644 drivers/platform/x86/intel_txt/Makefile
 create mode 100644 drivers/platform/x86/intel_txt/txt-config.c
 create mode 100644 drivers/platform/x86/intel_txt/txt-config.h
 create mode 100644 drivers/platform/x86/intel_txt/txt-parameter.c
 create mode 100644 drivers/platform/x86/intel_txt/txt-parameter.h
 create mode 100644 drivers/platform/x86/intel_txt/txt-sysfs.c
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/3 driver: add TXT driver in kernel

TXT driver can be used to access below resources:
- TXT config space
- SMX parameter

Intel TXT (Trusted Execution Technology) will provide higher assurance of system configuration and initial state as well as data reset protection. It also helps solve real end user concerns about having confidence that their hardware is running the VMM or kernel that it was configured with, especially since they may be responsible for providing such assurances to VMs and services running on it.

See Documentation/intel_txt.txt for more information about Intel TXT.

Intel TXT configuration registers are a subset of chipset registers. These chipset registers that interact with SMX are accessed from two regions of memory, which represent the public and private configuration spaces, by system software using memory read/write protocols.

Safer Mode Extensions (SMX) provide a processor's programming interface in an Intel TXT platform for system software to establish a measured environment within the platform to support trust decisions by end users.

---
 drivers/platform/x86/Kconfig               |    2 +
 drivers/platform/x86/Makefile              |    1 +
 drivers/platform/x86/intel_txt/Kconfig     |   27 ++++++++++++
 drivers/platform/x86/intel_txt/Makefile    |    5 +++
 drivers/platform/x86/intel_txt/txt-sysfs.c |   62 ++++++++++++++++++++++++++++
 5 files changed, 97 insertions(+)
 create mode 100644 drivers/platform/x86/intel_txt/Kconfig
 create mode 100644 drivers/platform/x86/intel_txt/Makefile
 create mode 100644 drivers/platform/x86/intel_txt/txt-sysfs.c
drivers/platform/x86/Kconfig +2 -0
index 3338437..2c50e7d 100644
@@ -693,6 +693,8 @@ config INTEL_IPS
 	  functionality.  If in doubt, say Y here; it will only load on
 	  supported platforms.
 
+source "drivers/platform/x86/intel_txt/Kconfig"
+
 config IBM_RTL
 	tristate "Device driver to enable PRTL support"
 	depends on X86 && PCI
drivers/platform/x86/Makefile +1 -0
index ace2b38..669b464 100644
@@ -40,6 +40,7 @@ obj-$(CONFIG_INTEL_SCU_IPC)	+= intel_scu_ipc.o
 obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o
 obj-$(CONFIG_INTEL_MFLD_THERMAL) += intel_mid_thermal.o
 obj-$(CONFIG_INTEL_IPS)		+= intel_ips.o
+obj-$(CONFIG_INTEL_TXT_DRIVER)	+= intel_txt/
 obj-$(CONFIG_GPIO_INTEL_PMIC)	+= intel_pmic_gpio.o
 obj-$(CONFIG_XO1_RFKILL)	+= xo1-rfkill.o
 obj-$(CONFIG_XO15_EBOOK)	+= xo15-ebook.o
drivers/platform/x86/intel_txt/Kconfig new file +27 -0
new file mode 100644
index 0000000..dd81b21
@@ -0,0 +1,27 @@
+#
+# intel TXT driver configuration
+#
+
+config INTEL_TXT_DRIVER
+	tristate "INTEL TXT sysfs driver"
+	default m
+	depends on INTEL_TXT
+	select SECURITYFS
+	---help---
+	  TXT Driver can be used to access below resources:
+	    - TXT config space
+	    - SMX parameter
+
+	  Intel TXT configuration registers are a subset of chipset
+	  registers. These chipset registers that interact with SMX
+	  are accessed from two regions of memory, which represent
+	  the public and private configuration spaces, by system
+	  software using memory read/write protocols.
+
+	  Safer Mode Extensions (SMX) provide a processor's programming
+	  interface in an Intel TXT platform for system software to
+	  establish a measured environment within the platform to support
+	  trust decisions by end users.
+
+	  To compile this driver as a module, choose M here; the module
+	  will be called intel_txt.
drivers/platform/x86/intel_txt/Makefile new file +5 -0
new file mode 100644
index 0000000..a130308
@@ -0,0 +1,5 @@
+#
+# Makefile for the intel TXT drivers.
+#
+obj-$(CONFIG_INTEL_TXT_DRIVER) += intel_txt.o
+intel_txt-y := txt-sysfs.o
drivers/platform/x86/intel_txt/txt-sysfs.c new file +62 -0

62 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH v2 1/3] driver: add TXT driver in kernel

drivers/platform/x86/intel_txt/txt-sysfs.c line 45

Quoted 4 lines · Qiaowei Ren

static int __init txt_sysfs_init(void)

drivers/platform/x86/intel_txt/txt-sysfs.c new file +3 -0
+{
+	if (!tboot_enabled())
+		return -ENODEV;

If there's a CPU flag that indicates tboot support, you should add a modalias for it in order to ensure that the module gets automatically loaded.

Signature · 1 line
Matthew Garrett | [email protected]
#3 lore raw

RE: [PATCH v2 1/3] driver: add TXT driver in kernel

Quoted 8 lines · Matthew Garrett

drivers/platform/x86/intel_txt/txt-sysfs.c line 45

Quoted 4 lines · Qiaowei Ren

static int __init txt_sysfs_init(void)

drivers/platform/x86/intel_txt/txt-sysfs.c new file +3 -0
+{
+	if (!tboot_enabled())
+		return -ENODEV;

If there's a CPU flag that indicates tboot support, you should add a modalias for it in order to ensure that the module gets automatically loaded.

Ok.

Thanks,
Qiaowei

#4 lore raw

PATCH v2 2/3 driver: provide sysfs interfaces to access TXT config space

In reply to Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config, and including totally 37 files, providing access to Intel TXT configuration registers.

---
 Documentation/ABI/testing/sysfs-platform-intel-txt |  309 ++++++
 drivers/platform/x86/intel_txt/Makefile            |    2 +-
 drivers/platform/x86/intel_txt/txt-config.c        | 1029 ++++++++++++++++++++
 drivers/platform/x86/intel_txt/txt-config.h        |  138 +++
 drivers/platform/x86/intel_txt/txt-sysfs.c         |   12 +
 5 files changed, 1489 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/ABI/testing/sysfs-platform-intel-txt
 create mode 100644 drivers/platform/x86/intel_txt/txt-config.c
 create mode 100644 drivers/platform/x86/intel_txt/txt-config.h
Documentation/ABI/testing/sysfs-platform-intel-txt new file +309 -0
new file mode 100644
index 0000000..fa20a9f
@@ -0,0 +1,309 @@
+What:		/sys/devices/platform/intel_txt/config/
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The config/ directory exposes Intel TXT configuration
+		registers. These registers are a subset of chipset registers.
+		They are mapped into two regions of memory, representing the
+		public and private configuration spaces.
+
+		Registers in the private space can only be accessed after a
+		measured environment has been established and before the
+		TXT.CMD.CLOSE-PRIVATE command has been issued. The public space
+		registers are available before, during and after a measured
+		environment launch. All registers are available within both
+		spaces, though with different permissions.
+
+What:		/sys/devices/platform/intel_txt/config/STS_raw
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.STS is the general status register. This read-only register
+		is used by AC modules and the MLE to get the status of various
+		Intel TXT features.
+
+What:		/sys/devices/platform/intel_txt/config/STS_enter_done
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The chipset sets SENTER.DONE.STS status bit when it sees all
+		of the threads have done an TXT.CYC.SENTER-ACK.
+
+What:		/sys/devices/platform/intel_txt/config/STS_sexit_done
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	SEXIT.DONE.STS status bit is set when all of the bits in the
+		TXT.THREADS.JOIN register are clear. Thus, this bit will be
+		set immediately after reset.
+
+What:		/sys/devices/platform/intel_txt/config/STS_mem_config_lock
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	MEM-CONFIG-LOCK.STS status bit will be set to 1 when the memory
+		configuration has been locked. Cleared by
+		TXT.CMD.UNLOCK.MEMCONFIG or by a system reset.
+
+What:		/sys/devices/platform/intel_txt/config/STS_private_open
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	PRIVATE-OPEN.STS status bit will be set to 1 when
+		TXT.CMD.OPEN-PRIVATE is performed. Cleared by
+		TXT.CMD.CLOSE-PRIVATE or by a system reset.
+
+What:		/sys/devices/platform/intel_txt/config/STS_locality_1_open
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.LOCALITY1.OPEN.STS status bit is set when the
+		TXT.CMD.OPEN.LOCALITY1 command is seen by the chipset.
+		It is cleared on reset or when TXT.CMD.CLOSE.LOCALITY1 is seen.
+
+What:		/sys/devices/platform/intel_txt/config/STS_locality_2_open
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.LOCALITY2.OPEN.STS status bit is set when either the
+		TXT.CMD.OPEN.LOCALITY2 command or the TXT.CMD.OPEN.PRIVATE
+		is seen by the chipset. It is cleared on reset, when either
+		TXT.CMD.CLOSE.LOCALITY2 or TXT.CMD.CLOSE.PRIVATE is seen,
+		and by the GETSEC[SEXIT] instruction.
+
+What:		/sys/devices/platform/intel_txt/config/ESTS_raw
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.ESTS is the error status register which contains status
+		information associated with various error conditions. The
+		contents of this read-only register are preserved across
+		soft resets.
+
+What:		/sys/devices/platform/intel_txt/config/ESTS_intel_txt_reset
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT_RESET.STS bit is set to '1' to indicate that an event
+		occurred which may prevent the proper use of TXT (possibly
+		including a TXT reset).
+
+What:		/sys/devices/platform/intel_txt/config/ERRORCODE
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.ERRORCODE register holds the Intel TXT shutdown error code.
+		A soft reset does not clear the contents of this register;
+		a hard reset/power cycle will clear the contents. This was
+		formerly labeled the TXT.CRASH register.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_RESET
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	A write to TXT.CMD.RESET register causes a system reset.
+		This is performed by the processor as part of an Intel TXT
+		shutdown, after writing to the TXT.ERRORCODE register.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_CLOSE_PRIVATE
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	A write to TXT.CMD.CLOSE-PRIVATE register causes the Intel
+		TXT-capable chipset private configuration space to be locked.
+		Locality 2 will also be closed. Once locked, conventional
+		memory read/write operations can no longer be used to access
+		these registers. The private configuration space can only be
+		opened for the MLE by successfully executing GETSEC[SENTER].
+
+What:		/sys/devices/platform/intel_txt/config/VER_FSBIF
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.VER.FSBIF register identifies whether the chipset is
+		debug or release fused.
+
+What:		/sys/devices/platform/intel_txt/config/DIDVID_raw
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.DIDVID register contains the vendor, device, and revision
+		IDs for the memory controller or chipset.
+
+What:		/sys/devices/platform/intel_txt/config/DIDVID_vendor_id
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Vendor ID.
+
+What:		/sys/devices/platform/intel_txt/config/DIDVID_device_id
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Device ID.
+
+What:		/sys/devices/platform/intel_txt/config/DIDVID_revision_id
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Revision ID.
+
+What:		/sys/devices/platform/intel_txt/config/VER_QPIIF
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.VER.QPIIF register identifies whether the memory
+		controller or chipset is debug or release fused.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_UNLOCK_MEM_CONFIG
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	When TXT.CMD.UNLOCK-MEM-CONFIG command is invoked, the
+		chipset unlocks all memory configuration registers.
+
+What:		/sys/devices/platform/intel_txt/config/SINIT_BASE
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.SINIT.BASE register contains the physical base address
+		of the memory region set aside by the BIOS for loading an
+		SINIT AC module. If BIOS has provided an SINIT AC module,
+		it will be located at this address. System software that
+		provides an SINIT AC module must store it to this location.
+
+What:		/sys/devices/platform/intel_txt/config/SINIT_SIZE
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.SINIT.SIZE register contains the size (in bytes) of
+		the memory region set aside by the BIOS for loading an
+		SINIT AC module. This register is initialized by the BIOS.
+
+What:		/sys/devices/platform/intel_txt/config/MLE_JOIN
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Holds a physical address pointer to the base of the join
+		data structure used to initialize RLPs in response to
+		GETSEC[WAKEUP].
+
+What:		/sys/devices/platform/intel_txt/config/HEAP_BASE
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.HEAP.BASE register contains the physical base address
+		of the Intel TXT Heap memory region. The BIOS initializes
+		this register.
+
+What:		/sys/devices/platform/intel_txt/config/HEAP_SIZE
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.HEAP.SIZE register contains the size (in bytes) of the
+		Intel TXT Heap memory region. The BIOS initializes this
+		register.
+
+What:		/sys/devices/platform/intel_txt/config/DPR_raw
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.DPR register defines the DMA Protected Range of memory
+		in which the TXT heap and SINIT region are located.
+
+What:		/sys/devices/platform/intel_txt/config/DPR_lock
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Bits 19:0 are locked down in this register when this Lock
+		bit is set.
+
+What:		/sys/devices/platform/intel_txt/config/DPR_top
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Top address + 1 of DPR.
+
+What:		/sys/devices/platform/intel_txt/config/DPR_size
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	This is the size of memory, in MB, that will be protected from
+		DMA accesses. A value of 0x00 in this field means no additional
+		memory is protected.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_OPEN_LOCALITY1
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Writing to this TXT.CMD.OPEN.LOCALITY1 register "opens" the
+		TPM locality 1 address range, enabling decoding by the chipset
+		and thus access to the TPM.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_CLOSE_LOCALITY1
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Writing to this TXT.CMD.CLOSE.LOCALITY1 register "closes" the
+		TPM locality 1 address range, disabling decoding by the chipset
+		and thus access to the TPM.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_OPEN_LOCALITY2
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Writing to this TXT.CMD.OPEN.LOCALITY2 register "opens" the
+		TPM locality 2 address range, enabling decoding by the chipset
+		and thus access to the TPM.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_CLOSE_LOCALITY2
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Writing to this TXT.CMD.CLOSE.LOCALITY2 register "closes" the
+		TPM locality 2 address range, disabling decoding by the chipset
+		and thus access to the TPM.
+
+What:		/sys/devices/platform/intel_txt/config/PUBLIC_KEY
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	This read-only TXT.PUBLIC.KEY register contains the hash of
+		the public key used for the verification of AC Modules.
+		The size, hash algorithm, and value are specific to the memory
+		controller or chipset.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_SECRETS
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Writing to this TXT.CMD.SECRETS register indicates to the
+		chipset that there are secrets in memory. The chipset tracks
+		this fact with a sticky bit. If the platform reboots with this
+		sticky bit set the BIOS AC module (or BIOS on multiprocessor
+		TXT systems) will scrub memory. The chipset also uses this
+		bit to detect invalid sleep state transitions. If software
+		tries to transition to S3, S4, or S5 while secrets are in
+		memory then the chipset will reset the system.
+
+What:		/sys/devices/platform/intel_txt/config/CMD_NO_SECRETS
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	Writing to this TXT.CMD.NO-SECRETS register indicates there
+		are no secrets in memory.
+
+What:		/sys/devices/platform/intel_txt/config/E2STS_raw
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	This TXT.E2STS register is used to read the status associated
+		with various errors that might be detected.
+
+What:		/sys/devices/platform/intel_txt/config/E2STS_secrets
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	0 = Chipset acknowledges that no secrets are in memory.
+		1 = Chipset believes that secrets are in memory and will
+		provide reset protection.
drivers/platform/x86/intel_txt/Makefile +1 -1
index a130308..8d5258e 100644
@@ -2,4 +2,4 @@
 # Makefile for the intel TXT drivers.
 #
 obj-$(CONFIG_INTEL_TXT_DRIVER) += intel_txt.o
-intel_txt-y := txt-sysfs.o
+intel_txt-y := txt-sysfs.o txt-config.o
drivers/platform/x86/intel_txt/txt-config.c new file +1029 -0

1,029 lines not on this page · raw message

drivers/platform/x86/intel_txt/txt-config.h new file +138 -0

138 lines not on this page · raw message

drivers/platform/x86/intel_txt/txt-sysfs.c +12 -0
index 3ea7307..4837935 100644
@@ -36,11 +36,15 @@
 #include <linux/sysfs.h>
 #include <linux/tboot.h>
 
+#include "txt-config.h"
+
 #define DEV_NAME "intel_txt"
 static struct platform_device *txt_pdev;
 
 static int __init txt_sysfs_init(void)
 {
+	int retval;
+
 	if (!tboot_enabled())
 		return -ENODEV;
 
@@ -48,7 +52,15 @@ static int __init txt_sysfs_init(void)
 	if (IS_ERR(txt_pdev))
 		return PTR_ERR(txt_pdev);
 
+	retval = sysfs_create_config(&txt_pdev->dev.kobj);
+	if (retval)
+		goto err;
+
 	return 0;
+
+err:
+	platform_device_unregister(txt_pdev);
+	return retval;
 }
 
 static void __exit txt_sysfs_exit(void)
Signature · 1 line
1.7.9.5
#5 lore raw

Re: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

Quoted 4 lines · Qiaowei Ren

These interfaces are located
in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

Do you have any example userspace code using these features?

Signature · 1 line
Matthew Garrett | [email protected]
#6 lore raw

RE: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

Quoted 7 lines · Matthew Garrett
Quoted 4 lines · Qiaowei Ren

These interfaces are located
in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

Do you have any example userspace code using these features?

You mean test programs using these sysfs files? Currently I just did some simple demos like the following:

cat config/STS_private_open echo 1 > CMD_CLOSE_PRIVATE cat config/STS_private_open

cat config/STS_ locality_1_open echo 1 > CMD_CLOSE_LOCALITY1 cat config/ STS_ locality_1_open echo 1 > CMD_OPEN_LOCALITY1 cat config/ STS_ locality_1_open

Thanks,
Qiaowei

#7 lore raw

Re: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

In reply to Qiaowei Ren
Quoted 3 lines · Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config, and including totally 37 files, providing access to Intel TXT configuration registers.

This looks like very wrong interface... equivalent of /dev/mem.

Documentation/ABI/testing/sysfs-platform-intel-txt line 23

Quoted 7 lines
Documentation/ABI/testing/sysfs-platform-intel-txt new file +7 -0
+What:		/sys/devices/platform/intel_txt/config/STS_raw
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.STS is the general status register. This read-only register
+		is used by AC modules and the MLE to get the status of various
+		Intel TXT features.

This is not enough to allow people to understand what this does/should do, nor does it allow (for example) ARM people to implement something compatible.

Is there specific reason why "better" interface is impossible?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#8 lore raw

RE: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

Quoted 9 lines · Pavel Machek
Quoted 5 lines · Qiaowei Ren
(quoted diff) +3 -0
+What:		/sys/devices/platform/intel_txt/config/STS_raw +Date:		May 2013
+KernelVersion:	3.9 +Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.STS is the general status register. This read-only

register + is used by AC modules and the MLE to get the status of
various + Intel TXT features.

This is not enough to allow people to understand what this does/should do, nor does it allow (for example) ARM people to implement something compatible.

Currently TXT is only a technology for safer computing provided by Intel. I am absolutely not sure whether similar technology will be provided on ARM or other platform in future. But I guess I don't have to consider those future possible implementation on ARM or other platform. :)

Thanks,
Qiaowei

#9 lore raw

Re: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

Quoted 11 lines · Qiaowei
Quoted 9 lines · Pavel Machek
Quoted 5 lines · Qiaowei Ren
(quoted diff) +3 -0
+What:		/sys/devices/platform/intel_txt/config/STS_raw +Date:		May 2013
+KernelVersion:	3.9 +Contact:	"Qiaowei Ren" <[email protected]>
+Description:	TXT.STS is the general status register. This read-only

register + is used by AC modules and the MLE to get the status of
various + Intel TXT features.

This is not enough to allow people to understand what this does/should do, nor does it allow (for example) ARM people to implement something compatible.

Quoted 2 lines

Currently TXT is only a technology for safer computing provided by Intel. I am absolutely not sure whether similar technology will be provided on ARM or other platform in future. But I guess I don't have to consider those future possible implementation on ARM or other platform. :)

You still have to properly design the interface and properly document it, so people can understand and test it, and develop compatible implementations.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#10 lore raw

[discuss] Improve and merge a driver proposed in 2013: sysfs interfaces to access TXT config space

In reply to Pavel Machek

Hello!

As far as I see the patch wasn't merged. And I see that this is the only unsolved thread in the discussion:

Quoted 7 lines · Pavel Machek
Quoted 4 lines · Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

This looks like very wrong interface... equivalent of /dev/mem.

As an active user of these registers I hope it will be merged, so I would like to improve this patch (or rewrite it from scratch) to make that happen. Otherwise one have to do hackery around /dev/mem, which also creates problems with proper access control.

To be able to improve the patch, could somebody clarify why exactly this is a "very wrong interface"?

Quoted 15 lines
Quoted 9 lines
Documentation/ABI/testing/sysfs-platform-intel-txt new file +5 -0
+What:          /sys/devices/platform/intel_txt/config/STS_raw
+Date:          May 2013
+KernelVersion: 3.9
+Contact:       "Qiaowei Ren" <[email protected]>
+Description:   TXT.STS is the general status register. This read-

only register
+               is used by AC modules and the MLE to get the status of various
+               Intel TXT features.

This is not enough to allow people to understand what this does/should
do, nor does it allow (for example) ARM people to implement something compatible.

Quoted 1 line

Is there specific reason why "better" interface is impossible?

I would love to reuse Intel's public documentation [1] to provide a proper description (with bit layout of the value).

[1] https://cdrdv2.intel.com/v1/dl/getContent/315168

Quoted 2 lines

[...], nor does it allow (for example) ARM people to implement something compatible.

Do I understand correctly that a proper documentation of the registers solves the problem?

Quoted 1 line

Is there specific reason why "better" interface is impossible?

What are specific problems with the current interface?

Best regards,
Dmitrii Okunev.

#11 lore raw

Re: [discuss] Improve and merge a driver proposed in 2013: sysfs interfaces to access TXT config space

Quoted 47 lines · Dmitrii Okunev

Hello!

As far as I see the patch wasn't merged. And I see that this is the only unsolved thread in the discussion:

Quoted 7 lines · Pavel Machek
Quoted 4 lines · Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

This looks like very wrong interface... equivalent of /dev/mem.

As an active user of these registers I hope it will be merged, so I would like to improve this patch (or rewrite it from scratch) to make that happen. Otherwise one have to do hackery around /dev/mem, which also creates problems with proper access control.

To be able to improve the patch, could somebody clarify why exactly this is a "very wrong interface"?

Quoted 15 lines
Quoted 9 lines
Documentation/ABI/testing/sysfs-platform-intel-txt new file +5 -0
+What:          /sys/devices/platform/intel_txt/config/STS_raw
+Date:          May 2013
+KernelVersion: 3.9
+Contact:       "Qiaowei Ren" <[email protected]>
+Description:   TXT.STS is the general status register. This read-

only register
+               is used by AC modules and the MLE to get the status of various
+               Intel TXT features.

This is not enough to allow people to understand what this does/should
do, nor does it allow (for example) ARM people to implement something compatible.

Quoted 1 line

Is there specific reason why "better" interface is impossible?

I would love to reuse Intel's public documentation [1] to provide a proper description (with bit layout of the value).

[1] https://cdrdv2.intel.com/v1/dl/getContent/315168

Quoted 2 lines

[...], nor does it allow (for example) ARM people to implement something compatible.

Quoted 6 lines

Do I understand correctly that a proper documentation of the registers solves the problem?

Quoted 1 line

Is there specific reason why "better" interface is impossible?

What are specific problems with the current interface?

What do you mean by "current" here? You are referring to an email from 2013, 9 years ago.

If you want to propose the change again, correctly update the patch and submit it that way.

thanks,

greg k-h

#12 lore raw

Re: [discuss] Improve and merge a driver proposed in 2013: sysfs interfaces to access TXT config space

Quoted 53 lines · On Thu 2022-02-17 13:34:40, [email protected] wrote:
Quoted 52 lines · Dmitrii Okunev

Hello!

As far as I see the patch wasn't merged. And I see that this is the only unsolved thread in the discussion:

Quoted 7 lines · Pavel Machek
Quoted 4 lines · Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

This looks like very wrong interface... equivalent of /dev/mem.

As an active user of these registers I hope it will be merged, so I would like to improve this patch (or rewrite it from scratch) to make that happen. Otherwise one have to do hackery around /dev/mem, which also creates problems with proper access control.

To be able to improve the patch, could somebody clarify why exactly this is a "very wrong interface"?

Quoted 15 lines
Quoted 9 lines
Documentation/ABI/testing/sysfs-platform-intel-txt new file +5 -0
+What:          /sys/devices/platform/intel_txt/config/STS_raw
+Date:          May 2013
+KernelVersion: 3.9
+Contact:       "Qiaowei Ren" <[email protected]>
+Description:   TXT.STS is the general status register. This read-

only register
+               is used by AC modules and the MLE to get the status of various
+               Intel TXT features.

This is not enough to allow people to understand what this does/should
do, nor does it allow (for example) ARM people to implement something compatible.

Quoted 1 line

Is there specific reason why "better" interface is impossible?

I would love to reuse Intel's public documentation [1] to provide a proper description (with bit layout of the value).

[1] https://cdrdv2.intel.com/v1/dl/getContent/315168

Quoted 2 lines

[...], nor does it allow (for example) ARM people to implement something compatible.

Do I understand correctly that a proper documentation of the registers solves the problem?

Quoted 1 line

Is there specific reason why "better" interface is impossible?

Quoted 7 lines
Quoted 1 line

What are specific problems with the current interface?

What do you mean by "current" here? You are referring to an email from 2013, 9 years ago.

If you want to propose the change again, correctly update the patch and submit it that way.

I don't believe taking hardware registers and exposing them 1-to-1 in sysfs is the way to go.

We would like same /sys interface on different hardware, and simply exposing Intel's registers in /sys will not do the job.

Best regards,
Pavel

Signature · 1 line
http://www.livejournal.com/~pavelmachek
#13 lore raw

Re: [discuss] Improve and merge a driver proposed in 2013: sysfs interfaces to access TXT config space

Quoted 62 lines · Pavel Machek
Quoted 61 lines · On Thu 2022-02-17 13:34:40, [email protected] wrote:
Quoted 50 lines · Dmitrii Okunev

Hello!

As far as I see the patch wasn't merged. And I see that this is the only unsolved thread in the discussion:

Quoted 7 lines · Pavel Machek
Quoted 4 lines · Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

This looks like very wrong interface... equivalent of /dev/mem.

As an active user of these registers I hope it will be merged, so I would like to improve this patch (or rewrite it from scratch) to make that happen. Otherwise one have to do hackery around /dev/mem, which also creates problems with proper access control.

To be able to improve the patch, could somebody clarify why exactly this is a "very wrong interface"?

Quoted 17 lines
Quoted 6 lines

+What:          /sys/devices/platform/intel_txt/config/STS_ra w

Documentation/ABI/testing/sysfs-platform-intel-txt new file +4 -0
+Date:          May 2013
+KernelVersion: 3.9
+Contact:       "Qiaowei Ren" <[email protected]>
+Description:   TXT.STS is the general status register. This
Quoted 6 lines

read-
only register
+               is used by AC modules and the MLE to get the status
of various
+               Intel TXT features.

This is not enough to allow people to understand what this does/should do, nor does it allow (for example) ARM people to implement something compatible.

Quoted 1 line

Is there specific reason why "better" interface is impossible?

I would love to reuse Intel's public documentation [1] to provide a proper description (with bit layout of the value).

[1] https://cdrdv2.intel.com/v1/dl/getContent/315168

Quoted 2 lines

[...], nor does it allow (for example) ARM people to implement something compatible.

Quoted 6 lines

Do I understand correctly that a proper documentation of the registers solves the problem?

Quoted 1 line

Is there specific reason why "better" interface is impossible?

What are specific problems with the current interface?

What do you mean by "current" here?  You are referring to an email from 2013, 9 years ago.

Quoted 8 lines
Quoted 2 lines

If you want to propose the change again, correctly update the patch and submit it that way.

I don't believe taking hardware registers and exposing them 1-to-1 in sysfs is the way to go.

We would like same /sys interface on different hardware, and simply exposing Intel's registers in /sys will not do the job.

So, for our particular use case what we want to be able to see is the status of the TXT device, so when attestation fails it's possible to diagnose where that might have happened. At a minimum details from the status register are folded into the first measurement, and the error register can provide valuable insight as to what the TXT device thinks failed.

At present these details are retrieved from /dev/mem, but this is less than ideal and prevents the use of, say, kernel lockdown. As a result we'd like to export the appropriate details via sysfs. These are likely to be extremely security block implementation specific, so I'm not clear that a generic agnostic interface is appropriate to retrieve these details.

Do you have the same objection to a read only set of information (rather than the full control offered by the initial submission)?

J.

#14 lore raw

Re: [discuss] Improve and merge a driver proposed in 2013: sysfs interfaces to access TXT config space

Quoted 86 lines · Jonathan McDowell
Quoted 62 lines · Pavel Machek
Quoted 61 lines · On Thu 2022-02-17 13:34:40, [email protected] wrote:
Quoted 50 lines · Dmitrii Okunev

Hello!

As far as I see the patch wasn't merged. And I see that this is the only unsolved thread in the discussion:

Quoted 7 lines · Pavel Machek
Quoted 4 lines · Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/config,
and including totally 37 files, providing access to Intel TXT configuration registers.

This looks like very wrong interface... equivalent of /dev/mem.

As an active user of these registers I hope it will be merged, so I would like to improve this patch (or rewrite it from scratch) to make that happen. Otherwise one have to do hackery around /dev/mem, which also creates problems with proper access control.

To be able to improve the patch, could somebody clarify why exactly this is a "very wrong interface"?

Quoted 17 lines
Quoted 6 lines

+What:          /sys/devices/platform/intel_txt/config/STS_ra w

Documentation/ABI/testing/sysfs-platform-intel-txt new file +4 -0
+Date:          May 2013
+KernelVersion: 3.9
+Contact:       "Qiaowei Ren" <[email protected]>
+Description:   TXT.STS is the general status register. This
Quoted 6 lines

read-
only register
+               is used by AC modules and the MLE to get the status
of various
+               Intel TXT features.

This is not enough to allow people to understand what this does/should do, nor does it allow (for example) ARM people to implement something compatible.

Quoted 1 line

Is there specific reason why "better" interface is impossible?

I would love to reuse Intel's public documentation [1] to provide a proper description (with bit layout of the value).

[1] https://cdrdv2.intel.com/v1/dl/getContent/315168

Quoted 2 lines

[...], nor does it allow (for example) ARM people to implement something compatible.

Quoted 6 lines

Do I understand correctly that a proper documentation of the registers solves the problem?

Quoted 1 line

Is there specific reason why "better" interface is impossible?

What are specific problems with the current interface?

What do you mean by "current" here?  You are referring to an email from 2013, 9 years ago.

Quoted 8 lines
Quoted 2 lines

If you want to propose the change again, correctly update the patch and submit it that way.

I don't believe taking hardware registers and exposing them 1-to-1 in sysfs is the way to go.

We would like same /sys interface on different hardware, and simply exposing Intel's registers in /sys will not do the job.

So, for our particular use case what we want to be able to see is the status of the TXT device, so when attestation fails it's possible to diagnose where that might have happened. At a minimum details from the status register are folded into the first measurement, and the error register can provide valuable insight as to what the TXT device thinks failed.

At present these details are retrieved from /dev/mem, but this is less than ideal and prevents the use of, say, kernel lockdown. As a result we'd like to export the appropriate details via sysfs. These are likely to be extremely security block implementation specific, so I'm not clear that a generic agnostic interface is appropriate to retrieve these details.

Quoted 2 lines

Do you have the same objection to a read only set of information (rather than the full control offered by the initial submission)?

Might be a job for debugfs?
Pavel

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#15 lore raw

RFC PATCH 1/1 platform/x86: Add sysfs interface for Intel TXT status

(This is an RFC to see if the approach is generally acceptable; unlike the previous driver this exposes the information purely as read-only status information, so userspace can make an informed decision about the system state without having to poke about in /dev/mem. There are still a few extra registers I'm trying to dig up information for before a proper submission.)

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

Tools such as txt-stat from tboot
<https://sourceforge.net/projects/tboot/> can make use of this driver to display state rather than relying on access to /dev/mem.

See Documentation/x86/intel_txt.rst for more information about Intel TXT.

---
 arch/x86/include/asm/txt.h             |  34 +++++
 drivers/platform/x86/intel/Kconfig     |  14 ++
 drivers/platform/x86/intel/Makefile    |   2 +
 drivers/platform/x86/intel/txt_sysfs.c | 185 +++++++++++++++++++++++++
 4 files changed, 235 insertions(+)
 create mode 100644 arch/x86/include/asm/txt.h
 create mode 100644 drivers/platform/x86/intel/txt_sysfs.c
arch/x86/include/asm/txt.h new file +34 -0
new file mode 100644
index 000000000000..9c90d894c1af
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * txt.h: Intel TXT (Trusted Execution Technology) related definitions
+ */
+
+#ifndef __TXT_H
+#define __TXT_H
+
+#define TXT_PUB_CONFIG_REGS_BASE	0xfed30000
+#define TXT_PRIV_CONFIG_REGS_BASE	0xfed20000
+
+#define TXT_NR_CONFIG_PAGES	((TXT_PUB_CONFIG_REGS_BASE - \
+				  TXT_PRIV_CONFIG_REGS_BASE) >> PAGE_SHIFT)
+
+/*
+ * TXT configuration registers (offsets from TXT_{PUB,PRIV}_CONFIG_REGS_BASE)
+ */
+
+#define TXT_CR_STS			0x0000
+#define TXT_CR_ESTS			0x0008
+#define TXT_CR_ERRORCODE		0x0030
+#define TXT_CR_ACMSTS			0x00A0
+#define TXT_CR_VER_FSBIF		0x0100
+#define TXT_CR_DIDVID			0x0110
+#define TXT_CR_VER_QPIIF		0x0200
+#define TXT_CR_SINIT_BASE		0x0270
+#define TXT_CR_SINIT_SIZE		0x0278
+#define TXT_CR_HEAP_BASE		0x0300
+#define TXT_CR_HEAP_SIZE		0x0308
+#define TXT_CR_DPR			0x0330
+#define TXT_CR_PUBLIC_KEY		0x0400
+#define TXT_CR_E2STS			0x08f0
+
+#endif /* __TXT_H */
drivers/platform/x86/intel/Kconfig +14 -0
index 8e65086bb6c8..ae8d032b4499 100644
@@ -159,6 +159,20 @@ config INTEL_TURBO_MAX_3
 	  This driver is only required when the system is not using Hardware
 	  P-States (HWP). In HWP mode, priority can be read from ACPI tables.
 
+config INTEL_TXT_SYSFS
+	tristate "Intel TXT sysfs driver"
+	depends on HAVE_INTEL_TXT && SECURITYFS
+	help
+	  This driver exports the TXT (Trusted Execution Technology) public
+	  configuration space to user space via sysfs.
+
+	  These registers provide details about the status of the platform's
+	  measured launch and execution environment, allowing userspace to
+	  make trust based decisions. See tboot
+	  <https://sourceforge.net/projects/tboot/> and TrenchBoot
+	  <https://trenchboot.org/> for projects which implement the
+	  appropriate boot flow to fully enable these features.
+
 config INTEL_UNCORE_FREQ_CONTROL
 	tristate "Intel Uncore frequency control driver"
 	depends on X86_64
drivers/platform/x86/intel/Makefile +2 -0
index 35f2066578b2..ac73ac61090a 100644
@@ -26,6 +26,8 @@ intel_int0002_vgpio-y			:= int0002_vgpio.o
 obj-$(CONFIG_INTEL_INT0002_VGPIO)	+= intel_int0002_vgpio.o
 intel_oaktrail-y			:= oaktrail.o
 obj-$(CONFIG_INTEL_OAKTRAIL)		+= intel_oaktrail.o
+intel_txt_sysfs-y			:= txt_sysfs.o
+obj-$(CONFIG_INTEL_TXT_SYSFS)		+= intel_txt_sysfs.o
 intel_vsec-y				:= vsec.o
 obj-$(CONFIG_INTEL_VSEC)		+= intel_vsec.o
 
drivers/platform/x86/intel/txt_sysfs.c new file +185 -0

185 lines not on this page · raw message

Signature · 1 line
2.34.1
#16 lore raw

Re: [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status

Quoted 19 lines · Jonathan McDowell

(This is an RFC to see if the approach is generally acceptable; unlike the previous driver this exposes the information purely as read-only status information, so userspace can make an informed decision about the system state without having to poke about in /dev/mem. There are still a few extra registers I'm trying to dig up information for before a proper submission.)

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

Tools such as txt-stat from tboot
<https://sourceforge.net/projects/tboot/> can make use of this driver to display state rather than relying on access to /dev/mem.

See Documentation/x86/intel_txt.rst for more information about Intel TXT.

Quoted 6 lines
---
 arch/x86/include/asm/txt.h             |  34 +++++
 drivers/platform/x86/intel/Kconfig     |  14 ++
 drivers/platform/x86/intel/Makefile    |   2 +
 drivers/platform/x86/intel/txt_sysfs.c | 185 +++++++++++++++++++++++++

No Documentation/ABI/ entry for your new sysfs entry? How can we evaluate if this is a good api then?

Wait, I don't see any sysfs code in here, are you sure you sent a viable patch?

confused,

greg k-h

#17 lore raw

Re: [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status

Quoted 27 lines · Greg KH
Quoted 19 lines · Jonathan McDowell

(This is an RFC to see if the approach is generally acceptable; unlike the previous driver this exposes the information purely as read-only status information, so userspace can make an informed decision about the system state without having to poke about in /dev/mem. There are still a few extra registers I'm trying to dig up information for before a proper submission.)

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

Tools such as txt-stat from tboot
<https://sourceforge.net/projects/tboot/ > can make use of this driver to display state rather than relying on access to /dev/mem.

See Documentation/x86/intel_txt.rst for more information about Intel TXT.

Quoted 6 lines
---
 arch/x86/include/asm/txt.h             |  34 +++++
 drivers/platform/x86/intel/Kconfig     |  14 ++
 drivers/platform/x86/intel/Makefile    |   2 +
 drivers/platform/x86/intel/txt_sysfs.c | 185 +++++++++++++++++++++++++
Quoted 2 lines

No Documentation/ABI/ entry for your new sysfs entry? How can we evaluate if this is a good api then?

As a read-only export of configuration registers is a full set of info in Documentation/ABI/ required? I didn't get a feel for how required that was from the existing files there.

Quoted 2 lines

Wait, I don't see any sysfs code in here, are you sure you sent a viable patch?

The export to sysfs is via securityfs, as that seemed to be the appropriate route (it fits into a similar area as /sys/kernel/security/integrity/ima/ or /sys/kernel/security/tpm0/, providing userspace with some visibility of what the kernel thinks the state is).

J.

#18 lore raw

Re: [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status

Quoted 28 lines · Jonathan McDowell
Quoted 27 lines · Greg KH
Quoted 25 lines · Jonathan McDowell

(This is an RFC to see if the approach is generally acceptable; unlike the previous driver this exposes the information purely as read-only status information, so userspace can make an informed decision about the system state without having to poke about in /dev/mem. There are still a few extra registers I'm trying to dig up information for before a proper submission.)

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

Tools such as txt-stat from tboot
<https://sourceforge.net/projects/tboot/ > can make use of this driver to display state rather than relying on access to /dev/mem.

See Documentation/x86/intel_txt.rst for more information about Intel TXT.

---
 arch/x86/include/asm/txt.h             |  34 +++++
 drivers/platform/x86/intel/Kconfig     |  14 ++
 drivers/platform/x86/intel/Makefile    |   2 +
 drivers/platform/x86/intel/txt_sysfs.c | 185 +++++++++++++++++++++++++
Quoted 6 lines
Quoted 2 lines

No Documentation/ABI/ entry for your new sysfs entry? How can we evaluate if this is a good api then?

As a read-only export of configuration registers is a full set of info in Documentation/ABI/ required? I didn't get a feel for how required that was from the existing files there.

For all sysfs entries, yes, it is required. Run the scripts/get_abi.pl tool as proof :)

Quoted 8 lines
Quoted 2 lines

Wait, I don't see any sysfs code in here, are you sure you sent a viable patch?

The export to sysfs is via securityfs, as that seemed to be the appropriate route (it fits into a similar area as /sys/kernel/security/integrity/ima/ or /sys/kernel/security/tpm0/, providing userspace with some visibility of what the kernel thinks the state is).

Then this is securityfs, NOT sysfs. securityfs just happens to be mounted at that location. You could mount it anywhere else as well. Please fix up the terminology here, it is very confusing and has nothing to do with sysfs at all.

thanks,

greg k-h

#19 lore raw

Re: [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status

In reply to Jonathan McDowell
Quoted 4 lines · Jonathan McDowell

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

So there's the obvious issue that in the event that the system has been compromised this information is no longer trustworthy - is this expected to just be informative for diagnostic purposes rather than forming any part of security policy?

drivers/platform/x86/intel/Kconfig config INTEL_TURBO_MAX_3 · line 171

Quoted 3 lines
drivers/platform/x86/intel/Kconfig +3 -0
+	  These registers provide details about the status of the platform's
+	  measured launch and execution environment, allowing userspace to
+	  make trust based decisions. See tboot

Mm. This makes it sound like it's expected that userspace make decisions based on this, which sounds like a bad plan?

drivers/platform/x86/intel/txt_sysfs.c line 74

Quoted 4 lines
drivers/platform/x86/intel/txt_sysfs.c new file +4 -0
+/* Shows if TXT has been enabled */
+static int txt_enabled_show(struct seq_file *m, void *v)
+{
+	/* If the BIOS has enabled TXT then the heap base will be set */

Sorry it's not that I want to say "Wait are you trusting that the BIOS will do the right thing here" but wait are you trusting that the BIOS will do the right thing here? Does setting the heap base guarantee that TXT was enabled (and, conversely, are there any scenarios where TXT was enabled and the BIOS could have cleared the heap base after a measurement event?)

drivers/platform/x86/intel/txt_sysfs.c line 87

Quoted 8 lines
drivers/platform/x86/intel/txt_sysfs.c new file +8 -0
+/* Shows the 256 bit hash of the public key */
+static int txt_key_show(struct seq_file *m, void *v)
+{
+	seq_printf(m, "%016llx%016llx%016llx%016llx\n",
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY)),
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY + 8)),
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY + 16)),
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY + 24)));

What's the expected consumer of this, and what are they expected to do with it?

#20 lore raw

Re: [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status

Quoted 11 lines · Matthew Garrett
Quoted 4 lines · Jonathan McDowell

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

So there's the obvious issue that in the event that the system has been compromised this information is no longer trustworthy - is this expected to just be informative for diagnostic purposes rather than forming any part of security policy?

This is purely for diagnostic purposes when the system ends up in an unexpected state, to aid automated remediation. In particular dealing with unexpected PCR0 values that have failed attestation; the state of TXT helps with trying to diagnose how we got to the unexpected value.

Quoted 6 lines

drivers/platform/x86/intel/Kconfig config INTEL_TURBO_MAX_3 · line 171

Quoted 3 lines
drivers/platform/x86/intel/Kconfig +3 -0
+	  These registers provide details about the status of the platform's
+	  measured launch and execution environment, allowing userspace to
+	  make trust based decisions. See tboot

Mm. This makes it sound like it's expected that userspace make decisions based on this, which sounds like a bad plan?

I should clean up the description to be clearer for v2.

Quoted 11 lines

drivers/platform/x86/intel/txt_sysfs.c line 74

Quoted 4 lines
drivers/platform/x86/intel/txt_sysfs.c new file +4 -0
+/* Shows if TXT has been enabled */
+static int txt_enabled_show(struct seq_file *m, void *v)
+{
+	/* If the BIOS has enabled TXT then the heap base will be set */

Sorry it's not that I want to say "Wait are you trusting that the BIOS will do the right thing here" but wait are you trusting that the BIOS will do the right thing here? Does setting the heap base guarantee that TXT was enabled (and, conversely, are there any scenarios where TXT was enabled and the BIOS could have cleared the heap base after a measurement event?)

If the BIOS hasn't enabled the heap then it won't have been able to pass any data to the system for a managed launch environment, so I think it's fairly safe to assume if it's never been set we're not in a situation where anything has tried to initialise TXT. If we're in a situation where we've tried to initialise it and then something has gone wrong and the BIOS has managed to clear it that's probably a firmware bug and I'd expect to see some status register oddities too. We're not trusting the BIOS here, we're just using the fact the heap is actually setup to indicate that we've tried to do TXT in terms of diagnosis. (And, in fact, one of the failure modes we've seen is where TXT is supposed to be configured in the BIOS but it doesn't actually get setup at all and we correctly see a 0 entry here.)

Quoted 11 lines

drivers/platform/x86/intel/txt_sysfs.c line 87

Quoted 8 lines
drivers/platform/x86/intel/txt_sysfs.c new file +8 -0
+/* Shows the 256 bit hash of the public key */
+static int txt_key_show(struct seq_file *m, void *v)
+{
+	seq_printf(m, "%016llx%016llx%016llx%016llx\n",
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY)),
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY + 8)),
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY + 16)),
+		cpu_to_be64(*(u64 *)(txt_pub_regs + TXT_CR_PUBLIC_KEY + 24)));

What's the expected consumer of this, and what are they expected to do with it?

I added it purely because txt-stat is already showing it, and it differs between platforms. I note 315168-017 says newer platforms use CPU MSRs 0x20::0x23 instead. So it's informational at this point for older platforms.

J.

#21 lore raw

RFC PATCH v2 1/1 platform/x86: Add securityfs interface for TXT status

In reply to Jonathan McDowell

This module provides read-only access to the Intel TXT (Trusted Execution Technology) status registers, allowing userspace to determine the status of measured boot and whether the dynamic root of trust for measurement (DRTM) has been fully enabled.

Tools such as txt-stat from tboot
<https://sourceforge.net/projects/tboot/> can make use of this driver to display state and attempt to remediate issues rather than relying on access to /dev/mem.

See Documentation/x86/intel_txt.rst for more information about Intel TXT.

---
v2:
- Refer to securityfs instead of sysfs
- Clarify this is read-only access for remediation
- Add documentation for the securityfs files presented

---
 .../ABI/testing/securityfs-intel-txt          | 226 ++++++++++++++++++
 arch/x86/include/asm/txt.h                    |  42 ++++
 drivers/platform/x86/intel/Kconfig            |  16 ++
 drivers/platform/x86/intel/Makefile           |   2 +
 drivers/platform/x86/intel/txt_securityfs.c   | 189 +++++++++++++++
 5 files changed, 475 insertions(+)
 create mode 100644 Documentation/ABI/testing/securityfs-intel-txt
 create mode 100644 arch/x86/include/asm/txt.h
 create mode 100644 drivers/platform/x86/intel/txt_securityfs.c
Documentation/ABI/testing/securityfs-intel-txt new file +226 -0
new file mode 100644
index 000000000000..2e0df93a168c
@@ -0,0 +1,226 @@
+What:		/sys/security/security/intel-txt/*
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Various files relating to Intel's TXT (Trusted Execution
+		Technology). These provide read-only access to the state of
+		measured boot and whether the dynamic root of trust (DRTM) has
+		been fully enabled.
+
+		These details are intended for use in allowing userspace to
+		remediate issues with the TXT feature. They should not be relied
+		upon for confirming the system is in a secure state.
+
+		Many of the files listed below provide the raw hex values from
+		the device registers. Where possible the bit fields are
+		documented, but bits defined as reserved have been observed to
+		be clear on some platforms and set on others. As the primary
+		purpose of this support is to allow full visibility of state for
+		the purpose of remediation it is more useful to have the raw
+		values than a partially decoded state.
+
+What:		/sys/security/security/intel-txt/enabled
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Indicates if it looks like the BIOS has successfully enabled the
+		TXT functionality. Checks that a heap has correctly been
+		configured for the device. A non-initialised heap is not a
+		guarantee that an errant BIOS has not tried to enable
+		functionality and then clear status, nor does the presence of a
+		configured heap mean the device is fully initialised.
+
+What:		/sys/security/security/intel-txt/didvid
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Contains the vendor, device and revision IDs for the memory
+		controller or chipset.
+
+		b[15:0]
+			Vendor ID: 8086 for Intel
+		b[31:16]
+			Device ID: Specific to the chipset/platform
+		b[47:32]
+			Revision ID: Specific to the chipset/platform
+		b[63:48]
+			Extended ID: Specific to the chipset/platform
+
+What:		/sys/security/security/intel-txt/dpr
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Defines the details of the DMA Protected Range in which the TXT
+		heap and SINIT regions are located.
+
+		Platforms utilising SGX implement this as part of uncore and so
+		this register has no underlying hardware functionality on those
+		platforms.
+
+		b[0]
+			Bits 19:0 are locked down in this register when this bit
+			is set.
+		b[3:1]
+			Reserved.
+		b[11:4]
+			The size of memory, in MB, that will be protected from
+			DMA accesses. 0 indicates no memory is protected.
+		b[19:12]
+			Reserved.
+		b[31:20]
+			Top address + 1 of the DMA protected range.
+
+What:		/sys/security/security/intel-txt/e2sts
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Extended error status details. Contents are preserved across
+		soft resets.
+
+		b[0]
+			Reserved.
+		b[1]
+			SECRET.STS.
+			0 = Chipset acknowledged that no secrets are in memory.
+			1 = Chipset believes that secrets are in memory and will
+			    provide reset protection.
+		b[63:2]
+			Reserved.
+
+What:		/sys/security/security/intel-txt/errorcode
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Shutdown error code details. Preserved over a soft reset,
+		cleared by a hard reset or power cycle.
+
+		b[3:0]
+			Module details.
+			0 = BIOS ACM
+			1 = SINIT
+		b[9:4]
+			Class code
+		b[14:10]
+			Major error code
+		b[15]
+			Software source
+			0 = Authenticated Code Module (ACM)
+			1 = Measure Launch Environment (MLE)
+		b[27:16]
+			Minor error code
+		b[29:28]
+			Reserved.
+		b[30]
+			0 = Error reported by processor
+			1 = Error reported by software
+		b[31]
+			Valid bit
+			0 = Register contents invalid, should be ignored
+			1 = Error details valid
+		b[63:32]
+			Reserved.
+
+What:		/sys/security/security/intel-txt/ests
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Details associated with various error conditions. Contents are
+		preserved across soft resets.
+
+		b[0]
+			TXT_RESET.STS. Set to 1 to indicate an error occurred
+			which may prevent the proper use of TXT. While this bit
+			is set the Safer Mode Extension (SMX) instructions
+			GETSEC[ENTERACCS] and GETSEC[SENTER] will fail.
+
+			This bit is only cleared on a power cycle.
+		b[63:1]
+			Reserved.
+
+What:		/sys/security/security/intel-txt/spad
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		Details from the startup Authenticated Code Module (ACM)
+		conveying the results of its operation. Generally of interest to
+		the BIOS rather than the OS in normal operation it can provide
+		details of where TXT initialisation failed.
+
+		b[29:0]
+			Reserved.
+		b[30]
+			Indicates TXT startup success; successful preparation
+			for the BIOS, SINIT and MLE components.
+		b[46:31]
+			General startup ACM to BIOS boot status communication.
+		b[47]
+			Indicates memory contents were cleared via a power down.
+		b[52:48]
+			Startup ACM to BIOS communication in MP platforms.
+		b[53]
+			Startup ACM indication of run-time enabled status of
+			TXT. Generally driven by FIT type 0xA record.
+		b[58:54]
+			Startup ACM to BIOS communication in MP platforms.
+		b[59]
+			Indicates the BIOS is trusted.
+		b[60]
+			Indicates that TXT has been disabled by a runtime FIT
+			type 0xA record.
+		b[61]
+			Startup ACM to BIOS communication in MP platforms.
+		b[62]
+			Indicates an ACM authentication error from the CPU.
+		b[63]
+			Indicates S-ACM successfully enforced its logic for all
+			provisioned technologies.
+
+What:		/sys/security/security/intel-txt/sts
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		General status details for various TXT features.
+
+		b[0]
+			SENTER.DONE.STS. Set by the chipset when it sees all
+			threads have done a TXT.CYC.SENTER-ACK. When any of the
+			threads does a TXT.CYC.SYSEXIT-ACK then TXT.THREADS.JOIN
+			and TXT.THREAD.EXISTS registers will not be equal and
+			the chipset will clear this bit.
+		b[1]
+			SEXIT.DONE.STS. Set when all bits in the
+			TXT.THREADS.JOIN register are clear. This is thus set
+			after reset (since the bits are all 0) and once all
+			threads have done a TXT.CYC.SYSEXIT-ACK.
+		b[5:2]
+			Reserved.
+		b[6]
+			MEM-CONFIG-LOCK.STS. Set to 1 when the memory
+			configuration is locked. Cleared by
+			TXT.CMD.UNLOCK.MEMCONFIG or a system reset.
+		b[7]
+			PRIVATE-OPEN.STS. Set to 1 when TXT.CMD.OPEN-PRIVATE is
+			performed. Cleared by TXT.CMD.CLOSE-PRIVATE or by a
+			system reset.
+		b[14:8]
+			Reserved.
+		b[15]
+			TXT.LOCALITY1.OPEN.STS. Set when TXT.CMD.OPEN.LOCALITY1
+			is seen by the chipset. Cleared on reset or when
+			TXT.CMD.CLOSE.LOCALITY1 is seen.
+		b[16]
+			TXT.LOCALITY2.OPEN.STS. Set when TXT.CMD.OPEN.LOCALITY2
+			or TXT.CMD.OPEN.PRIVATE is seen by the chipset. Cleared
+			on reset, or when either TXT.CMD.CLOSE.LOCALITY2 or
+			TXT.CMD.CLOSE.PRIVATE is seen, and by the GETSEC[SEXIT]
+			instruction.
+		b[63:17]
+			Reserved.
+
+What:		/sys/security/security/intel-txt/publickey
+Date:		April 2022
+Contact:	Jonathan McDowell <[email protected]>
+Description:
+		256 bit hash of the public key used for the verification of the
+		Authenticated Code Modules. Details are specific to the memory
+		controller or chipset.
arch/x86/include/asm/txt.h new file +42 -0

42 lines not on this page · raw message

drivers/platform/x86/intel/Kconfig +16 -0
index 8e65086bb6c8..40b55e7fbfce 100644
@@ -159,6 +159,22 @@ config INTEL_TURBO_MAX_3
 	  This driver is only required when the system is not using Hardware
 	  P-States (HWP). In HWP mode, priority can be read from ACPI tables.
 
+config INTEL_TXT_SECURITYFS
+	tristate "Intel TXT securityfs driver"
+	depends on HAVE_INTEL_TXT && SECURITYFS
+	help
+	  This driver exports the TXT (Trusted Execution Technology) public
+	  configuration space to user space via securityfs.
+
+	  These registers provide details about the status of the platform's
+	  measured launch and execution environment, allowing userspace to
+	  perform diagnosis and potential remediation when attestation or
+	  other trust related operations are failing.
+
+	  For kernel implementations which actually provide a trusted
+	  environment see tboot <https://sourceforge.net/projects/tboot/>
+	  and TrenchBoot <https://trenchboot.org/>.
+
 config INTEL_UNCORE_FREQ_CONTROL
 	tristate "Intel Uncore frequency control driver"
 	depends on X86_64
drivers/platform/x86/intel/Makefile +2 -0
index 35f2066578b2..5d4531d4ada5 100644
@@ -26,6 +26,8 @@ intel_int0002_vgpio-y			:= int0002_vgpio.o
 obj-$(CONFIG_INTEL_INT0002_VGPIO)	+= intel_int0002_vgpio.o
 intel_oaktrail-y			:= oaktrail.o
 obj-$(CONFIG_INTEL_OAKTRAIL)		+= intel_oaktrail.o
+intel_txt_securityfs-y			:= txt_securityfs.o
+obj-$(CONFIG_INTEL_TXT_SECURITYFS)	+= intel_txt_securityfs.o
 intel_vsec-y				:= vsec.o
 obj-$(CONFIG_INTEL_VSEC)		+= intel_vsec.o
 
drivers/platform/x86/intel/txt_securityfs.c new file +189 -0

189 lines not on this page · raw message

Signature · 1 line
2.34.1
#22 lore raw

PATCH v2 3/3 driver: provide sysfs interfaces to access SMX parameter

In reply to Qiaowei Ren

These interfaces are located in /sys/devices/platform/intel_txt/parameter/, showing specific parameter information for SMX features supported by the processor.

Safer Mode Extensions (SMX) provide a processor's programming interface in an Intel TXT platform for system software to establish a measured environment within the platform to support trust decisions by end users.

---
 Documentation/ABI/testing/sysfs-platform-intel-txt |   73 ++++++
 drivers/platform/x86/intel_txt/Makefile            |    2 +-
 drivers/platform/x86/intel_txt/txt-parameter.c     |  254 ++++++++++++++++++++
 drivers/platform/x86/intel_txt/txt-parameter.h     |   39 +++
 drivers/platform/x86/intel_txt/txt-sysfs.c         |    5 +
 5 files changed, 372 insertions(+), 1 deletion(-)
 create mode 100644 drivers/platform/x86/intel_txt/txt-parameter.c
 create mode 100644 drivers/platform/x86/intel_txt/txt-parameter.h
Documentation/ABI/testing/sysfs-platform-intel-txt +73 -0
index fa20a9f..b445f5d 100644
@@ -307,3 +307,76 @@ Contact:	"Qiaowei Ren" <[email protected]>
 Description:	0 = Chipset acknowledges that no secrets are in memory.
 		1 = Chipset believes that secrets are in memory and will
 		provide reset protection.
+
+What:		/sys/devices/platform/intel_txt/parameter/
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The parameter/ directory exposes specific parameter
+		information for SMX features supported by the processor.
+
+		Safer Mode Extensions (SMX) provide a processor's
+		programming interface in an Intel TXT platform for
+		system software to establish a measured environment
+		within the platform to support trust decisions by
+		end users.
+
+What:		/sys/devices/platform/intel_txt/parameter/acm_max_size
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "acm_max_size" property will show max size of
+		authenticated code execution area.
+
+What:		/sys/devices/platform/intel_txt/parameter/acm_mem_types
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "acm_max_types" property will show supportable memory
+		types for memory mapped outside of the authenticated code
+		execution area.
+
+What:		/sys/devices/platform/intel_txt/parameter/senter_controls
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "senter_controls" property will show selective SENTER
+		functionality control.
+
+What:		/sys/devices/platform/intel_txt/parameter/preserve_mce
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "preserve_mce" property produces a '1' if machine
+		check status registers can be preserved through ENTERACCS
+		and SENTER.
+
+What:		/sys/devices/platform/intel_txt/parameter/proc_based_scrtm
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "proc_based_scrtm" property produces a '1' if this
+		processor implements a processorrooted S-CRTM capability
+		and '0' if not (S-CRTM is rooted in BIOS).
+
+What:		/sys/devices/platform/intel_txt/parameter/n_versions
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "n_versions" property will show AC module version
+		numbers supported.
+
+What:		/sys/devices/platform/intel_txt/parameter/acm_version
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "acm_version" property will output supported AC
+		module version, including version comparison mask and
+		version index.
+
+What:		/sys/devices/platform/intel_txt/parameter/acm_version_index
+Date:		May 2013
+KernelVersion:	3.9
+Contact:	"Qiaowei Ren" <[email protected]>
+Description:	The "acm_version_index" property allows you to set the
+		version index for output.
drivers/platform/x86/intel_txt/Makefile +1 -1
index 8d5258e..8370582 100644
@@ -2,4 +2,4 @@
 # Makefile for the intel TXT drivers.
 #
 obj-$(CONFIG_INTEL_TXT_DRIVER) += intel_txt.o
-intel_txt-y := txt-sysfs.o txt-config.o
+intel_txt-y := txt-sysfs.o txt-config.o txt-parameter.o
drivers/platform/x86/intel_txt/txt-parameter.c new file +254 -0

254 lines not on this page · raw message

drivers/platform/x86/intel_txt/txt-parameter.h new file +39 -0
new file mode 100644
index 0000000..55b232b
@@ -0,0 +1,39 @@
+#ifndef __PARAMETER_H__
+#define __PARAMETER_H__
+
+#define CR4_SMXE 0x00004000
+#define MAX_SUPPORTED_ACM_VERSIONS 16
+
+#define DEF_ACM_MAX_SIZE	0x8000
+#define DEF_ACM_VER_MASK	0xffffffff
+#define DEF_ACM_VER_SUPPORTED	0x00
+#define DEF_ACM_MEM_TYPES	0x0100
+#define DEF_SENTER_CTRLS	0x00
+
+#define IA32_GETSEC_PARAMETERS	6
+
+#define off_n_versions		1
+#define off_acm_max_size	2
+#define off_acm_mem_types	3
+#define off_senter_controls	4
+#define off_proc_based_scrtm	5
+#define off_preserve_mce	6
+#define off_acm_version		7
+
+typedef struct getsec_parameters {
+	struct {
+		uint32_t mask;
+		uint32_t version;
+	} acm_versions[MAX_SUPPORTED_ACM_VERSIONS];
+	int n_versions;
+	uint32_t acm_max_size;
+	uint32_t acm_mem_types;
+	uint32_t senter_controls;
+	bool proc_based_scrtm;
+	bool preserve_mce;
+} getsec_parameters_t;
+
+extern int sysfs_create_parameter(struct kobject *parent);
+
+#endif /* __PARAMETER_H__ */
+
drivers/platform/x86/intel_txt/txt-sysfs.c +5 -0
index 4837935..9884618 100644
@@ -37,6 +37,7 @@
 #include <linux/tboot.h>
 
 #include "txt-config.h"
+#include "txt-parameter.h"
 
 #define DEV_NAME "intel_txt"
 static struct platform_device *txt_pdev;
@@ -56,6 +57,10 @@ static int __init txt_sysfs_init(void)
 	if (retval)
 		goto err;
 
+	retval = sysfs_create_parameter(&txt_pdev->dev.kobj);
+	if (retval)
+		goto err;
+
 	return 0;
 
 err:
Signature · 1 line
1.7.9.5