Skip to contentSkip to conversation

UFSHCD updates

PATCH New Santosh Y 1 participant 4 messages May 14, 2013

Subsystems (3)
lore
Share & tools
lore

Santosh Y

author
#0 lore raw

cover UFSHCD updates

Hi James,

Please merge the following patches to scsi tree.

Thanks,
Santosh

Geert Uytterhoeven (1):
SCSI_UFSHCD should depend on SCSI_DMA

Sachin Kamat (1):
ufs: Remove redundant platform_set_drvdata()

Sujit Reddy Thumma (1):
Documentation: devicetree: Add DT bindings for UFS host controller

 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 16 ++++++++++++++++
 drivers/scsi/ufs/Kconfig                                |  2 +-
 drivers/scsi/ufs/ufshcd-pltfrm.c                        |  1 -
 3 files changed, 17 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/3 ufs: Remove redundant platform_set_drvdata()

From: Sachin Kamat <[email protected]>

Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL.

drivers/scsi/ufs/ufshcd-pltfrm.c +0 -1
index 03319ac..3db2ee1 100644
@@ -184,7 +184,6 @@ static int ufshcd_pltfrm_remove(struct platform_device *pdev)
 		mem_size = resource_size(mem_res);
 		release_mem_region(mem_res->start, mem_size);
 	}
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.8.1.2
author
#2 lore raw

PATCH 2/3 SCSI_UFSHCD should depend on SCSI_DMA

In reply to Santosh Y

From: Geert Uytterhoeven <[email protected]>

If NO_DMA=y:

drivers/built-in.o: In function `ufshcd_transfer_req_compl':
drivers/scsi/ufs/ufshcd.c:1182: undefined reference to scsi_dma_unmap' drivers/built-in.o: In function ufshcd_map_sg':
drivers/scsi/ufs/ufshcd.c:377: undefined reference to `scsi_dma_map'
drivers/built-in.o: In function `ufshcd_do_reset':
drivers/scsi/ufs/ufshcd.c:912: undefined reference to scsi_dma_unmap' drivers/built-in.o: In function ufshcd_memory_alloc':
drivers/scsi/ufs/ufshcd.c:565: undefined reference to dma_alloc_coherent' drivers/built-in.o: In function ufshcd_free_hba_memory':
drivers/scsi/ufs/ufshcd.c:185: undefined reference to dma_free_coherent' drivers/scsi/ufs/ufshcd.c:192: undefined reference to dma_free_coherent' drivers/scsi/ufs/ufshcd.c:199: undefined reference to dma_free_coherent' drivers/scsi/ufs/ufshcd.c:185: undefined reference to dma_free_coherent' drivers/scsi/ufs/ufshcd.c:192: undefined reference to dma_free_coherent' drivers/built-in.o:drivers/scsi/ufs/ufshcd.c:199: more undefined references to dma_free_coherent' follow drivers/built-in.o: In function `ufshcd_abort':
drivers/scsi/ufs/ufshcd.c:1498: undefined reference to scsi_dma_unmap' drivers/built-in.o: In function ufshcd_device_reset':
drivers/scsi/ufs/ufshcd.c:1436: undefined reference to `scsi_dma_unmap'

drivers/scsi/ufs/Kconfig +1 -1
index 35faf24..f07f901 100644
@@ -34,7 +34,7 @@
 
 config SCSI_UFSHCD
 	tristate "Universal Flash Storage Controller Driver Core"
-	depends on SCSI
+	depends on SCSI && SCSI_DMA
 	---help---
 	This selects the support for UFS devices in Linux, say Y and make
 	  sure that you know the name of your UFS host adapter (the card
Signature · 1 line
1.8.1.2
author
#3 lore raw

PATCH 3/3 Documentation: devicetree: Add DT bindings for UFS host controller

In reply to Santosh Y

From: Sujit Reddy Thumma <[email protected]>

Compatible list is used in commit 03b1781 but is not documented. Add necessary device tree bindings to describe on-chip UFS host controllers.

Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt new file +16 -0
new file mode 100644
index 0000000..20468b2
@@ -0,0 +1,16 @@
+* Universal Flash Storage (UFS) Host Controller
+
+UFSHC nodes are defined to describe on-chip UFS host controllers.
+Each UFS controller instance should have its own node.
+
+Required properties:
+- compatible        : compatible list, contains "jedec,ufs-1.1"
+- interrupts        : <interrupt mapping for UFS host controller IRQ>
+- reg               : <registers mapping>
+
+Example:
+	ufshc@0xfc598000 {
+		compatible = "jedec,ufs-1.1";
+		reg = <0xfc598000 0x800>;
+		interrupts = <0 28 0>;
+	};
Signature · 1 line
1.8.1.2