Skip to contentSkip to conversation

nightly-qa-extras: fix image config options

PATCH In review Stefan Stanacar 3 participants 4 messages May 15, 2013 – May 17, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nightly-qa-extras: fix image config options

Use IMAGE_FEATURES_append instead of EXTRA_IMAGE_FEATURES because it gets overwritten by local.conf.
Remove the dmesg sanity as it requires copying a file which won't work on a r/o image.

---
 buildset-config/nightly-qa-extras.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
buildset-config/nightly-qa-extras.conf +2 -2
index c3af24c..1846764 100644
@@ -12,6 +12,6 @@ steps: [{'SetDest':{}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
         {'BuildImages': {'images': 'core-image-sato'}},
         {'RunSanityTests': {'images': 'core-image-sato'}},
-        {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'atextappend' : '\nEXTRA_IMAGE_FEATURES = "debug-tweaks read-only-rootfs"\n'}},
+        {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'atextappend' : '\nIMAGE_FEATURES_append = " read-only-rootfs"\n'}},
         {'BuildImages': {'images': 'core-image-sato'}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'scene' : 'sanity:boot sanity:ssh sanity:dmesg'}}]
+        {'RunSanityTests': {'images': 'core-image-sato', 'scene' : 'sanity:boot sanity:ssh'}}]
Signature · 1 line
1.8.1.4
#1 lore raw
Quoted 2 lines · Stefan Stanacar

Remove the dmesg sanity as it requires copying a file which won't work on a r/o image.

Is this copying the dmesg.sh to the target? Why not copy the file into /tmp, which will be read-write?

Ross

#2 lore raw
Quoted 6 lines · Ross
Quoted 2 lines · Stefan Stanacar

Remove the dmesg sanity as it requires copying a file which won't work on a r/o image.

Is this copying the dmesg.sh to the target? Why not copy the file into /tmp, which will be read-write?

Yes, dmesg sanity test calls Test_Target_Pre which copies dmesg.sh in /opt/test. That's the default in qemuimage-testlib. I don't see why dmesg can't be changed to do it differently. Anyway until that changes in master, the AB shouldn't run it.

Quoted 2 lines

Ross

#3 lore raw

Pulled and deployed. Thank you

-b

Quoted 18 lines · StefanX
Quoted 6 lines · Ross
Quoted 2 lines · Stefan Stanacar

Remove the dmesg sanity as it requires copying a file which won't work on a r/o image.

Is this copying the dmesg.sh to the target? Why not copy the file into /tmp, which will be read-write?

Yes, dmesg sanity test calls Test_Target_Pre which copies dmesg.sh in /opt/test. That's the default in qemuimage-testlib. I don't see why dmesg can't be changed to do it differently. Anyway until that changes in master, the AB shouldn't run it.

Quoted 2 lines

Ross

Signature · 3 lines
Elizabeth Flanagan
Yocto Project
Build and Release