Skip to contentSkip to conversation

drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices

PATCH Applied Leon Romanovsky 2 participants 2 messages May 15, 2013 – May 16, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices

In case mfd_add_devices will fail, it will call to mfd_remove_devices by itself and return non-zero value.

---
 drivers/mfd/sec-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mfd/sec-core.c +1 -2
index 5b740a3..c93ed3d 100644
@@ -230,13 +230,12 @@ static int sec_pmic_probe(struct i2c_client *i2c,
 		BUG();
 	}
 
-	if (ret < 0)
+	if (ret)
 		goto err;
 
 	return ret;
 
 err:
-	mfd_remove_devices(sec_pmic->dev);
 	sec_irq_exit(sec_pmic);
 	i2c_unregister_device(sec_pmic->rtc);
 	return ret;
Signature · 1 line
1.8.1.5
Applied
#1 lore raw

Hi Leon,

Quoted 7 lines · Leon Romanovsky

In case mfd_add_devices will fail, it will call to mfd_remove_devices by itself and return non-zero value.

---
 drivers/mfd/sec-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Applied to mfd-next, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/