mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'
PATCH 1/1 mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'
From: Zhouping Liu <[email protected]>
commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc()) forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.
--- mm/slab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/slab.c +1 -1
@@ -3339,7 +3339,7 @@ done: }/** -* kmem_cache_alloc_node - Allocate an object on the specified node +* slab_alloc_node - Allocate an object on the specified node * @cachep: The cache to allocate from. * @flags: See kmalloc(). * @nodeid: node number of the target node.
Signature · 7 lines
1.7.11.7 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 15 lines · Zhouping Liu
From: Zhouping Liu <[email protected]>
commit 48356303ff(mm, slab: Rename
__cache_alloc()->slab_alloc()) forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.Signed-off-by Zhouping Liu <[email protected]>--- mm/slab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/slab.c +0
-0
mm/slab.c done: · line 3345
Quoted 8 lines
mm/slab.c +1
-1@@ -3339,7 +3339,7 @@ done: }/** -* kmem_cache_alloc_node - Allocate an object on the specified node +* slab_alloc_node - Allocate an object on the specified node * @cachep: The cache to allocate from. * @flags: See kmalloc(). * @nodeid: node number of the target node.
The point of the comment is to document kernel API and whereas slab_alloc_node() is internal to the slab allocator. Can you please just move it on top of kmem_cache_alloc_node() definition in the same file?
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 18 lines · Pekka Enberg
Quoted 17 lines · Zhouping Liu
From: Zhouping Liu <[email protected]>
commit 48356303ff(mm, slab: Rename
__cache_alloc()->slab_alloc()) forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.Signed-off-by Zhouping Liu <[email protected]>--- mm/slab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/slab.c +0
-0@@ -3339,7 +3339,7 @@ done: }
Quoted 10 lines
mm/slab.c done: · line 3345
Quoted 6 lines
mm/slab.c +1
-1/** -* kmem_cache_alloc_node - Allocate an object on the specified node +* slab_alloc_node - Allocate an object on the specified node * @cachep: The cache to allocate from. * @flags: See kmalloc(). * @nodeid: node number of the target node. The point of the comment is to document kernel API and whereas
slab_alloc_node()is internal to the slab allocator. Can you please just move it on top ofkmem_cache_alloc_node()definition in the same file?
OK, thanks for reviewing, please check V2.
Thanks,
Zhouping
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>