power_supply: pm2301_charger: Fix NULL pointer dereference
PATCH 1/1 power_supply: pm2301_charger: Fix NULL pointer dereference
Add checking pl_data in probe, this prevent possible NULL pointer dereference. Also fix NULL pointer deference in dev_err when allocate memory for pm2 fails.
Signed-off-by Axel Lin <[email protected]>
--- drivers/power/pm2301_charger.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/power/pm2301_charger.c +6 -1
@@ -1007,9 +1007,14 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,u8 val;int i; +if (!pl_data) { +dev_err (&i2c_client->dev,"No platform data supplied\n" ); +return -EINVAL ; + } + pm2 =kzalloc (sizeof (struct pm2xxx_charger ),GFP_KERNEL );if (!pm2) { -dev_err (pm2->dev,"pm2xxx_charger allocation failed\n" ); +dev_err (&i2c_client->dev,"pm2xxx_charger allocation failed\n" );return -ENOMEM ; }
Signature · 1 line
1.8.1.2
Quoted 4 lines · Axel Lin
Add checking
pl_datain probe, this prevent possible NULL pointer dereference. Also fix NULL pointer deference indev_errwhen allocate memory for pm2 fails.Signed-off-by Axel Lin <[email protected]>
Acked-by Linus Walleij <[email protected]>
Yours,
Linus Walleij
Anton Vorontsov
AppliedQuoted 8 lines · Linus Walleij
Quoted 4 lines · Axel Lin
Add checking
pl_datain probe, this prevent possible NULL pointer dereference. Also fix NULL pointer deference indev_errwhen allocate memory for pm2 fails.Signed-off-by Axel Lin <[email protected]>Acked-by Linus Walleij <[email protected]>
Applied, thanks!
Anton