Skip to contentSkip to conversation

fix pointer casts in evaluate_compare()

PATCH In review Xi Wang 2 participants 3 messages May 16, 2013 – May 19, 2013 Sparse checker

lore
Share & tools
lore

Xi Wang

author
#0 lore raw

PATCH 1/1 fix pointer casts in evaluate_compare()

The results of cast_to() seem unused. Assign them to expr->left and expr->right.

---
 evaluate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
evaluate.c +4 -4
index 0dfa519..d9c767f 100644
@@ -1024,11 +1024,11 @@ static struct symbol *evaluate_compare(struct expression *expr)
 			goto OK;
 		}
 		if (is_null1 && (rclass & TYPE_PTR)) {
-			left = cast_to(left, rtype);
+			expr->left = cast_to(left, rtype);
 			goto OK;
 		}
 		if (is_null2 && (lclass & TYPE_PTR)) {
-			right = cast_to(right, ltype);
+			expr->right = cast_to(right, ltype);
 			goto OK;
 		}
 	}
@@ -1044,11 +1044,11 @@ static struct symbol *evaluate_compare(struct expression *expr)
 	if (expr->op == SPECIAL_EQUAL || expr->op == SPECIAL_NOTEQUAL) {
 		if (ltype->ctype.as == rtype->ctype.as) {
 			if (lbase == &void_ctype) {
-				right = cast_to(right, ltype);
+				expr->right = cast_to(right, ltype);
 				goto OK;
 			}
 			if (rbase == &void_ctype) {
-				left = cast_to(left, rtype);
+				expr->left = cast_to(left, rtype);
 				goto OK;
 			}
 		}
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 4 lines · Xi Wang

The results of cast_to() seem unused. Assign them to expr->left and expr->right.

How did you find about this? Is this needed to fix a reproducible issue?

Quoted 43 lines
---
 evaluate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
evaluate.c +4 -5
index 0dfa519..d9c767f 100644
@@ -1024,11 +1024,11 @@ static struct symbol *evaluate_compare(struct expression *expr)
                        goto OK;
                }
                if (is_null1 && (rclass & TYPE_PTR)) {
-                       left = cast_to(left, rtype);
+                       expr->left = cast_to(left, rtype);
                        goto OK;
                }
                if (is_null2 && (lclass & TYPE_PTR)) {
-                       right = cast_to(right, ltype);
+                       expr->right = cast_to(right, ltype);
                        goto OK;
                }
        }
@@ -1044,11 +1044,11 @@ static struct symbol *evaluate_compare(struct expression *expr)
        if (expr->op == SPECIAL_EQUAL || expr->op == SPECIAL_NOTEQUAL) {
                if (ltype->ctype.as == rtype->ctype.as) {
                        if (lbase == &void_ctype) {
-                               right = cast_to(right, ltype);
+                               expr->right = cast_to(right, ltype);
                                goto OK;
                        }
                        if (rbase == &void_ctype) {
-                               left = cast_to(left, rtype);
+                               expr->left = cast_to(left, rtype);
                                goto OK;
                        }
                }
--

1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 1 line · Pekka Enberg

How did you find about this? Is this needed to fix a reproducible issue?

I was debugging like (p == 0) and noticed that sparse lost this cast to pointers.

A more serious problem in evaluate_compare() is that sparse evaluates comparisons to bool, which should have been int, according to the C standard.

For example, sparse incorrectly evaluates sizeof(1 == 0) to 1, while gcc and clang evaluate this to 4 (i.e., sizeof(int)).

Similar problems exist when sparse evaluates other conditional expressions, such as !, &&, ||.

This also confuses sparse-llvm. For example, given OP_AND_BOOL x, y, should sparse-llvm assume that x and y can be int, bool, or some other type?

- xi