nfsd: avoid undefined signed overflow
Subsystems (2)
PATCH 1/1 nfsd: avoid undefined signed overflow
In C, signed integer overflow results in undefined behavior, but unsigned overflow wraps around. So do the subtraction first, then cast to signed.
Signed-off-by Jim Rees <[email protected]>
--- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/nfs4state.c +1 -1
@@ -3427,7 +3427,7 @@ grace_disallows_io(struct net *net, struct inode *inode)/* Returns true iff a is later than b: */ static bool stateid_generation_after (stateid_t *a,stateid_t *b) { -return (s32 )a->si_generation - (s32 )b->si_generation >0 ; +return (s32)(a->si_generation - b->si_generation) >0 ; }static __be32 check_stateid_generation (stateid_t *in,stateid_t *ref,bool has_session)
Signature · 1 line
1.8.2.3