Skip to contentSkip to conversation

pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()

PATCH In review Axel Lin 4 participants 9 messages May 20, 2013 – May 29, 2013

Subsystems (2)
SuperH PWM
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pwm/pwm-renesas-tpu.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/pwm/pwm-renesas-tpu.c +5 -0
index 8e6d8d7..319a6fe 100644
@@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
 {
 	struct tpu_device *tpu = platform_get_drvdata(pdev);
 	unsigned int i;
+	int ret;
+
+	ret = pwmchip_remove(&tpu->chip);
+	if (ret)
+		return ret;
 
 	for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
 		struct tpu_pwm_device *pwm = &tpu->pwms[i];
Signature · 1 line
1.8.1.2
Acked-by on v2 1/1
#1 lore raw

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 20 lines
---
 drivers/pwm/pwm-renesas-tpu.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/pwm/pwm-renesas-tpu.c +5 -0
index 8e6d8d7..319a6fe 100644
@@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
 {
 	struct tpu_device *tpu = platform_get_drvdata(pdev);
 	unsigned int i;
+	int ret;
+
+	ret = pwmchip_remove(&tpu->chip);
+	if (ret)
+		return ret;
 
 	for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
 		struct tpu_pwm_device *pwm = &tpu->pwms[i];
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
Quoted 8 lines · Laurent Pinchart

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <[email protected]>

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

Quoted 31 lines
Quoted 21 lines
---
 drivers/pwm/pwm-renesas-tpu.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/pwm/pwm-renesas-tpu.c +5 -0
index 8e6d8d7..319a6fe 100644
@@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
 {
 	struct tpu_device *tpu = platform_get_drvdata(pdev);
 	unsigned int i;
+	int ret;
+
+	ret = pwmchip_remove(&tpu->chip);
+	if (ret)
+		return ret;
 
 	for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
 		struct tpu_pwm_device *pwm = &tpu->pwms[i];
Signature · 8 lines
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 5 lines · Simon Horman
Quoted 4 lines · Laurent Pinchart

Hi Axel,

Thank you for the patch.

Quoted 7 lines
Quoted 4 lines · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <[email protected]>

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

I'd rather take this through the PWM tree along with the original driver patch.

Thierry

#4 lore raw
Quoted 9 lines · Thierry Reding
Quoted 8 lines · Simon Horman
Quoted 7 lines · Laurent Pinchart

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Acked-by Laurent Pinchart <[email protected]>

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

I'd rather take this through the PWM tree along with the original driver patch.

Sure that is fine.

I had them queued up in my tree but I have dropped them now. That should propogate to linux-next in the not too distant future.

I have also dropped the following changes from my tree as they appear to ether depend on the TPU PWD driver or one of the other patches in the list below.

Laurent, I think it would be best if you resubmitted these patches once there is a stable branch available with the TPU PWD driver merged which I can use as a base.

ARM: mach-shmobile: armadillo800eva: Add backlight support
ARM: mach-shmobile: kota2: Use leds-pwm + pwm-rmob
leds: Remove leds-renesas-tpu driver
sh-pfc: sh73a0: Remove function GPIOs

#5 lore raw
In reply to Thierry Reding

Hi Thierry,

Quoted 9 lines · On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
Quoted 8 lines · Simon Horman
Quoted 7 lines · Laurent Pinchart

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Acked-by Laurent Pinchart <[email protected]>

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

I'd rather take this through the PWM tree along with the original driver patch.

As I will need to submit a new version of the renesas-tpu patches should I fold this patch in ?

Signature · 3 lines
Regards,

Laurent Pinchart
author
#6 lore raw

2013/5/25 Laurent Pinchart <[email protected]>:

Quoted 14 lines

Hi Thierry,

Quoted 11 lines · On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
Quoted 10 lines · Simon Horman
Quoted 8 lines · Laurent Pinchart

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

I'd rather take this through the PWM tree along with the original driver patch.

As I will need to submit a new version of the renesas-tpu patches should I fold this patch in ?

Hi Laurent,
I think you can fold this patch in if you are going to submit a new version of the renesas-tpu patches.

Regards,
Axel

#7 lore raw
In reply to Laurent Pinchart
Quoted 14 lines · Laurent Pinchart

Hi Thierry,

Quoted 11 lines · On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
Quoted 10 lines · Simon Horman
Quoted 8 lines · Laurent Pinchart

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

I'd rather take this through the PWM tree along with the original driver patch.

As I will need to submit a new version of the renesas-tpu patches should I fold this patch in ?

Yes, that's fine with me. It'd be nice to credit Axel, though.

Thierry

#8 lore raw

Hi Thierry,

Quoted 12 lines · On Sunday 26 May 2013 11:18:24 Thierry Reding wrote:
Quoted 11 lines · Laurent Pinchart
Quoted 10 lines · On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
Quoted 8 lines · Simon Horman
Quoted 4 lines · Laurent Pinchart
Quoted 1 line · On Monday 20 May 2013 21:45:41 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <[email protected]>

Thanks. I have queued this up for v3.11 in the pinmux branch of my renesas tree on kernel.org.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I'd rather take this through the PWM tree along with the original driver patch.

As I will need to submit a new version of the renesas-tpu patches should I fold this patch in ?

Yes, that's fine with me. It'd be nice to credit Axel, though.

Sure. I'll add Axel's SoB line to the patch.

Signature · 3 lines
Regards,

Laurent Pinchart