Skip to contentSkip to conversation

drivers/rtc/rtc-pl031.c: Pass correct pointer to free_irq()

PATCH In review Lars-Peter Clausen 2 participants 2 messages May 20, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/rtc/rtc-pl031.c: Pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

---
 drivers/rtc/rtc-pl031.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-pl031.c +1 -1
index 8900ea7..0f0609b 100644
@@ -306,7 +306,7 @@ static int pl031_remove(struct amba_device *adev)
 	struct pl031_local *ldata = dev_get_drvdata(&adev->dev);
 
 	amba_set_drvdata(adev, NULL);
-	free_irq(adev->irq[0], ldata->rtc);
+	free_irq(adev->irq[0], ldata);
 	rtc_device_unregister(ldata->rtc);
 	iounmap(ldata->base);
 	kfree(ldata);
Signature · 1 line
1.8.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Lars-Peter Clausen

free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

Good job!

Yours,
Linus Walleij