Skip to contentSkip to conversation

unicore: dma: Pass correct pointer to free_irq()

PATCH New Lars-Peter Clausen 1 participant 1 message May 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unicore: dma: Pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

---
 arch/unicore32/kernel/dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/unicore32/kernel/dma.c +1 -1
index ed2d4d7..07f1b06 100644
@@ -172,7 +172,7 @@ int __init puv3_init_dma(void)
 	ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL);
 	if (ret) {
 		printk(KERN_CRIT "Can't register IRQ for DMAERR\n");
-		free_irq(IRQ_DMA, "DMA");
+		free_irq(IRQ_DMA, NULL);
 		return ret;
 	}
 
Signature · 1 line
1.8.0