video/ps3fb: Fix section mismatch warning
Subsystems (3)
Geoff Levand
maintainerPATCH 1/1 video/ps3fb: Fix section mismatch warning
Remove the __initdata attribute from the ps3fb_fix variable. This is in follow up to the removal of the __devinit attribute on the ps3fb_probe() routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
video: remove __dev* attributes).
Fixes build warnings like these:
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
--- drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/ps3fb.c +1 -1
@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,
Signature · 1 line
1.8.1.2
Quoted 5 lines · Geoff Levand
Remove the
__initdataattribute from theps3fb_fixvariable. This is in follow up to the removal of the__devinitattribute on theps3fb_probe()routine in commit48c68c4f1b542444f175a9e136febcecf3e704d8(Drivers:
video: remove __dev* attributes).
Quoted 7 lines
Fixes build warnings like these:
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable
__initdataps3fb_fix.
This is often because .ps3fb_probe lacks a__initdataannotation or the annotation ofps3fb_fixis wrong.Signed-off-by Geoff Levand <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Geoff Levand
maintainerPATCH 1/1 video/ps3fb: Fix section mismatch warning
In reply to Geoff LevandRemove the __initdata attribute from the ps3fb_fix variable. This is in follow up to the removal of the __devinit attribute on the ps3fb_probe() routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers:
video: remove __dev* attributes).
Fixes build warnings like these:
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix.
This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong.
---
This is a re-send. Could we please get this applied.
-Geoff
drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/ps3fb.c +1 -1
@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,
Signature · 1 line
1.8.1.2
Quoted 8 lines · Geoff Levand
Remove the
__initdataattribute from theps3fb_fixvariable. This is in follow up to the removal of the__devinitattribute on theps3fb_probe()routine in commit48c68c4f1b542444f175a9e136febcecf3e704d8(Drivers:
video: remove __dev* attributes).Fixes build warnings like these:
Quoted 7 lines
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the
variable .init.data:ps3fb_fix
The function .ps3fb_probe() references the variable__initdataps3fb_fix.
This is often because .ps3fb_probe lacks a__initdataannotation or the annotation ofps3fb_fixis
wrong.Signed-off-by Geoff Levand <[email protected]>
CC'ed Jean-Christophe Plagniol-Villard, Tomi Valkeinen (Framebuffer maintainer)
Currently, the maintainers of FRAMEBUFFER LAYER are Jean-Christophe Plagniol-Villard, and Tomi Valkeinen. So, I CC'ed them.
Best regards,
Jingoo Han
Quoted 25 lines
---
This is a re-send. Could we please get this applied.
(quoted diff) +0
-1-Geoff drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/video/ps3fb.c +1
-2@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR , --1.8.1.2
Tomi Valkeinen
AppliedQuoted 22 lines · Geoff Levand
Remove the
__initdataattribute from theps3fb_fixvariable. This is in follow up to the removal of the__devinitattribute on theps3fb_probe()routine in commit48c68c4f1b542444f175a9e136febcecf3e704d8(Drivers:
video: remove __dev* attributes).Fixes build warnings like these:
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable
__initdataps3fb_fix.
This is often because .ps3fb_probe lacks a__initdataannotation or the annotation ofps3fb_fixis wrong.Signed-off-by Geoff Levand <[email protected]>--- drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/video/ps3fb.c +0
-0
drivers/video/ps3fb.c static struct fb_ops ps3fb_ops = { · line 958
Quoted 8 lines
drivers/video/ps3fb.c +1
-1@@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix__initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id =DEVICE_NAME , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,
Thanks, applied for 3.13.
Tomi
Quoted 8 lines · Tomi Valkeinen
Quoted 7 lines · Geoff Levand
Remove the
__initdataattribute from theps3fb_fixvariable. This is in follow up to the removal of the__devinitattribute on theps3fb_probe()routine in commit48c68c4f1b542444f175a9e136febcecf3e704d8(Drivers:
video: remove __dev* attributes).Fixes build warnings like these:
Quoted 7 lines
Quoted 5 lines
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable
__initdataps3fb_fix.
This is often because .ps3fb_probe lacks a__initdataannotation or the annotation ofps3fb_fixis wrong.Signed-off-by Geoff Levand <[email protected]>Thanks, applied for 3.13.
Too late. It already got in last week through Cell and PS3 supporter BenH ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 13 lines · Geert Uytterhoeven
Quoted 12 lines · Tomi Valkeinen
Quoted 11 lines · Geoff Levand
Remove the
__initdataattribute from theps3fb_fixvariable. This is in follow up to the removal of the__devinitattribute on theps3fb_probe()routine in commit48c68c4f1b542444f175a9e136febcecf3e704d8(Drivers:
video: remove __dev* attributes).Fixes build warnings like these:
WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable
__initdataps3fb_fix.
This is often because .ps3fb_probe lacks a__initdataannotation or the annotation ofps3fb_fixis wrong.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Geoff Levand <[email protected]>Thanks, applied for 3.13.
Too late. It already got in last week through Cell and PS3 supporter BenH ;-)
Ok, thanks for informing. Maybe I'll be faster next time, shouldn't be difficult to achieve ;).
Tomi