Skip to contentSkip to conversation

ARM: iomux-mx51: Always define PUE for pins used as GPIO

PATCH New Alexander Shiyan 3 participants 6 messages May 21, 2013 – May 22, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: iomux-mx51: Always define PUE for pins used as GPIO

This patch adds a PUE bit for pins which used as GPIO. This allow to use the GPIOs correctly as inputs when source is open-drain with external pullup resistor (IRQ open-drain outputs for example).

---
 arch/arm/mach-imx/iomux-mx51.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-imx/iomux-mx51.h +2 -1
index 75bbcc4..7dc187c 100644
@@ -34,7 +34,8 @@
 #define MX51_SDHCI_PAD_CTRL	(PAD_CTL_PKE | PAD_CTL_DSE_HIGH | \
 				PAD_CTL_PUS_47K_UP | PAD_CTL_PUE | \
 				PAD_CTL_SRE_FAST | PAD_CTL_DVS)
-#define MX51_GPIO_PAD_CTRL	(PAD_CTL_DSE_HIGH | PAD_CTL_PKE | PAD_CTL_SRE_FAST)
+#define MX51_GPIO_PAD_CTRL	(PAD_CTL_DSE_HIGH | PAD_CTL_PKE | \
+				PAD_CTL_PUE | PAD_CTL_SRE_FAST)
 
 #define MX51_PAD_CTRL_2		(PAD_CTL_PKE | PAD_CTL_HYS)
 #define MX51_PAD_CTRL_3		(PAD_CTL_PKE | PAD_CTL_PUS_100K_UP)
Signature · 1 line
1.8.1.5
maintainer
#1 lore raw

PATCH 1/1 ARM: iomux-mx51: Always define PUE for pins used as GPIO

Quoted 3 lines · Alexander Shiyan

This patch adds a PUE bit for pins which used as GPIO. This allow to use the GPIOs correctly as inputs when source is open-drain with external pullup resistor (IRQ open-drain outputs for example).

I don't understand. If there's an external pullup why do you want to turn on the internal one?

Sascha

Quoted 24 lines
---
 arch/arm/mach-imx/iomux-mx51.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-imx/iomux-mx51.h +2 -1
index 75bbcc4..7dc187c 100644
@@ -34,7 +34,8 @@
 #define MX51_SDHCI_PAD_CTRL	(PAD_CTL_PKE | PAD_CTL_DSE_HIGH | \
 				PAD_CTL_PUS_47K_UP | PAD_CTL_PUE | \
 				PAD_CTL_SRE_FAST | PAD_CTL_DVS)
-#define MX51_GPIO_PAD_CTRL	(PAD_CTL_DSE_HIGH | PAD_CTL_PKE | PAD_CTL_SRE_FAST)
+#define MX51_GPIO_PAD_CTRL	(PAD_CTL_DSE_HIGH | PAD_CTL_PKE | \
+				PAD_CTL_PUE | PAD_CTL_SRE_FAST)
 
 #define MX51_PAD_CTRL_2		(PAD_CTL_PKE | PAD_CTL_HYS)
 #define MX51_PAD_CTRL_3		(PAD_CTL_PKE | PAD_CTL_PUS_100K_UP)
Signature · 1 line
1.8.1.5
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw
Quoted 7 lines · Alexander Shiyan
Quoted 3 lines

This patch adds a PUE bit for pins which used as GPIO. This allow to use the GPIOs correctly as inputs when source is open-drain with external pullup resistor (IRQ open-drain outputs for example).

I don't understand. If there's an external pullup why do you want to turn on the internal one?

It is just switch off keeper circuit.

Some pads not have internal pullup, probably this is affected only for such pins. This is example of this issue:
Used pad MX51_PAD_DISPB2_SER_CLK__GPIO3_7, (GPIO3.7 = 71).
External pullup resistor is used.

gpio_direction output 71 1
gpio_direction_input 71
gpio_get_value 71; echo $?
1
gpio_direction output 71 0
gpio_direction_input 71
gpio_get_value 71; echo $?
0

So, we cannot get "1" here anymore if only pullup is used for this pad. The pad is keep last logic state... The second solution for this is disable PKE, i am not sure which solution is the best...

Quoted 17 lines
Quoted 17 lines
---
 arch/arm/mach-imx/iomux-mx51.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-imx/iomux-mx51.h +2 -1
index 75bbcc4..7dc187c 100644
@@ -34,7 +34,8 @@
 #define MX51_SDHCI_PAD_CTRL	(PAD_CTL_PKE | PAD_CTL_DSE_HIGH | \
 				PAD_CTL_PUS_47K_UP | PAD_CTL_PUE | \
 				PAD_CTL_SRE_FAST | PAD_CTL_DVS)
-#define MX51_GPIO_PAD_CTRL	(PAD_CTL_DSE_HIGH | PAD_CTL_PKE | PAD_CTL_SRE_FAST)
+#define MX51_GPIO_PAD_CTRL	(PAD_CTL_DSE_HIGH | PAD_CTL_PKE | \
+				PAD_CTL_PUE | PAD_CTL_SRE_FAST)
 
Quoted 3 lines

arch/arm/mach-imx/iomux-mx51.h line 41

Quoted 3 lines
arch/arm/mach-imx/iomux-mx51.h +0 -0
 #define MX51_PAD_CTRL_2		(PAD_CTL_PKE | PAD_CTL_HYS)
 #define MX51_PAD_CTRL_3		(PAD_CTL_PKE | PAD_CTL_PUS_100K_UP)

---

#3 lore raw

PATCH 1/1 ARM: iomux-mx51: Always define PU E for pins used as GPIO

Hi,

Quoted 10 lines · Alexander Shiyan
Quoted 7 lines · Alexander Shiyan
Quoted 3 lines

This patch adds a PUE bit for pins which used as GPIO. This allow to use the GPIOs correctly as inputs when source is open-drain with external pullup resistor (IRQ open-drain outputs for example).

I don't understand. If there's an external pullup why do you want to turn on the internal one?

It is just switch off keeper circuit.

If you want to switch the keeper circuit off why don't you do that by removing PAD_CTL_PKE rather than adding PAD_CTL_PUE?

Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
#4 lore raw

Re[3]: [PATCH] ARM: iomux-mx51: Always define PU E for pins used as GPIO

Quoted 6 lines
Quoted 5 lines · Alexander Shiyan
Quoted 5 lines · Alexander Shiyan
Quoted 3 lines

This patch adds a PUE bit for pins which used as GPIO. This allow to use the GPIOs correctly as inputs when source is open-drain with external pullup resistor (IRQ open-drain outputs for example).

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I don't understand. If there's an external pullup why do you want to turn on the internal one?

It is just switch off keeper circuit.

If you want to switch the keeper circuit off why don't you do that by removing PAD_CTL_PKE rather than adding PAD_CTL_PUE?

Again, I do not know which the solution here is better. If we remove the PKE bit, for some pins it will be removed the default pullup/pulldown (PUS = 0), so it may affect the some running configuration.

---

#5 lore raw

PATCH 1/1 ARM: iomux-mx51: Always define PU E for pins used as GPIO

Hi,

Quoted 9 lines · Alexander Shiyan
Quoted 9 lines
Quoted 8 lines · Alexander Shiyan
Quoted 7 lines · Alexander Shiyan
Quoted 3 lines

This patch adds a PUE bit for pins which used as GPIO. This allow to use the GPIOs correctly as inputs when source is open-drain with external pullup resistor (IRQ open-drain outputs for example).

I don't understand. If there's an external pullup why do you want to turn on the internal one?

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

It is just switch off keeper circuit.

If you want to switch the keeper circuit off why don't you do that by removing PAD_CTL_PKE rather than adding PAD_CTL_PUE?

Again, I do not know which the solution here is better. If we remove the PKE bit, for some pins it will be removed the default pullup/pulldown (PUS = 0), so it may affect the some running configuration.

IMO the current approach of defining the pad config with the pad definition is broken anyway. It would be much better to specify the pad configuration at the point where a specific pad is used, rather than where it is defined.
The pin mux setting for a specific function of a pin is always the same for any platform but the pad config may be different for different platforms.

Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________