Skip to contentSkip to conversation

mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

PATCH New Markos Chandras 2 participants 5 messages May 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

From: Markos Chandras <[email protected]>

mongrel2 needs the {get,make,swap}context functions which are present in glibc and in the uClibc's master branch.

Fixes:
http://autobuild.buildroot.net/results/8e132a2b03a7b5ae94199db7db86883c05dca700/build-end.log

---
 package/mongrel2/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/mongrel2/Config.in +3 -0
index 05d10d7..1cebcf0 100644
@@ -6,6 +6,9 @@ config BR2_PACKAGE_MONGREL2
 	depends on BR2_INET_IPV6 # zeromq
 	depends on BR2_LARGEFILE # zeromq -> util-linux
 	depends on BR2_USE_WCHAR # zeromq -> util-linux
+	# {get,make,swap}context functions present in
+	# glibc and in uClibc's master branch.
+	depends on BR2_UCLIBC_VERSION_SNAPSHOT || !BR2_TOOLCHAIN_BUILDROOT
 	help
 	  Mongrel2 is an application, language, and network architecture
 	  agnostic web server that focuses on web applications using
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

Dear Markos Chandras,

package/mongrel2/Config.in config BR2_PACKAGE_MONGREL2 · line 14

Quoted 6 lines · Markos Chandras
package/mongrel2/Config.in +3 -0
+	# {get,make,swap}context functions present in
+	# glibc and in uClibc's master branch.
+	depends on BR2_UCLIBC_VERSION_SNAPSHOT || !BR2_TOOLCHAIN_BUILDROOT
 	help
 	  Mongrel2 is an application, language, and network architecture
 	  agnostic web server that focuses on web applications using

An external toolchain can be uClibc based... but we don't know which version. However, since no uClibc stable release has been released with this feature, I don't expect any external toolchain today to have this feature enabled. So something like:

	depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
		external toolchain uses glibc or eglibc || \
		crosstool-ng backend has glibc or eglibc selected

Would probably be more appropriate.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

Quoted 22 lines · Thomas Petazzoni

Dear Markos Chandras,

package/mongrel2/Config.in config BR2_PACKAGE_MONGREL2 · line 14

Quoted 6 lines · Markos Chandras
package/mongrel2/Config.in +3 -0
+     # {get,make,swap}context functions present in
+     # glibc and in uClibc's master branch.
+     depends on BR2_UCLIBC_VERSION_SNAPSHOT || !BR2_TOOLCHAIN_BUILDROOT
      help
        Mongrel2 is an application, language, and network architecture
        agnostic web server that focuses on web applications using

An external toolchain can be uClibc based... but we don't know which version. However, since no uClibc stable release has been released with this feature, I don't expect any external toolchain today to have this feature enabled. So something like:

        depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
                external toolchain uses glibc or eglibc || \
                crosstool-ng backend has glibc or eglibc selected

Would probably be more appropriate.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Hi Thomas,

No problem. Although I can't find an option for external toolchain + eglibc. So what I have right now is this:

        # {get,make,swap}context functions present in
        # {e,}glibc and in uClibc's master branch.
        depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
                BR2_TOOLCHAIN_CTNG_eglibc || \
                BR2_TOOLCHAIN_CTNG_glibc || \
                BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC || \
                BR2_TOOLCHAIN_EXTERNAL_GLIBC

I believe this should cover all the cases. Thanks for the review

--
Regards,
Markos Chandras

#3 lore raw

PATCH 1/1 mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

Dear Markos Chandras,

Quoted 2 lines · Markos Chandras

No problem. Although I can't find an option for external toolchain + eglibc. So what I have right now is this:

Yes, in the external toolchain backend, we support eglibc and glibc similarly, so there's just one single option for both.

It is however not needed to put BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC in your condition, because it already selects BR2_TOOLCHAIN_EXTERNAL_GLIBC. So as far as external toolchains are concerned, "depends on BR2_TOOLCHAIN_EXTERNAL_GLIBC" is enough.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

Quoted 15 lines · Thomas Petazzoni

Dear Markos Chandras,

Quoted 2 lines · Markos Chandras

No problem. Although I can't find an option for external toolchain + eglibc. So what I have right now is this:

Yes, in the external toolchain backend, we support eglibc and glibc similarly, so there's just one single option for both.

It is however not needed to put BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC in your condition, because it already selects BR2_TOOLCHAIN_EXTERNAL_GLIBC. So as far as external toolchains are concerned, "depends on BR2_TOOLCHAIN_EXTERNAL_GLIBC" is enough.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Hi Thomas,

Thank you for the clarification. I will prepare a new patch.

--
Regards,
Markos Chandras