Skip to contentSkip to conversation

MIPS: define cpu_has_mmips where appropriate

PATCH In review Jonas Gorski 3 participants 5 messages May 23, 2013 – Jun 26, 2013 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: define cpu_has_mmips where appropriate

Disable cpu_has_mmips for everything but SEAD3 and MALTA. Most of these platforms are from before the micromips introduction, so they are very unlikely to implement it.

Reduces an -Os compiled, uncompressed kernel image by 8KiB for BCM63XX.

---

Position chosen is based on asm/cpu-features.h. Missing hardware and/or data sheets for most platforms I obviously couldn't verify its non-existence, so maintainer acks are appreciated.

 arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h         |    1 +
 arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h        |    1 +
 arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h       |    1 +
 arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h |    1 +
 arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h        |    1 +
 arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h          |    1 +
 arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h          |    1 +
 arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h          |    1 +
 arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h          |    1 +
 arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h        |    1 +
 arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h      |    1 +
 arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h      |    1 +
 arch/mips/include/asm/mach-pmcs-msp71xx/cpu-feature-overrides.h  |    1 +
 arch/mips/include/asm/mach-powertv/cpu-feature-overrides.h       |    1 +
 arch/mips/include/asm/mach-ralink/rt288x/cpu-feature-overrides.h |    1 +
 arch/mips/include/asm/mach-ralink/rt305x/cpu-feature-overrides.h |    1 +
 arch/mips/include/asm/mach-ralink/rt3883/cpu-feature-overrides.h |    1 +
 arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h       |    1 +
 arch/mips/include/asm/mach-rm/cpu-feature-overrides.h            |    1 +
 arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h        |    1 +
 arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h        |    1 +
 21 files changed, 21 insertions(+)
arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h +1 -0
index ddb947e..d7d2b91 100644
@@ -36,6 +36,7 @@
 #define cpu_has_mdmx		0
 #define cpu_has_mips3d		0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 
 #define cpu_has_mips32r1	1
 #define cpu_has_mips32r2	1
arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h +1 -0
index 09f45e6..2c33b1f 100644
@@ -28,6 +28,7 @@
 #define cpu_has_mdmx			0
 #define cpu_has_mips3d			0
 #define cpu_has_smartmips		0
+#define cpu_has_mmips			0
 #define cpu_has_vtag_icache		0
 #define cpu_has_dc_aliases		0
 #define cpu_has_ic_fills_f_dc		1
arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h +1 -0
index e9c408e..91d76fa 100644
@@ -22,6 +22,7 @@
 #define cpu_has_mdmx			0
 #define cpu_has_mips3d			0
 #define cpu_has_smartmips		0
+#define cpu_has_mmips			0
 #define cpu_has_vtag_icache		0
 
 #if !defined(BCMCPU_RUNTIME_DETECT) && (defined(CONFIG_BCM63XX_CPU_6348) || defined(CONFIG_BCM63XX_CPU_6345) || defined(CONFIG_BCM63XX_CPU_6338))
arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h +1 -0
index 94ed063..862fb99 100644
@@ -55,6 +55,7 @@
 #define cpu_has_dsp		0
 #define cpu_has_dsp2		0
 #define cpu_has_mipsmt		0
+#define cpu_has_mmips		0
 #define cpu_has_vint		0
 #define cpu_has_veic		0
 #define cpu_hwrena_impl_bits	0xc0000000
arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h +1 -0
index 71d4bfa..89ca55c 100644
@@ -41,6 +41,7 @@
 #define cpu_has_mdmx		0
 #define cpu_has_mips3d		0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 #define cpu_has_vtag_icache	0
 #define cpu_has_ic_fills_f_dc	0
 #define cpu_icache_snoops_remote_store	0
arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h +1 -0
index f4caacd..704cc54 100644
@@ -23,6 +23,7 @@
 #define cpu_has_prefetch	0
 #define cpu_has_mcheck		0
 #define cpu_has_ejtag		0
+#define cpu_has_mmips		0
 
 #define cpu_has_llsc		1
 #define cpu_has_vtag_icache	0		/* Needs to change for R8000 */
arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h +1 -0
index 1d2b6ff..156e4d4 100644
@@ -20,6 +20,7 @@
 #define cpu_has_prefetch	1
 #define cpu_has_mcheck		0
 #define cpu_has_ejtag		0
+#define cpu_has_mmips		0
 
 #define cpu_has_llsc		1
 #define cpu_has_vtag_icache	0
arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h +1 -0
index 65e9c85..7cc6593 100644
@@ -21,6 +21,7 @@
 #define cpu_has_prefetch	1
 #define cpu_has_mcheck		0
 #define cpu_has_ejtag		0
+#define cpu_has_mmips		0
 
 #define cpu_has_llsc		1
 #define cpu_has_vtag_icache	0
arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h +1 -0
index 2e1ec6c..0c7b7a0 100644
@@ -34,6 +34,7 @@
 #define cpu_has_cache_cdex_s	0
 #define cpu_has_mcheck		0
 #define cpu_has_ejtag		0
+#define cpu_has_mmips		0
 #define cpu_has_vtag_icache	0
 #define cpu_has_ic_fills_f_dc	0
 #define cpu_has_dsp		0
arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h +1 -0
index a225baa..4da0711 100644
@@ -28,6 +28,7 @@
 #define cpu_has_mdmx 0
 #define cpu_has_mips3d 0
 #define cpu_has_smartmips 0
+#define cpu_has_mmips		0
 #define kernel_uses_llsc	1
 #define cpu_has_vtag_icache	1
 #define cpu_has_dc_aliases	0
arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h +1 -0
index c0f3ef4..ca34d19 100644
@@ -49,6 +49,7 @@
 #define cpu_has_mipsmt		0
 #define cpu_has_prefetch	0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 #define cpu_has_tlb		1
 #define cpu_has_tx39_cache	0
 #define cpu_has_userlocal	0
arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h +1 -0
index 091deb17..49d58ee 100644
@@ -21,6 +21,7 @@
 #define cpu_has_prefetch	1
 #define cpu_has_mcheck		1
 #define cpu_has_ejtag		1
+#define cpu_has_mmips		0
 
 #define cpu_has_llsc		1
 #define cpu_has_vtag_icache	0
arch/mips/include/asm/mach-pmcs-msp71xx/cpu-feature-overrides.h +1 -0
index 016fa94..3a6805a 100644
@@ -13,6 +13,7 @@
 /* #define cpu_has_dsp2		??? - do runtime detection */
 #define cpu_has_mipsmt		1
 #define cpu_has_fpu		0
+#define cpu_has_mmips		0
 
 #define cpu_has_mips32r1	0
 #define cpu_has_mips32r2	1
arch/mips/include/asm/mach-powertv/cpu-feature-overrides.h +1 -0
index 58c76ec..fdfcb57 100644
@@ -37,6 +37,7 @@
 #define cpu_has_mdmx			0
 #define cpu_has_mips3d			0
 #define cpu_has_smartmips		0
+#define cpu_has_mmips			0
 #define cpu_has_vtag_icache		0
 #define cpu_has_dc_aliases		0
 #define cpu_has_ic_fills_f_dc		0
arch/mips/include/asm/mach-ralink/rt288x/cpu-feature-overrides.h +1 -0
index 72fc106..ac98538 100644
@@ -36,6 +36,7 @@
 #define cpu_has_mdmx		0
 #define cpu_has_mips3d		0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 
 #define cpu_has_mips32r1	1
 #define cpu_has_mips32r2	1
arch/mips/include/asm/mach-ralink/rt305x/cpu-feature-overrides.h +1 -0
index 917c286..a1f1c29 100644
@@ -36,6 +36,7 @@
 #define cpu_has_mdmx		0
 #define cpu_has_mips3d		0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 
 #define cpu_has_mips32r1	1
 #define cpu_has_mips32r2	1
arch/mips/include/asm/mach-ralink/rt3883/cpu-feature-overrides.h +1 -0
index 181fbf4..9c88896 100644
@@ -35,6 +35,7 @@
 #define cpu_has_mdmx		0
 #define cpu_has_mips3d		0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 
 #define cpu_has_mips32r1	1
 #define cpu_has_mips32r2	1
arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h +1 -0
index b153075..2801166 100644
@@ -51,6 +51,7 @@
 #define cpu_has_mdmx			0
 #define cpu_has_mips3d			0
 #define cpu_has_smartmips		0
+#define cpu_has_mmips			0
 
 #define cpu_has_vtag_icache		0
 
arch/mips/include/asm/mach-rm/cpu-feature-overrides.h +1 -0
index f095c52..44d0daf 100644
@@ -25,6 +25,7 @@
 #define cpu_has_prefetch	0
 #define cpu_has_mcheck		0
 #define cpu_has_ejtag		0
+#define cpu_has_mmips		0
 #define cpu_has_llsc		1
 #define cpu_has_vtag_icache	0
 #define cpu_has_dc_aliases	(PAGE_SIZE < 0x4000)
arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h +1 -0
index 92927b6..152c9a6 100644
@@ -20,6 +20,7 @@
 #define cpu_has_prefetch	1
 #define cpu_has_mcheck		1
 #define cpu_has_ejtag		1
+#define cpu_has_mmips		0
 
 #define cpu_has_llsc		1
 #define cpu_has_vtag_icache	1
arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h +1 -0
index 7f5144c..6913da4 100644
@@ -9,6 +9,7 @@
 #define cpu_has_mdmx		0
 #define cpu_has_mips3d		0
 #define cpu_has_smartmips	0
+#define cpu_has_mmips		0
 #define cpu_has_vtag_icache	0
 #define cpu_has_ic_fills_f_dc	0
 #define cpu_has_dsp	0
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jonas Gorski

Disable cpu_has_mmips for everything but SEAD3 and MALTA. Most of these platforms are from before the micromips introduction, so they are very unlikely to implement it.

Reduces an -Os compiled, uncompressed kernel image by 8KiB for BCM63XX.

Quoted 29 lines

---

Position chosen is based on asm/cpu-features.h. Missing hardware and/or data sheets for most platforms I obviously couldn't verify its non-existence, so maintainer acks are appreciated.

  arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h         |    1 +
  arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h        |    1 +
  arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h       |    1 +
  arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h |    1 +
  arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h        |    1 +
  arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h          |    1 +
  arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h          |    1 +
  arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h          |    1 +
  arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h          |    1 +
  arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h        |    1 +
  arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h      |    1 +
  arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h      |    1 +
  arch/mips/include/asm/mach-pmcs-msp71xx/cpu-feature-overrides.h  |    1 +
  arch/mips/include/asm/mach-powertv/cpu-feature-overrides.h       |    1 +
  arch/mips/include/asm/mach-ralink/rt288x/cpu-feature-overrides.h |    1 +
  arch/mips/include/asm/mach-ralink/rt305x/cpu-feature-overrides.h |    1 +
  arch/mips/include/asm/mach-ralink/rt3883/cpu-feature-overrides.h |    1 +
  arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h       |    1 +
  arch/mips/include/asm/mach-rm/cpu-feature-overrides.h            |    1 +
  arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h        |    1 +
  arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h        |    1 +
  21 files changed, 21 insertions(+)

[...]

#2 lore raw
Quoted 10 lines · David Daney
Quoted 7 lines · Jonas Gorski

Disable cpu_has_mmips for everything but SEAD3 and MALTA. Most of these platforms are from before the micromips introduction, so they are very unlikely to implement it.

Reduces an -Os compiled, uncompressed kernel image by 8KiB for BCM63XX.

I changed my mind: NAK.

I will send a smaller, but equivalent patch.

Quoted 52 lines
Quoted 50 lines

---

Position chosen is based on asm/cpu-features.h. Missing hardware and/or data sheets for most platforms I obviously couldn't verify its non-existence, so maintainer acks are appreciated.

arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-loongson/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-pmcs-msp71xx/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-powertv/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ralink/rt288x/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ralink/rt305x/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-ralink/rt3883/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-rm/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h
| 1 +
arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h
| 1 +

  21 files changed, 21 insertions(+)

[...]

#4 lore raw
Quoted 7 lines · Ralf Baechle
Quoted 5 lines
Quoted 1 line

I changed my mind: NAK.

I will send a smaller, but equivalent patch.

Fair enough - until then I'm going to apply this patch.

Jonas pointed me at your other patch so I'm going to drop this one again.

Ralf