power_supply: generic-adc-battery: Fix checking if none of the channels are supported
PATCH 1/1 power_supply: generic-adc-battery: Fix checking if none of the channels are supported
If none of the channels are supported, index is 0.
Also ensure to return error code instead of 0 in goto second_mem_fail path.
Signed-off-by Axel Lin <[email protected]>
--- drivers/power/generic-adc-battery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/power/generic-adc-battery.c +3 -1
@@ -299,8 +299,10 @@ static int gab_probe(struct platform_device *pdev) }/* none of the channels are supported so let's bail out */ -if (index ==ARRAY_SIZE (gab_chan_name)) +if (index ==0 ) { + ret = -ENODEV ; goto second_mem_fail; + }/* * Total number of properties is equal to static properties
Signature · 1 line
1.8.1.2
Quoted 4 lines · Axel Lin
If none of the channels are supported, index is 0.
Also ensure to return error code instead of 0 in gotosecond_mem_failpath.Signed-off-by Axel Lin <[email protected]>
Acked-by anish kumar <[email protected]>
I think anton would have already picked up.
Quoted 25 lines
--- drivers/power/generic-adc-battery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/power/generic-adc-battery.c +3
-2@@ -299,8 +299,10 @@ static int gab_probe(struct platform_device *pdev) }/* none of the channels are supported so let's bail out */ -if (index ==ARRAY_SIZE (gab_chan_name)) +if (index ==0 ) { + ret = -ENODEV ; goto second_mem_fail; + }/* * Total number of properties is equal to static properties -- 1.8.1.2
Anton Vorontsov
AppliedQuoted 6 lines · anish singh
Quoted 4 lines · Axel Lin
If none of the channels are supported, index is 0.
Also ensure to return error code instead of 0 in gotosecond_mem_failpath.Signed-off-by Axel Lin <[email protected]>Acked-by anish kumar <[email protected]>
Applied, thanks!
Anton