Skip to contentSkip to conversation

perf: fix printing of perf_event_paranoid message

PATCH New David Ahern 2 participants 2 messages May 25, 2013 – May 31, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 perf: fix printing of perf_event_paranoid message

message is currently shown as:

Error:
You may not have permission to collect %sstats. Consider tweaking /proc/sys/kernel/perf_event_paranoid:

Note the %sstats. With patch this becomes:

Error:
You may not have permission to collect stats. Consider tweaking /proc/sys/kernel/perf_event_paranoid:

---
 tools/perf/util/evsel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/evsel.c +1 -1
index 07b1a3a..63b6f8c 100644
@@ -1514,7 +1514,7 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel,
 	switch (err) {
 	case EPERM:
 	case EACCES:
-		return scnprintf(msg, size, "%s",
+		return scnprintf(msg, size,
 		 "You may not have permission to collect %sstats.\n"
 		 "Consider tweaking /proc/sys/kernel/perf_event_paranoid:\n"
 		 " -1 - Not paranoid at all\n"
Signature · 1 line
1.7.10.1
#1 lore raw

[tip:perf/core] perf evsel: Fix printing of perf_event_paranoid message

perf evsel: Fix printing of perf_event_paranoid message
Commit-ID:  b69e63a45f2d96a0dfe930ed20385058d4574d2f
Gitweb:     http://git.kernel.org/tip/b69e63a45f2d96a0dfe930ed20385058d4574d2f
Author:     David Ahern <[email protected]>
AuthorDate: Sat, 25 May 2013 17:54:00 -0600
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 28 May 2013 16:24:03 +0300

perf evsel: Fix printing of perf_event_paranoid message

message is currently shown as:

Error:
You may not have permission to collect %sstats. Consider tweaking /proc/sys/kernel/perf_event_paranoid:

Note the %sstats. With patch this becomes:

Error:
You may not have permission to collect stats. Consider tweaking /proc/sys/kernel/perf_event_paranoid:

---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/evsel.c +1 -1
index 07b1a3a..63b6f8c 100644
@@ -1514,7 +1514,7 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel,
 	switch (err) {
 	case EPERM:
 	case EACCES:
-		return scnprintf(msg, size, "%s",
+		return scnprintf(msg, size,
 		 "You may not have permission to collect %sstats.\n"
 		 "Consider tweaking /proc/sys/kernel/perf_event_paranoid:\n"
 		 " -1 - Not paranoid at all\n"