Skip to contentSkip to conversation

chromium_24.0.1312.52.bb: Fix build with hardfp

PATCH In review Khem Raj 3 participants 7 messages May 26, 2013 – May 28, 2013

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 chromium_24.0.1312.52.bb: Fix build with hardfp

Add missing dep on gconf-2
Pass Wno-error=unused-local-typedefs to please gcc 4.8

CC Eric Bénard <[email protected]>
CC Denis Carikli <[email protected]>
CC Otavio Salvador <[email protected]>
---
 recipes-browser/chromium/chromium_24.0.1312.52.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
recipes-browser/chromium/chromium_24.0.1312.52.bb +3 -2
index a9a2d28..f877812 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Chromium browser"
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=0750f191c9bbf46869b70508e7eb455b"
-DEPENDS = "xextproto cairo nss gtk+ zlib-native libav libxi libgnome-keyring libxss cups ninja-native"
+DEPENDS = "xextproto cairo nss gtk+ zlib-native libav libxi libgnome-keyring libxss cups ninja-native gconf"
 
 SRC_URI = "http://commondatastorage.googleapis.com/chromium-browser-official/${P}.tar.bz2 \
         file://include.gypi \
@@ -35,7 +35,8 @@ EXTRA_OEGYP =	" \
 	-I ${WORKDIR}/include.gypi \
 	-f ninja \
 "
-
+ARMFPABI_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', 'arm_float_abi=hard', 'arm_float_abi=softfp', d)}"
+export GYP_DEFINES="${ARMFPABI} release_extra_cflags='-Wno-error=unused-local-typedefs'"
 do_configure() {
 	cd ${S}
 	# replace LD with CXX, to workaround a possible gyp issue?
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 2/2 chromium: Add recipes for 29.0.1518

CC Eric Bénard <[email protected]>
CC Denis Carikli <[email protected]>
CC Otavio Salvador <[email protected]>
---
 .../chromium-29.0.1518.2/armv6/include.gypi        |  8 ++
 .../chromium-29.0.1518.2/armv6/oe-defaults.gypi    | 15 ++++
 .../chromium-29.0.1518.2/armv7a/include.gypi       |  9 +++
 .../chromium-29.0.1518.2/armv7a/oe-defaults.gypi   | 15 ++++
 .../chromium-29.0.1518.2/i586/include.gypi         |  5 ++
 .../chromium-29.0.1518.2/i586/oe-defaults.gypi     | 15 ++++
 .../uninitialised-warning.patch                    | 90 ++++++++++++++++++++++
 .../chromium/chromium-29.0.1518.2/unistd-2.patch   | 27 +++++++
 .../chromium-29.0.1518.2/x86-64/include.gypi       |  5 ++
 .../chromium-29.0.1518.2/x86-64/oe-defaults.gypi   | 15 ++++
 recipes-browser/chromium/chromium_29.0.1518.2.bb   | 72 +++++++++++++++++
 11 files changed, 276 insertions(+)
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv6/include.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv6/oe-defaults.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv7a/include.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv7a/oe-defaults.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/i586/include.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/i586/oe-defaults.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/uninitialised-warning.patch
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/unistd-2.patch
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/x86-64/include.gypi
 create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/x86-64/oe-defaults.gypi
 create mode 100644 recipes-browser/chromium/chromium_29.0.1518.2.bb
recipes-browser/chromium/chromium-29.0.1518.2/armv6/include.gypi new file +8 -0
new file mode 100644
index 0000000..2c88271
@@ -0,0 +1,8 @@
+{
+  'variables': {
+    # Configure for armv6 compilation
+    'target_arch': 'arm',
+    'armv7': 0,
+    'arm_neon': 0,
+  }
+}
recipes-browser/chromium/chromium-29.0.1518.2/armv6/oe-defaults.gypi new file +15 -0
new file mode 100644
index 0000000..27e1cfe
@@ -0,0 +1,15 @@
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 1,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 0,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0
+  }, 
+}
recipes-browser/chromium/chromium-29.0.1518.2/armv7a/include.gypi new file +9 -0
new file mode 100644
index 0000000..316cf48
@@ -0,0 +1,9 @@
+{
+  'variables': {
+    # Configure for armv7 compilation
+    'target_arch': 'arm',
+    'armv7': 1,
+    'arm_thumb': 1,
+    'arm_neon': 1,
+  }, 
+}
recipes-browser/chromium/chromium-29.0.1518.2/armv7a/oe-defaults.gypi new file +15 -0
new file mode 100644
index 0000000..27e1cfe
@@ -0,0 +1,15 @@
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 1,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 0,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0
+  }, 
+}
recipes-browser/chromium/chromium-29.0.1518.2/i586/include.gypi new file +5 -0
new file mode 100644
index 0000000..69f3a08
@@ -0,0 +1,5 @@
+{
+  'variables': {
+    'target_arch': 'ia32',
+  }
+}
recipes-browser/chromium/chromium-29.0.1518.2/i586/oe-defaults.gypi new file +15 -0
new file mode 100644
index 0000000..0a6e8e8
@@ -0,0 +1,15 @@
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 0,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 1,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0,
+  }, 
+}
recipes-browser/chromium/chromium-29.0.1518.2/uninitialised-warning.patch new file +90 -0

90 lines not on this page · raw message

recipes-browser/chromium/chromium-29.0.1518.2/unistd-2.patch new file +27 -0
new file mode 100644
index 0000000..6b5018b
@@ -0,0 +1,27 @@
+diff --git a/chrome/browser/memory_details_linux.cc b/chrome/browser/memory_details_linux.cc
+index bee24ce..299f237 100644
+--- a/chrome/browser/memory_details_linux.cc
++++ b/chrome/browser/memory_details_linux.cc
+@@ -7,6 +7,10 @@
+ #include <map>
+ #include <set>
+ 
++#if defined(OS_POSIX)
++#include <unistd.h>
++#endif
++
+ #include "base/bind.h"
+ #include "base/process_util.h"
+ #include "base/string_util.h"
+diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
+index 14c375b..345f9eb 100644
+--- a/ipc/ipc_channel.h
++++ b/ipc/ipc_channel.h
+@@ -10,6 +10,7 @@
+ 
+ #if defined(OS_POSIX)
+ #include <sys/types.h>
++#include <unistd.h>
+ #endif
+ 
+ #include "base/compiler_specific.h"
recipes-browser/chromium/chromium-29.0.1518.2/x86-64/include.gypi new file +5 -0
new file mode 100644
index 0000000..c2e2a7d
@@ -0,0 +1,5 @@
+{
+  'variables': {
+    'target_arch': 'x64',
+  }
+}
recipes-browser/chromium/chromium-29.0.1518.2/x86-64/oe-defaults.gypi new file +15 -0
new file mode 100644
index 0000000..0a6e8e8
@@ -0,0 +1,15 @@
+{
+  'variables': {
+    'use_system_bzip2': 1,
+    'disable_nacl': 1,
+    'proprietary_codecs': 0,
+    'v8_use_snapshot': 1,
+    'use_system_ffmpeg': 0,
+    'linux_use_tcmalloc': 1,
+    'linux_link_kerberos': 0,
+    'use_kerberos': 0,
+    'use_cups': 0,
+    'use_gnome_keyring': 0,
+    'linux_link_gnome_keyring': 0,
+  }, 
+}
recipes-browser/chromium/chromium_29.0.1518.2.bb new file +72 -0

72 lines not on this page · raw message

Signature · 1 line
1.8.1.2
#2 lore raw

Re: [meta-browser][PATCH 2/2] chromium: Add recipes for 29.0.1518

Quoted 5 lines · Khem Raj
CC Eric Bénard <[email protected]>
CC Denis Carikli <[email protected]>
CC Otavio Salvador <[email protected]>
Quoted 13 lines
---
 .../chromium-29.0.1518.2/armv6/include.gypi        |  8 ++
 .../chromium-29.0.1518.2/armv6/oe-defaults.gypi    | 15 ++++
 .../chromium-29.0.1518.2/armv7a/include.gypi       |  9 +++
 .../chromium-29.0.1518.2/armv7a/oe-defaults.gypi   | 15 ++++
 .../chromium-29.0.1518.2/i586/include.gypi         |  5 ++
 .../chromium-29.0.1518.2/i586/oe-defaults.gypi     | 15 ++++
 .../uninitialised-warning.patch                    | 90 ++++++++++++++++++++++
 .../chromium/chromium-29.0.1518.2/unistd-2.patch   | 27 +++++++
 .../chromium-29.0.1518.2/x86-64/include.gypi       |  5 ++
 .../chromium-29.0.1518.2/x86-64/oe-defaults.gypi   | 15 ++++
 recipes-browser/chromium/chromium_29.0.1518.2.bb   | 72 +++++++++++++++++
 11 files changed, 276 insertions(+)

both pushed to master.

Thanks
Eric

#3 lore raw

Re: [meta-browser][PATCH 2/2] chromium: Add recipes for 29.0.1518

In reply to Khem Raj
Quoted 18 lines · Khem Raj
CC Eric Bénard <[email protected]>
CC Denis Carikli <[email protected]>
CC Otavio Salvador <[email protected]>
---
  .../chromium-29.0.1518.2/armv6/include.gypi        |  8 ++
  .../chromium-29.0.1518.2/armv6/oe-defaults.gypi    | 15 ++++
  .../chromium-29.0.1518.2/armv7a/include.gypi       |  9 +++
  .../chromium-29.0.1518.2/armv7a/oe-defaults.gypi   | 15 ++++
  .../chromium-29.0.1518.2/i586/include.gypi         |  5 ++
  .../chromium-29.0.1518.2/i586/oe-defaults.gypi     | 15 ++++
  .../uninitialised-warning.patch                    | 90 ++++++++++++++++++++++
  .../chromium/chromium-29.0.1518.2/unistd-2.patch   | 27 +++++++
  .../chromium-29.0.1518.2/x86-64/include.gypi       |  5 ++
  .../chromium-29.0.1518.2/x86-64/oe-defaults.gypi   | 15 ++++
  recipes-browser/chromium/chromium_29.0.1518.2.bb   | 72 +++++++++++++++++
  11 files changed, 276 insertions(+)
Quoted 11 lines

create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv6/include.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv6/oe-defaults.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv7a/include.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/armv7a/oe-defaults.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/i586/include.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/i586/oe-defaults.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/uninitialised-warning.patch create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/unistd-2.patch create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/x86-64/include.gypi create mode 100644 recipes-browser/chromium/chromium-29.0.1518.2/x86-64/oe-defaults.gypi create mode 100644 recipes-browser/chromium/chromium_29.0.1518.2.bb

... snip

Have you tried this? I just built it for my ARMv7a (i.MX6Q SabreLite) and it seems to hang up on any page that uses JavaScript. Try most any of the links on the "Chrome Help" page.

Maybe I'm missing something?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#4 lore raw

Re: [meta-browser][PATCH 2/2] chromium: Add recipes for 29.0.1518

Hi Gary,

Quoted 6 lines · Gary Thomas

Have you tried this? I just built it for my ARMv7a (i.MX6Q SabreLite) and it seems to hang up on any page that uses JavaScript. Try most any of the links on the "Chrome Help" page.

Maybe I'm missing something?

can you try to change

    'v8_use_snapshot': 1,

to

    'v8_use_snapshot': 0,

in oe-defaults.gypi ?

Eric

#5 lore raw

Re: [meta-browser][PATCH 2/2] chromium: Add recipes for 29.0.1518

Quoted 10 lines · Eric Bénard

Hi Gary,

Quoted 6 lines · Gary Thomas

Have you tried this? I just built it for my ARMv7a (i.MX6Q SabreLite) and it seems to hang up on any page that uses JavaScript. Try most any of the links on the "Chrome Help" page.

Maybe I'm missing something?

Quoted 8 lines

can you try to change

    'v8_use_snapshot': 1,

to

    'v8_use_snapshot': 0,

in oe-defaults.gypi ?

and was 24.0.1312.52 working on the i.MX6 ?

Eric

#6 lore raw

Re: [meta-browser][PATCH 2/2] chromium: Add recipes for 29.0.1518

In reply to Eric Bénard
Quoted 10 lines · Eric Bénard

Hi Gary,

Quoted 6 lines · Gary Thomas

Have you tried this? I just built it for my ARMv7a (i.MX6Q SabreLite) and it seems to hang up on any page that uses JavaScript. Try most any of the links on the "Chrome Help" page.

Maybe I'm missing something?

Quoted 7 lines

can you try to change

     'v8_use_snapshot': 1,

to

     'v8_use_snapshot': 0,

in oe-defaults.gypi ?

It looks like I was mistaken about this - it does seem to work (but wasn't immediately obvious to me). Sorry for the noise.

Note: I have tested it with both settings of v8_use_snapshot and they seem to behave the same.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------