serial: imx: Let device core handle pinctrl
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 serial: imx: Let device core handle pinctrl
From: Fabio Estevam <[email protected]>
Since commit ab78029 (drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl, so remove devm_pinctrl_get_select_default() from the driver.
--- drivers/tty/serial/imx.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/tty/serial/imx.c +0 -9
@@ -47,7 +47,6 @@#include <linux/slab.h> #include <linux/of.h> #include <linux/of_device.h> -#include <linux/pinctrl/consumer.h> #include <linux/io.h> #include <asm/irq.h>
@@ -1481,7 +1480,6 @@ static int serial_imx_probe(struct platform_device *pdev)void __iomem *base;int ret =0 ;struct resource *res; -struct pinctrl *pinctrl; sport =devm_kzalloc (&pdev->dev,sizeof (*sport),GFP_KERNEL );if (!sport)
@@ -1517,13 +1515,6 @@ static int serial_imx_probe(struct platform_device *pdev) sport->timer.function = imx_timeout; sport->timer.data = (unsigned long )sport; - pinctrl =devm_pinctrl_get_select_default (&pdev->dev); -if (IS_ERR (pinctrl)) { - ret =PTR_ERR (pinctrl); -dev_err (&pdev->dev,"failed to get default pinctrl: %d\n" , ret); -return ret; - } - sport->clk_ipg =devm_clk_get (&pdev->dev,"ipg" );if (IS_ERR (sport->clk_ipg)) { ret =PTR_ERR (sport->clk_ipg);
Signature · 1 line
1.8.1.2
Fabio Estevam
reviewerPATCH 2/2 serial: mxs-auart: Let device core handle pinctrl
From: Fabio Estevam <[email protected]>
Since commit ab78029 (drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl, so remove devm_pinctrl_get_select_default() from the driver.
--- drivers/tty/serial/mxs-auart.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/tty/serial/mxs-auart.c +0 -8
@@ -32,7 +32,6 @@#include <linux/clk.h> #include <linux/delay.h> #include <linux/io.h> -#include <linux/pinctrl/consumer.h> #include <linux/of_device.h> #include <linux/dma-mapping.h> #include <linux/dmaengine.h>
@@ -1015,7 +1014,6 @@ static int mxs_auart_probe(struct platform_device *pdev)u32 version;int ret =0 ;struct resource *r; -struct pinctrl *pinctrl; s =kzalloc (sizeof (struct mxs_auart_port ),GFP_KERNEL );if (!s) {
@@ -1029,12 +1027,6 @@ static int mxs_auart_probe(struct platform_device *pdev)else if (ret <0 ) goto out_free; - pinctrl =devm_pinctrl_get_select_default (&pdev->dev); -if (IS_ERR (pinctrl)) { - ret =PTR_ERR (pinctrl); - goto out_free; - } -if (of_id) { pdev->id_entry = of_id->data; s->devtype = pdev->id_entry->driver_data;
Signature · 1 line
1.8.1.2
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit ab78029 (
drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl, so removedevm_pinctrl_get_select_default()from the driver.Signed-off-by Fabio Estevam <[email protected]>
Both,