Skip to contentSkip to conversation

perf tools: fix a wrong header file path in util/unwind.c

PATCH In review Runzhen Wang 1 participant 2 messages May 27, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tools: fix a wrong header file path in util/unwind.c

For the latest perf core tree:
(git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git),
in util/unwind.c line 29 includes "perf_regs.h". That means compiler will search for this header file in current directory, so, gcc will puts the following error messages:

util/unwind.c: In function ‘access_mem’:
util/unwind.c:400:50: error: ‘PERF_REG_SP’ undeclared (first use in this function)
util/unwind.c:400:50: note: each undeclared identifier is reported only once for each function it appears in
util/unwind.c: In function ‘unwind__get_entries’:
util/unwind.c:562:41: error: ‘PERF_REG_IP’ undeclared (first use in this function)

Changing #include "perf_regs.h" to #include <perf_regs.h> will fix the error.

---
 tools/perf/util/unwind.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/unwind.c +1 -1
index 958723b..50e14f7 100644
@@ -26,7 +26,7 @@
 #include <libunwind-ptrace.h>
 #include "thread.h"
 #include "session.h"
-#include "perf_regs.h"
+#include <perf_regs.h>
 #include "unwind.h"
 #include "util.h"
 
Signature · 1 line
1.7.9.5
#1 lore raw

Sorry, I made a mistake.....
There is no bug, please ignore my patch.
Sorry again. I will be careful next time.

Quoted 39 lines · Runzhen Wang

For the latest perf core tree:
(git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git),
in util/unwind.c line 29 includes "perf_regs.h". That means compiler will search for this header file in current directory, so, gcc will puts the following error messages:

util/unwind.c: In function ‘access_mem’:
util/unwind.c:400:50: error: ‘PERF_REG_SP’ undeclared (first use in this function)
util/unwind.c:400:50: note: each undeclared identifier is reported only once for each function it appears in
util/unwind.c: In function ‘unwind__get_entries’:
util/unwind.c:562:41: error: ‘PERF_REG_IP’ undeclared (first use in this function)

Changing #include "perf_regs.h" to #include <perf_regs.h> will fix the error.

---
 tools/perf/util/unwind.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/unwind.c +1 -2
index 958723b..50e14f7 100644
@@ -26,7 +26,7 @@
 #include <libunwind-ptrace.h>
 #include "thread.h"
 #include "session.h"
-#include "perf_regs.h"
+#include <perf_regs.h>
 #include "unwind.h"
 #include "util.h"
 
--

1.7.9.5