Skip to contentSkip to conversation

bonding: remove ifenslave.c from kernel source

PATCH In review Cong Wang 3 participants 3 messages May 28, 2013

Subsystems (3)
lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH 1/1 bonding: remove ifenslave.c from kernel source

From: Cong Wang <[email protected]>

As Stephen proposed:
Since bonding supports configuration via iproute (netlink) and sysfs, I think it is time to purge the old ifenslave code out of Documentation/networking and update the documentation.

Cc Stephen Hemminger <[email protected]>
Cc Jay Vosburgh <[email protected]>
Cc "David S. Miller" <[email protected]>

---

Documentation/networking/.gitignore +0 -1
index 286a568..e69de29 100644
@@ -1 +0,0 @@
-ifenslave
Documentation/networking/00-INDEX +0 -2
index 258d9b9..32dfbd9 100644
@@ -88,8 +88,6 @@ gianfar.txt
 	- Gianfar Ethernet Driver.
 ieee802154.txt
 	- Linux IEEE 802.15.4 implementation, API and drivers
-ifenslave.c
-	- Configure network interfaces for parallel routing (bonding).
 igb.txt
 	- README for the Intel Gigabit Ethernet Driver (igb).
 igbvf.txt
Documentation/networking/Makefile +0 -5
index 24c308d..0aa1ac9 100644
@@ -1,11 +1,6 @@
 # kbuild trick to avoid linker error. Can be omitted if a module is built.
 obj- := dummy.o
 
-# List of programs to build
-hostprogs-y := ifenslave
-
-HOSTCFLAGS_ifenslave.o += -I$(objtree)/usr/include
-
 # Tell kbuild to always build the programs
 always := $(hostprogs-y)
 
Documentation/networking/bonding.txt +10 -44

93 lines not on this page · raw message

Documentation/networking/ifenslave.c deleted +0 -1105

1,105 lines not on this page · raw message

#1 lore raw
Quoted 12 lines · Cong Wang

From: Cong Wang <[email protected]>

As Stephen proposed:
Since bonding supports configuration via iproute (netlink) and sysfs, I think it is time to purge the old ifenslave code out of Documentation/networking and update the documentation.

Cc Stephen Hemminger <[email protected]>
Cc Jay Vosburgh <[email protected]>
Cc "David S. Miller" <[email protected]>

...

Documentation/networking/bonding.txt reboots, edit the appropriate file (/etc/init.d/boot.local or · line 1153

Quoted 8 lines
Documentation/networking/bonding.txt +2 -2
@@ -1183,8 +1149,8 @@ reboots, edit the appropriate file (/etc/init.d/boot.local or
 modprobe bonding mode=balance-alb miimon=100
 modprobe e100
 ifconfig bond0 192.168.1.1 netmask 255.255.255.0 up
-ifenslave bond0 eth0
-ifenslave bond0 eth1
+ip link set eth0 master bond0
+ip link set eth1 master bond0

While cleaning up, we might replace the ifconfig here with ip as well.

Michal Kubecek

maintainer
#2 lore raw
In reply to Cong Wang

From: Cong Wang <[email protected]>
Date: Tue, 28 May 2013 09:49:16 +0800

Quoted 7 lines

From: Cong Wang <[email protected]>

As Stephen proposed:
Since bonding supports configuration via iproute (netlink) and sysfs, I think it is time to purge the old ifenslave code out of Documentation/networking and update the documentation.

Quoted 5 lines
Cc Stephen Hemminger <[email protected]>
Cc Jay Vosburgh <[email protected]>
Cc "David S. Miller" <[email protected]>

Yep, time to let this one go, applied, thanks!