vxlan: remove the unused rcu head from struct vxlan_rdst
Subsystems (2)
PATCH 1/3 vxlan: remove the unused rcu head from struct vxlan_rdst
From: Cong Wang <[email protected]>
--- drivers/net/vxlan.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/vxlan.c +0 -1
@@ -97,7 +97,6 @@ struct vxlan_net { };struct vxlan_rdst { -struct rcu_head rcu;__be32 remote_ip;__be16 remote_port;u32 remote_vni;
Signature · 1 line
1.7.7.6
PATCH 2/3 vxlan: use unsigned int instead of unsigned
From: Cong Wang <[email protected]>
'unsigned int' is slightly better.
--- drivers/net/vxlan.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/vxlan.c +4 -4
@@ -1269,7 +1269,7 @@ static int vxlan_open(struct net_device *dev)/* Purge the forwarding table */ static void vxlan_flush (struct vxlan_dev *vxlan) { -unsigned h; +unsigned int h;spin_lock_bh (&vxlan->hash_lock);for (h =0 ; h <FDB_HASH_SIZE ; ++h) {
@@ -1333,7 +1333,7 @@ static void vxlan_free(struct net_device *dev)static void vxlan_setup (struct net_device *dev) {struct vxlan_dev *vxlan =netdev_priv (dev); -unsigned h; +unsigned int h;int low, high;eth_hw_addr_random (dev);
@@ -1459,7 +1459,7 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, __be16 port) .sin_addr.s_addr = htonl(INADDR_ANY), };int rc; -unsigned h; +unsigned int h; vs =kmalloc (sizeof (*vs),GFP_KERNEL );if (!vs)
@@ -1722,7 +1722,7 @@ static struct rtnl_link_ops vxlan_link_ops __read_mostly = {static __net_init int vxlan_init_net (struct net *net) {struct vxlan_net *vn =net_generic (net, vxlan_net_id); -unsigned h; +unsigned int h;INIT_LIST_HEAD (&vn->vxlan_list);
Signature · 1 line
1.7.7.6
Re: [Patch net-next 2/3] vxlan: use unsigned int instead of unsigned
From: Cong Wang <[email protected]>
Date: Tue, 28 May 2013 16:35:52 +0800
Quoted 7 lines
From: Cong Wang <[email protected]>
'unsigned int' is slightly better.
Cc Stephen Hemminger <[email protected]>Cc David S. Miller <[email protected]>Signed-off-by Cong Wang <[email protected]>
Applied.
PATCH 3/3 vxlan: defer vxlan init as late as possible
In reply to Cong WangFrom: Cong Wang <[email protected]>
When vxlan is compiled as builtin, its init code runs before IPv6 init, this could cause problems if we create IPv6 socket in the latter patch.
--- drivers/net/vxlan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/vxlan.c +1 -1
@@ -1771,7 +1771,7 @@ out2: out1:return rc; } -module_init (vxlan_init_module); +late_initcall (vxlan_init_module); static void __exit vxlan_cleanup_module(void) {
Signature · 1 line
1.7.7.6
Re: [Patch net-next 3/3] vxlan: defer vxlan init as late as possible
From: Cong Wang <[email protected]>
Date: Tue, 28 May 2013 16:35:53 +0800
Quoted 9 lines
From: Cong Wang <[email protected]>
When vxlan is compiled as builtin, its init code runs before IPv6 init, this could cause problems if we create IPv6 socket in the latter patch.
Cc Stephen Hemminger <[email protected]>Cc David S. Miller <[email protected]>Signed-off-by Cong Wang <[email protected]>
Applied.
Quoted 14 lines · On Tue, 28 May 2013 16:35:51 +0800 Cong Wang <[email protected]> wrote:
From: Cong Wang <[email protected]>
Cc Stephen Hemminger <[email protected]>Cc David S. Miller <[email protected]>Signed-off-by Cong Wang <[email protected]>--- drivers/net/vxlan.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/net/vxlan.c +0
-0
drivers/net/vxlan.c struct vxlan_net { · line 102
Quoted 7 lines
drivers/net/vxlan.c +0
-1@@ -97,7 +97,6 @@ struct vxlan_net { };struct vxlan_rdst { -struct rcu_head rcu;__be32 remote_ip;__be16 remote_port;u32 remote_vni;
Correct, rdst is freed with fdb and that is already in RCU call back
From: Cong Wang <[email protected]>
Date: Tue, 28 May 2013 16:35:51 +0800
Quoted 5 lines
From: Cong Wang <[email protected]>
Cc Stephen Hemminger <[email protected]>Cc David S. Miller <[email protected]>Signed-off-by Cong Wang <[email protected]>
Applied.