Skip to contentSkip to conversation

thermal: rcar: set up I/O base before requesting IRQ

PATCH In review Ulrich Hecht 2 participants 4 messages May 29, 2013 – Jun 4, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal: rcar: set up I/O base before requesting IRQ

It is used by the interrupt handler. Fixes crash when booting via kexec on APE6 board.

---
 drivers/thermal/rcar_thermal.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/thermal/rcar_thermal.c +7 -7
index 8d7edd4..7641dcc 100644
@@ -395,13 +395,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
 			return -ENODEV;
 		}
 
-		ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
-				       dev_name(dev), common);
-		if (ret) {
-			dev_err(dev, "irq request failed\n ");
-			return ret;
-		}
-
 		/*
 		 * rcar_has_irq_support() will be enabled
 		 */
@@ -409,6 +402,13 @@ static int rcar_thermal_probe(struct platform_device *pdev)
 		if (IS_ERR(common->base))
 			return PTR_ERR(common->base);
 
+		ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
+				       dev_name(dev), common);
+		if (ret) {
+			dev_err(dev, "irq request failed\n ");
+			return ret;
+		}
+
 		/* enable temperature comparation */
 		rcar_thermal_common_write(common, ENR, 0x00030303);
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 5 lines · Ulrich Hecht

It is used by the interrupt handler. Fixes crash when booting via kexec on APE6 board.

Hi Ulrich,

could you clarify the target of this fix?
Is it for next and thus v3.11 or is it applicable to v3.10. In the case of the latter is it also applicable to earlier kernel versions and thus relevant to -stable.

Thanks

Quoted 44 lines
---
 drivers/thermal/rcar_thermal.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/thermal/rcar_thermal.c +7 -7
index 8d7edd4..7641dcc 100644
@@ -395,13 +395,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
 			return -ENODEV;
 		}
 
-		ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
-				       dev_name(dev), common);
-		if (ret) {
-			dev_err(dev, "irq request failed\n ");
-			return ret;
-		}
-
 		/*
 		 * rcar_has_irq_support() will be enabled
 		 */
@@ -409,6 +402,13 @@ static int rcar_thermal_probe(struct platform_device *pdev)
 		if (IS_ERR(common->base))
 			return PTR_ERR(common->base);
 
+		ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
+				       dev_name(dev), common);
+		if (ret) {
+			dev_err(dev, "irq request failed\n ");
+			return ret;
+		}
+
 		/* enable temperature comparation */
 		rcar_thermal_common_write(common, ENR, 0x00030303);
 
Signature · 6 lines
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Ulrich Hecht
Quoted 8 lines · Simon Horman
Quoted 2 lines · Ulrich Hecht

It is used by the interrupt handler. Fixes crash when booting via kexec on APE6 board.

could you clarify the target of this fix?
Is it for next and thus v3.11 or is it applicable to v3.10. In the case of the latter is it also applicable to earlier kernel versions and thus relevant to -stable.

The bug has been introduced by commit e0a5172 (thermal: rcar: add interrupt support), between v3.8-rc2 and v3.9-rc1.

CU
Uli

#3 lore raw
In reply to Ulrich Hecht
Quoted 5 lines · Ulrich Hecht
Quoted 4 lines · Simon Horman
Quoted 2 lines · Ulrich Hecht

It is used by the interrupt handler. Fixes crash when booting via kexec on APE6 board.

Quoted 7 lines
Quoted 4 lines

could you clarify the target of this fix?
Is it for next and thus v3.11 or is it applicable to v3.10. In the case of the latter is it also applicable to earlier kernel versions and thus relevant to -stable.

The bug has been introduced by commit e0a5172 (thermal: rcar: add interrupt support), between v3.8-rc2 and v3.9-rc1.

Thanks and sorry for the delay, I have been travelling.

I have reposed this patch with an updated changelog, including the information above, with the hope that Zhang Rui will pick up the change for v3.10.