Skip to contentSkip to conversation

usb: musb: fix clock naming

PATCH Superseded yegorslists at googlemail.com 3 participants 6 messages May 28, 2013 – May 29, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usb: musb: fix clock naming

From: Yegor Yefremov <[email protected]>

'ick' was changed to 'hsotgusb_ick'
'fck' was changed to 'hsotgusb_fck'

---
v2: CC linux-usb mailing list

 drivers/usb/musb/am35x.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/musb/am35x.c +2 -2
index 2231850..92b5b23 100644
@@ -477,14 +477,14 @@ static int am35x_probe(struct platform_device *pdev)
 		goto err1;
 	}
 
-	phy_clk = clk_get(&pdev->dev, "fck");
+	phy_clk = clk_get(&pdev->dev, "hsotgusb_ick");
 	if (IS_ERR(phy_clk)) {
 		dev_err(&pdev->dev, "failed to get PHY clock\n");
 		ret = PTR_ERR(phy_clk);
 		goto err3;
 	}
 
-	clk = clk_get(&pdev->dev, "ick");
+	clk = clk_get(&pdev->dev, "hsotgusb_fck");
 	if (IS_ERR(clk)) {
 		dev_err(&pdev->dev, "failed to get clock\n");
 		ret = PTR_ERR(clk);
Signature · 1 line
1.7.7
#1 lore raw

PATCH v2 1/1 usb: musb: fix clock naming

Quoted 7 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

'ick' was changed to 'hsotgusb_ick'
'fck' was changed to 'hsotgusb_fck'

NAK. Fix your clock data.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130528/2bcee7a7/attachment.sig>
#2 lore raw

PATCH v2 1/1 usb: musb: fix clock naming

Quoted 10 lines · Felipe Balbi
Quoted 7 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

'ick' was changed to 'hsotgusb_ick'
'fck' was changed to 'hsotgusb_fck'

NAK. Fix your clock data.

Yegor, I'm not sure how my signed-off-by got here. It seems that you picked the patch up from this thread:
http://marc.info/?l=linux-omap&m=134390141101734

Note that my mail contains no signed-off-by and the change is described as a work around.

Regards,
Jan

#3 lore raw

PATCH v2 1/1 usb: musb: fix clock naming

Quoted 10 lines · Jan L?bbe
Quoted 9 lines · Felipe Balbi
Quoted 7 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

'ick' was changed to 'hsotgusb_ick'
'fck' was changed to 'hsotgusb_fck'

Quoted 8 lines
Quoted 1 line

NAK. Fix your clock data.

Yegor, I'm not sure how my signed-off-by got here. It seems that you picked the patch up from this thread:
http://marc.info/?l=linux-omap&m=134390141101734

Note that my mail contains no signed-off-by and the change is described as a work around.

I'll remove your SoB, when I post the next version. I just added it, because you provided the fix. Will contact you next time first. Have you worked on this SoC lately? Any pending patches?

Yegor

#5 lore raw

PATCH v2 1/1 usb: musb: fix clock naming

Quoted 7 lines · Yegor Yefremov
Quoted 6 lines · Felipe Balbi
Quoted 5 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

'ick' was changed to 'hsotgusb_ick'
'fck' was changed to 'hsotgusb_fck'

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

NAK. Fix your clock data.

Do you mean here arch/arm/mach-omap2/cclock3xxx_data.c?

yes

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130529/e081ec5d/attachment.sig>