qt5: add mx5 and mx6 support

PATCH Superseded Eric Bénard 2 participants 10 messages May 29, 2013 – May 31, 2013 Arm i.MX and Layerscape

lore

Share & tools

lore

Eric Bénard

author

2013-05-29 18:04 UTC #0 lore raw

PATCH 1/1 qt5: add mx5 and mx6 support

- this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
- tested on i.MX51, i.MX53 and i.MX6Q

Signed-off-by Eric Bénard <[email protected]>

---
 conf/layer.conf                                |    2 +
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105 ++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp
 create mode 100644 recipes-qt/qt5/qtbase_5.0.2.bbappend

conf/layer.conf +2 -0

index c4b9cd1..2bdff7c 100644
@@ -4,6 +4,8 @@ BBPATH .= ":${LAYERDIR}"
 # We have a packages directory, add to BBFILES
 BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
             ${LAYERDIR}/recipes-*/*/*.bbappend"
+BBMASK_append = "${@base_contains('BBFILE_COLLECTIONS', 'qt5-layer', '' ,\
+           ' meta-fsl-arm/recipes-qt/qt5/*.bb meta-fsl-arm/recipes-qt/qt5/*.bbappend', d)}"
 
 BBFILE_COLLECTIONS += "fsl-arm"
 BBFILE_PATTERN_fsl-arm := "^${LAYERDIR}/"

recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp new file +105 -0

105 lines not on this page · raw message

recipes-qt/qt5/qtbase_5.0.2.bbappend new file +68 -0

68 lines not on this page · raw message

Signature · 1 line

1.7.10.4

Thinking more about it, I think we should put these inside a meta-qt5 directory so we know what will be 'included'. Otherwse we may need to pick every file depending on each layer and it might be difficult to understand what is in use and what is not.

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Eric Bénard

author

2013-05-31 14:16 UTC #2 lore raw

Quoted 16 lines · Otavio Salvador

Quoted 5 lines · Eric Bénard
- this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 4 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++

Quoted 7 lines

...
Thinking more about it, I think we should put these inside a meta-qt5 directory so we know what will be 'included'. Otherwse we may need to pick every file depending on each layer and it might be difficult to understand what is in use and what is not.

please apply as is and create a patch on top of it to achieve the organization you prefer.

Eric

Otavio Salvador

2013-05-31 15:00 UTC #3 lore raw

Quoted 23 lines · Eric Bénard

Quoted 16 lines · Otavio Salvador
Quoted 5 lines · Eric Bénard
- this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 4 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
Quoted 4 lines
...
Thinking more about it, I think we should put these inside a meta-qt5 directory so we know what will be 'included'. Otherwse we may need to

Quoted 8 lines

pick
Quoted 1 line
every file depending on each layer and it might be difficult to
understand
Quoted 2 lines
what is in use and what is not.
please apply as is and create a patch on top of it to achieve the organization you prefer.

No reason to apply one patch which we know that needs rework.

Do you agree with my argument?

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Eric Bénard

author

2013-05-31 15:02 UTC #4 lore raw

Quoted 30 lines · Otavio Salvador

Quoted 28 lines · Eric Bénard
Quoted 16 lines · Otavio Salvador
Quoted 5 lines · Eric Bénard
- this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 4 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
Quoted 4 lines
...
Thinking more about it, I think we should put these inside a meta-qt5 directory so we know what will be 'included'. Otherwse we may need to
pick
Quoted 1 line
every file depending on each layer and it might be difficult to
understand
Quoted 2 lines
what is in use and what is not.

Quoted 8 lines

Quoted 3 lines
please apply as is and create a patch on top of it to achieve the organization you prefer.
No reason to apply one patch which we know that needs rework.
Do you agree with my argument?

no ;-)

Eric

Otavio Salvador

2013-05-31 15:04 UTC #5 lore raw

Quoted 40 lines · Eric Bénard

Quoted 6 lines · Otavio Salvador
Quoted 4 lines · Eric Bénard
Quoted 1 line · Otavio Salvador
On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
- this allow to build qt5 with OpenGL ES support for i.MX5 and
i.MX6
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 3 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
+++++++++++++++
Quoted 15 lines
Quoted 14 lines
Quoted 6 lines
Quoted 1 line
...
Thinking more about it, I think we should put these inside a meta-qt5 directory so we know what will be 'included'. Otherwse we may need to
pick
Quoted 1 line
every file depending on each layer and it might be difficult to
understand
Quoted 2 lines
what is in use and what is not.
please apply as is and create a patch on top of it to achieve the organization you prefer.

Quoted 6 lines

Quoted 4 lines
No reason to apply one patch which we know that needs rework.
Do you agree with my argument?
no ;-)

Well; it would be easier if you could explain why. Do you mind to elaborate it a little more?

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Eric Bénard

author

2013-05-31 15:35 UTC #6 lore raw

Quoted 44 lines · Otavio Salvador

Quoted 42 lines · Eric Bénard
Quoted 6 lines · Otavio Salvador
Quoted 4 lines · Eric Bénard
Quoted 1 line · Otavio Salvador
On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
- this allow to build qt5 with OpenGL ES support for i.MX5 and
i.MX6
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 3 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
+++++++++++++++
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
...
Thinking more about it, I think we should put these inside a meta-qt5 directory so we know what will be 'included'. Otherwse we may need to
Quoted 8 lines
pick
Quoted 1 line
every file depending on each layer and it might be difficult to
understand
Quoted 2 lines
what is in use and what is not.
please apply as is and create a patch on top of it to achieve the organization you prefer.
No reason to apply one patch which we know that needs rework.

Quoted 8 lines

Quoted 4 lines
Quoted 2 lines
Do you agree with my argument?
no ;-)
Well; it would be easier if you could explain why. Do you mind to elaborate it a little more?

if the argument is "No reason to apply one patch which we know that needs rework" :
Changing the organization of the bbappend is not just a mater of editing the patch in a few minutes, it also means testing with and without meta-qt5 and that's very long (and I already did that for v1 when we discussed that initially).
2 days ago you told me that the RFC was fine, now you tell me that needs rework and as I don't have immediate time to rework it so if you want to change the organization or use Chris' way to add layers (which is very elegant) either create a patch to rework this one or rework the patch before applying or drop it for the moment and I may work again on that later (and in that case, please reply with the organization you want so that the work is done only one time).

if the argument is "it might be difficult to understand what is in use and what is not" :
as soon as you have automatic addition of sublayers you fall in a case where it's not easy to understand what is in use or not whatever is your directory organization.

Eric

Otavio Salvador

2013-05-31 16:23 UTC #7 lore raw

Quoted 59 lines · Eric Bénard

Quoted 6 lines · Otavio Salvador
Quoted 4 lines · Eric Bénard
Quoted 1 line · Otavio Salvador
On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <[email protected]>
Quoted 20 lines · wrote:
Quoted 20 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line · Otavio Salvador
On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
- this allow to build qt5 with OpenGL ES support for i.MX5 and
i.MX6
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 3 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
Quoted 6 lines
Quoted 6 lines
+++++++++++++++
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
...
Thinking more about it, I think we should put these inside a
meta-qt5
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
directory so we know what will be 'included'. Otherwse we may
need to
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
pick
Quoted 1 line
every file depending on each layer and it might be difficult to
understand
Quoted 2 lines
what is in use and what is not.
please apply as is and create a patch on top of it to achieve the organization you prefer.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
No reason to apply one patch which we know that needs rework.
Do you agree with my argument?
no ;-)
Well; it would be easier if you could explain why. Do you mind to
elaborate
Quoted 2 lines
it a little more?

Quoted 14 lines

if the argument is "No reason to apply one patch which we know that needs rework" :
Changing the organization of the bbappend is not just a mater of editing the patch in a few minutes, it also means testing with and without meta-qt5 and that's very long (and I already did that for v1 when we discussed that initially).
2 days ago you told me that the RFC was fine, now you tell me that needs rework and as I don't have immediate time to rework it so if you want to change the organization or use Chris' way to add layers (which is very elegant) either create a patch to rework this one or rework the patch before applying or drop it for the moment and I may work again on that later (and in that case, please reply with the organization you want so that the work is done only one time).

I asked you to send it as proper patch for review. I didn't noticed you have put the bbappend in same level as the other so when I noticed it I commented.

Quoted 6 lines

if the argument is "it might be difficult to understand what is in use and what is not" :
as soon as you have automatic addition of sublayers you fall in a case where it's not easy to understand what is in use or not whatever is your directory organization.

I'd put it as:

recipes-...
meta-qt5/recipes-qt/qt5/...

Or as Chris suggested:

recipes-...
qt5-layer/recipes-qt/qt5

Both ways looks good for me.

I will mark them as 'Changes requested' in patchwork.

Regards,

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Eric Bénard

author

2013-05-31 20:06 UTC #8 lore raw

Quoted 76 lines · Otavio Salvador

Quoted 59 lines · Eric Bénard
Quoted 6 lines · Otavio Salvador
Quoted 4 lines · Eric Bénard
Quoted 1 line · Otavio Salvador
On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <[email protected]>
Quoted 20 lines · wrote:
Quoted 20 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line · Otavio Salvador
On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
- this allow to build qt5 with OpenGL ES support for i.MX5 and
i.MX6
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 3 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
Quoted 6 lines
Quoted 6 lines
+++++++++++++++
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
...
Thinking more about it, I think we should put these inside a
meta-qt5
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
directory so we know what will be 'included'. Otherwse we may
need to
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
pick
Quoted 1 line
every file depending on each layer and it might be difficult to
understand
Quoted 2 lines
what is in use and what is not.
please apply as is and create a patch on top of it to achieve the organization you prefer.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
No reason to apply one patch which we know that needs rework.
Do you agree with my argument?
no ;-)
Well; it would be easier if you could explain why. Do you mind to
elaborate
Quoted 2 lines
it a little more?
Quoted 14 lines
if the argument is "No reason to apply one patch which we know that needs rework" :
Changing the organization of the bbappend is not just a mater of editing the patch in a few minutes, it also means testing with and without meta-qt5 and that's very long (and I already did that for v1 when we discussed that initially).
2 days ago you told me that the RFC was fine, now you tell me that needs rework and as I don't have immediate time to rework it so if you want to change the organization or use Chris' way to add layers (which is very elegant) either create a patch to rework this one or rework the patch before applying or drop it for the moment and I may work again on that later (and in that case, please reply with the organization you want so that the work is done only one time).

Quoted 3 lines

I asked you to send it as proper patch for review. I didn't noticed you have put the bbappend in same level as the other so when I noticed it I commented.

Otavio sometimes you push the pedantry very far : the difference between the initial patch and what you call the "proper patch" is that the "proper patch" doesn't have 3 letters (RFC) in the subject and now I understand that having "RFC" in the subject means you didn't review the patch.

Quoted 12 lines

Quoted 6 lines
if the argument is "it might be difficult to understand what is in use and what is not" :
as soon as you have automatic addition of sublayers you fall in a case where it's not easy to understand what is in use or not whatever is your directory organization.
I'd put it as:
recipes-...
meta-qt5/recipes-qt/qt5/...

Quoted 7 lines

Or as Chris suggested:
recipes-...
qt5-layer/recipes-qt/qt5
Both ways looks good for me.

please choose ONE way so that the next patch iteration get THE right one for you.

Quoted 2 lines

I will mark them as 'Changes requested' in patchwork.

perfect.

Eric

Otavio Salvador

2013-05-31 20:30 UTC #9 lore raw

Quoted 89 lines · Eric Bénard

Quoted 6 lines · Otavio Salvador
Quoted 4 lines · Eric Bénard
Quoted 1 line · Otavio Salvador
On Fri, May 31, 2013 at 12:02 PM, Eric Bénard <[email protected]>
Quoted 11 lines · wrote:
Quoted 11 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line · Otavio Salvador
On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <[email protected]>
Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line · Otavio Salvador
On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <
[email protected]>
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
- this allow to build qt5 with OpenGL ES support for i.MX5
and
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
i.MX6
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
- tested on i.MX51, i.MX53 and i.MX6Q
Signed-off-by Eric Bénard <[email protected]>
...
Quoted 3 lines
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
+++++++++++++++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
...
Thinking more about it, I think we should put these inside a
meta-qt5
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
directory so we know what will be 'included'. Otherwse we may
need to
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
pick
Quoted 1 line
every file depending on each layer and it might be difficult
to
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
understand
Quoted 2 lines
what is in use and what is not.
please apply as is and create a patch on top of it to achieve
the
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
organization you prefer.
No reason to apply one patch which we know that needs rework.
Do you agree with my argument?
no ;-)
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Well; it would be easier if you could explain why. Do you mind to
elaborate
Quoted 2 lines
it a little more?
if the argument is "No reason to apply one patch which we know that needs rework" :
Changing the organization of the bbappend is not just a mater of
editing
Quoted 12 lines
Quoted 11 lines
the patch in a few minutes, it also means testing with and without meta-qt5 and that's very long (and I already did that for v1 when we discussed that initially).
2 days ago you told me that the RFC was fine, now you tell me that needs rework and as I don't have immediate time to rework it so if you want to change the organization or use Chris' way to add layers (which is very elegant) either create a patch to rework this one or rework the patch before applying or drop it for the moment and I may work again on that later (and in that case, please reply with the organization you want so that the work is done only one time).
Quoted 3 lines
I asked you to send it as proper patch for review. I didn't noticed you have put the bbappend in same level as the other so when I noticed it I commented.

Quoted 6 lines

Otavio sometimes you push the pedantry very far : the difference between the initial patch and what you call the "proper patch" is that the "proper patch" doesn't have 3 letters (RFC) in the subject and now I understand that having "RFC" in the subject means you didn't review the patch.

Usually RFC patches are to discuss the concept not to receive a complete review. We did discuss it and it even allowed Chris to comment on it with a better way of solving the problem - which is what it is the real goal of it I think.

I didn't try the patch (I was under high volume of tests here for GPU patches) and once I managed to get it done I started to check for backlog in the mailing list (today) so I did look at it more carefully and found a issue which I didn't see at first look - which I also think is normal - as I can also make mistakes - so I don't think I was pedant but instead a careful maintainer.

Quoted 14 lines

Quoted 14 lines
if the argument is "it might be difficult to understand what is in use
Quoted 5 lines
and what is not" :
as soon as you have automatic addition of sublayers you fall in a case where it's not easy to understand what is in use or not whatever is your directory organization.
I'd put it as:
recipes-...
meta-qt5/recipes-qt/qt5/...
Or as Chris suggested:

Quoted 7 lines

Quoted 5 lines
recipes-...
qt5-layer/recipes-qt/qt5
Both ways looks good for me.
please choose ONE way so that the next patch iteration get THE right one for you.

Let's go with Chris proposal than; it avoids future rework in bblayers.conf I think.

So the way I see it, it could be done as:

* one patch adding the bblayers.conf change
* one for Qt5 additions

Regards,

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750