hicolor-icon-theme: keep inherited dependencies
PATCH 1/2 hicolor-icon-theme: keep inherited dependencies
else, if an image installs hicolor-icon-theme without any other gnome package, the dependency on gdk-pixbuf-native will be missing and if it exists, the host gdk-pixbuf-query-loaders binary will be used and it will try to update the host's cache
[YOCTO #4572]
---
this patch will need some testing as it's not clear to me why this dependency was forced to "". At least that fix the problem described in the bug report.
meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb | 2 -- 1 file changed, 2 deletions(-)
meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb +0 -2
@@ -8,8 +8,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=f08a446809913fc9b3c718f0eaea0426" SECTION = "unknown" inherit gnome allarch -DEPENDS = "" - PR = "r1" SRC_URI = "http://icon-theme.freedesktop.org/releases/${BPN}-${PV}.tar.gz \
Signature · 1 line
1.8.1.4
PATCH 2/2 gtk-icon-cache pixbufcache: add a clear dependency on gdk-pixbuf-native
not really sure if the dependency is always inherited but at least there won't be bad surprise.
--- meta/classes/gtk-icon-cache.bbclass | 2 +- meta/classes/pixbufcache.bbclass | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
meta/classes/gtk-icon-cache.bbclass +1 -1
@@ -1,6 +1,6 @@ FILES_${PN} += "${datadir}/icons/hicolor" -DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native" +DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native gdk-pixbuf-native" gtk_icon_cache_postinst() { if [ "x$D" != "x" ]; then
meta/classes/pixbufcache.bbclass +1 -1
@@ -3,7 +3,7 @@ # packages. # -DEPENDS += "qemu-native" +DEPENDS += "qemu-native gdk-pixbuf-native" inherit qemu PIXBUF_PACKAGES ??= "${PN}"
Signature · 1 line
1.8.1.4
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
Quoted 39 lines · Eric Bénard
else, if an image installs hicolor-icon-theme without any other gnome package, the dependency on gdk-pixbuf-native will be missing and if it exists, the host gdk-pixbuf-query-loaders binary will be used and it will try to update the host's cache
[YOCTO #4572]
Signed-off-by Eric Bénard <[email protected]>---
this patch will need some testing as it's not clear to me why this dependency was forced to "". At least that fix the problem described in the bug report.meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb | 2 -- 1 file changed, 2 deletions(-)(quoted diff) +0
-0hicolor-icon-theme_0.12.bb b/meta/recipes-gnome/hicolor-icon-theme/ hicolor-icon-theme_0.12.bb
index 7c911e0..8d48dec 100644meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb +0
-0@@ -8,8 +8,6 @@ LIC_FILES_CHKSUM ="file://COPYING;md5=f08a446809913fc9b3c718f0eaea0426"
SECTION = "unknown"
inherit gnome allarchmeta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb +0
-3-DEPENDS = "" - PR = "r1" SRC_URI = "http://icon-theme.freedesktop.org/releases/${BPN}-${PV}.tar.gz\ --1.8.1.4
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 2 lines · Martin Jansa
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
gnome.bbclass is an abomination and should be gutted. Yes, this will mean the build dependencies are massive, and I can't see why this recipe needs gnome.bbclass. Then again it doesn't need gtk-icon-cache either as it doesn't actually have any icons in. I'd be interested in seeing a buildhistory-diff between the current recipe and one with both inherit gnome and DEPENDS="" removed.
Ross
Quoted 11 lines · Ross
Quoted 2 lines · Martin Jansa
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
gnome.bbclass is an abomination and should be gutted. Yes, this will mean the build dependencies are massive, and I can't see why this recipe needs gnome.bbclass. Then again it doesn't need gtk-icon-cache either as it doesn't actually have any icons in. I'd be interested in seeing a buildhistory-diff between the current recipe and one with both inherit gnome and DEPENDS="" removed.
when removing gnome I get the following error at install :
DEBUG: Executing shell function do_install
install: cannot create regular file `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such file or directory
Eric
Hi Ross,
Quoted 14 lines · Eric Bénard
Quoted 11 lines · Ross
Quoted 2 lines · Martin Jansa
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
gnome.bbclass is an abomination and should be gutted. Yes, this will mean the build dependencies are massive, and I can't see why this recipe needs gnome.bbclass. Then again it doesn't need gtk-icon-cache either as it doesn't actually have any icons in. I'd be interested in seeing a buildhistory-diff between the current recipe and one with both inherit gnome and DEPENDS="" removed.
Quoted 7 lines
when removing gnome I get the following error at install :
DEBUG: Executing shell functiondo_install
install: cannot create regular file `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such file or directory
turning on the brain and fixing do_install, the diff between original et new (without gnome and DEPENDS="") is :
packages/all-oe-linux/hicolor-icon-theme/hicolor-icon-theme:pkg_postinst cleared:
packages/all-oe-linux/hicolor-icon-theme/hicolor-icon-theme: pkg_postrm cleared:
So that seems the right thing to do don't you think ?
Eric
Quoted 14 lines · Eric Bénard
Quoted 11 lines · Ross
Quoted 2 lines · Martin Jansa
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
gnome.bbclass is an abomination and should be gutted. Yes, this will mean the build dependencies are massive, and I can't see why this recipe needs gnome.bbclass. Then again it doesn't need gtk-icon-cache either as it doesn't actually have any icons in. I'd be interested in seeing a buildhistory-diff between the current recipe and one with both inherit gnome and DEPENDS="" removed.
Quoted 6 lines
when removing gnome I get the following error at install :
DEBUG: Executing shell functiondo_install
install: cannot create regular file `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such file or directory
I have a suspicion we really want a gnomebase inherit in the recipe instead of gnome and that might solve serveral issues in one.
Cheers,
Richard
Quoted 22 lines · Richard Purdie
Quoted 14 lines · Eric Bénard
Quoted 11 lines · Ross
Quoted 2 lines · Martin Jansa
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
gnome.bbclass is an abomination and should be gutted. Yes, this will mean the build dependencies are massive, and I can't see why this recipe needs gnome.bbclass. Then again it doesn't need gtk-icon-cache either as it doesn't actually have any icons in. I'd be interested in seeing a buildhistory-diff between the current recipe and one with both inherit gnome and DEPENDS=""DEPENDS="" removed.
Quoted 6 lines
when removing gnome I get the following error at install :
DEBUG: Executing shell functiondo_install
install: cannot create regular file `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such file or directory
Quoted 3 lines
I have a suspicion we really want a gnomebase inherit in the recipe instead of gnome and that might solve serveral issues in one.
inherit gnomebase and remove DEPENDS=""
seems to work fine (the postinst and postrm scripts are removed). removing DEPENDS="" is not a big issue as it only brings native packages :
DEPENDS = autoconf-native automake-native gnome-common-native gnu-config-native libtool-native pkgconfig-native
Eric
Quoted 9 lines · Eric Bénard
Quoted 3 lines
I have a suspicion we really want a gnomebase inherit in the recipe instead of gnome and that might solve serveral issues in one.
inherit gnomebase and remove DEPENDS=""
seems to work fine (the postinst and postrm scripts are removed). removing DEPENDS="" is not a big issue as it only brings native packages :
DEPENDS = autoconf-native automake-native gnome-common-native gnu-config-native libtool-native pkgconfig-native
Sounds fine, they actually are the build-dependencies.
Ross
Quoted 6 lines · Eric Bénard
inherit gnomebase and remove DEPENDS=""
seems to work fine (the postinst and postrm scripts are removed). removing DEPENDS="" is not a big issue as it only brings native packages :
DEPENDS = autoconf-native automake-native gnome-common-native gnu-config-native libtool-native pkgconfig-native
Will you send a patch for this?
Ross
Quoted 10 lines · Ross
Quoted 6 lines · Eric Bénard
inherit gnomebase and remove DEPENDS=""
seems to work fine (the postinst and postrm scripts are removed). removing DEPENDS="" is not a big issue as it only brings native packages :
DEPENDS = autoconf-native automake-native gnome-common-native gnu-config-native libtool-native pkgconfig-nativeWill you send a patch for this?
yes it's coming ;-)
Eric
Quoted 3 lines · Martin Jansa
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass brings gconf.
true :
* DEPENDS: added "shared-mime-info gnome-common-native
shared-mime-info-native gtk-update-icon-cache-native gconf gconf-native"
Eric