writeback: Fix periodic writeback after fs mount
Jan Kara
reviewerPATCH 1/1 writeback: Fix periodic writeback after fs mount
Code in blkdev.c moves a device inode to default_backing_dev_info when the last reference to the device is put and moves the device inode back to its bdi when the first reference is acquired. This includes moving to wb.b_dirty list if the device inode is dirty. The code however doesn't setup timer to wake corresponding flusher thread and while wb.b_dirty list is non-empty __mark_inode_dirty() will not set it up either. Thus periodic writeback is effectively disabled until a sync(2) call which can lead to unexpected data loss in case of crash or power failure.
Fix the problem by setting up a timer for periodic writeback in case we add the first dirty inode to wb.b_dirty list in bdev_inode_switch_bdi().
--- fs/block_dev.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
fs/block_dev.c +8 -1
@@ -58,17 +58,24 @@ static void bdev_inode_switch_bdi(struct inode *inode, struct backing_dev_info *dst) {struct backing_dev_info *old = inode->i_data.backing_dev_info; +bool wakeup_bdi = false;if (unlikely (dst == old))/* deadlock avoidance */ return ;bdi_lock_two (&old->wb, &dst->wb);spin_lock (&inode->i_lock); inode->i_data.backing_dev_info = dst; -if (inode->i_state &I_DIRTY ) +if (inode->i_state &I_DIRTY ) { +if (bdi_cap_writeback_dirty (dst) && !wb_has_dirty_io (&dst->wb)) + wakeup_bdi = true;list_move (&inode->i_wb_list, &dst->wb.b_dirty); + }spin_unlock (&inode->i_lock);spin_unlock (&old->wb.list_lock);spin_unlock (&dst->wb.list_lock); + +if (wakeup_bdi) +bdi_wakeup_thread_delayed (dst); }/* Kill _all_ buffers and pagecache , dirty or not.. */
Signature · 1 line
1.8.1.4
Jan Kara
reviewerQuoted 9 lines · Jan Kara
Code in
blkdev.cmoves a device inode todefault_backing_dev_infowhen the last reference to the device is put and moves the device inode back to its bdi when the first reference is acquired. This includes moving to wb.b_dirty list if the device inode is dirty. The code however doesn't setup timer to wake corresponding flusher thread and while wb.b_dirty list is non-empty__mark_inode_dirty()will not set it up either. Thus periodic writeback is effectively disabled until a sync(2) call which can lead to unexpected data loss in case of crash or power failure.
Quoted 6 lines
Fix the problem by setting up a timer for periodic writeback in case we add the first dirty inode to wb.b_dirty list in
bdev_inode_switch_bdi().Reported-by Bert De Jonghe <[email protected]>CC [email protected] # >= 3.0Signed-off-by Jan Kara <[email protected]>
Jens, I'm going over my submitted patches and I don't think you've merged
this patch. Did you?
Honza
Quoted 37 lines
--- fs/block_dev.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)fs/block_dev.c +8
-1@@ -58,17 +58,24 @@ static void bdev_inode_switch_bdi(struct inode *inode, struct backing_dev_info *dst) {struct backing_dev_info *old = inode->i_data.backing_dev_info; +bool wakeup_bdi = false;if (unlikely (dst == old))/* deadlock avoidance */ return ;bdi_lock_two (&old->wb, &dst->wb);spin_lock (&inode->i_lock); inode->i_data.backing_dev_info = dst; -if (inode->i_state &I_DIRTY ) +if (inode->i_state &I_DIRTY ) { +if (bdi_cap_writeback_dirty (dst) && !wb_has_dirty_io (&dst->wb)) + wakeup_bdi = true;list_move (&inode->i_wb_list, &dst->wb.b_dirty); + }spin_unlock (&inode->i_lock);spin_unlock (&old->wb.list_lock);spin_unlock (&dst->wb.list_lock); + +if (wakeup_bdi) +bdi_wakeup_thread_delayed (dst); }/* Kill _all_ buffers and pagecache , dirty or not.. */ Signature · 1 line
1.8.1.4
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 10 lines · Jan Kara
case of crash or power failure.
Quoted 7 lines
Fix the problem by setting up a timer for periodic writeback in case we add the first dirty inode to wb.b_dirty list in
bdev_inode_switch_bdi().Reported-by Bert De Jonghe <[email protected]>CC [email protected] # >= 3.0Signed-off-by Jan Kara <[email protected]>Jens, I'm going over my submitted patches and I don't think you've merged
this patch. Did you?
I did not... I've added it now for 3.11, with the stable tag it should get in the earlier ones too.
Signature · 1 line
Jens Axboe