Skip to contentSkip to conversation

qlcnic: remove redundant D0 power state set

PATCH In review Yijing Wang 2 participants 2 messages May 30, 2013 – May 31, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 6/7 qlcnic: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0, so it's no need to do it again in qlcnic_attach_func().

---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +0 -1
index aeb26a8..3585c2c 100644
@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev *pdev)
 	if (err)
 		return err;
 
-	pci_set_power_state(pdev, PCI_D0);
 	pci_set_master(pdev);
 	pci_restore_state(pdev);
 
Signature · 1 line
1.7.1
Acked-by on v1 6/7
#1 lore raw
Quoted 31 lines

-----Original Message-----
From: Yijing Wang [mailto:[email protected]]
Sent: Thursday, May 30, 2013 3:56 PM
To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko
Cc: linux-kernel; Dept-Eng Linux Driver; netdev; Hanjun Guo; Jiang Liu; Yijing Wang
Subject: [PATCH 6/7] qlcnic: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0, so it's no need to do it again in qlcnic_attach_func().

---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -

1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +0 -2
index aeb26a8..3585c2c 100644
@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev
 *pdev)
 	if (err)
 		return err;
 
-	pci_set_power_state(pdev, PCI_D0);
 	pci_set_master(pdev);
 	pci_restore_state(pdev);
 
--
Quoted 3 lines

1.7.1

Thanks!