tulip: remove redundant D0 power state set
Subsystems (3)
PATCH 7/7 tulip: remove redundant D0 power state set
Pci_enable_device() will set device power state to D0, so it's no need to do it again in tulip_init_one().
Signed-off-by Yijing Wang <[email protected]>
--- drivers/net/ethernet/dec/tulip/tulip_core.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/net/ethernet/dec/tulip/tulip_core.c +0 -6
@@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)return i; } -/* The chip will fail to enter a low-power state later unless -* first explicitly commanded into D0 */ -if (pci_set_power_state (pdev,PCI_D0 )) { -pr_notice ("Failed to set power state to D0\n" ); - } - irq = pdev->irq;/* alloc_etherdev ensures aligned and zeroed private structures */
Signature · 1 line
1.7.1
Quoted 4 lines · Yijing Wang
Pci_enable_device()will set device power state to D0, so it's no need to do it again intulip_init_one().Signed-off-by Yijing Wang <[email protected]>
thanks!
grant
Quoted 25 lines
--- drivers/net/ethernet/dec/tulip/tulip_core.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)drivers/net/ethernet/dec/tulip/tulip_core.c +0
-7@@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)return i; } -/* The chip will fail to enter a low-power state later unless -* first explicitly commanded into D0 */ -if (pci_set_power_state (pdev,PCI_D0 )) { -pr_notice ("Failed to set power state to D0\n" ); - } - irq = pdev->irq;/* alloc_etherdev ensures aligned and zeroed private structures */ --1.7.1
David Miller
maintainerFrom: Grant Grundler <[email protected]>
Date: Thu, 30 May 2013 08:31:38 -0700
Quoted 7 lines · Yijing Wang
Quoted 4 lines
Pci_enable_device()will set device power state to D0, so it's no need to do it again intulip_init_one().Signed-off-by Yijing Wang <[email protected]>
(it's Acked-by) Applied, thanks.