Skip to contentSkip to conversation

tulip: remove redundant D0 power state set

PATCH In review Yijing Wang 3 participants 3 messages May 30, 2013 – May 31, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 7/7 tulip: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0, so it's no need to do it again in tulip_init_one().

---
 drivers/net/ethernet/dec/tulip/tulip_core.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/net/ethernet/dec/tulip/tulip_core.c +0 -6
index 1e9443d..c94152f 100644
@@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		return i;
 	}
 
-	/* The chip will fail to enter a low-power state later unless
-	 * first explicitly commanded into D0 */
-	if (pci_set_power_state(pdev, PCI_D0)) {
-		pr_notice("Failed to set power state to D0\n");
-	}
-
 	irq = pdev->irq;
 
 	/* alloc_etherdev ensures aligned and zeroed private structures */
Signature · 1 line
1.7.1
#1 lore raw
Quoted 4 lines · Yijing Wang

Pci_enable_device() will set device power state to D0, so it's no need to do it again in tulip_init_one().

thanks!
grant

Quoted 25 lines
---
 drivers/net/ethernet/dec/tulip/tulip_core.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/net/ethernet/dec/tulip/tulip_core.c +0 -7
index 1e9443d..c94152f 100644
@@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
                return i;
        }
 
-       /* The chip will fail to enter a low-power state later unless
-        * first explicitly commanded into D0 */
-       if (pci_set_power_state(pdev, PCI_D0)) {
-               pr_notice("Failed to set power state to D0\n");
-       }
-
        irq = pdev->irq;
 
        /* alloc_etherdev ensures aligned and zeroed private structures */
--

1.7.1