webkit-efl: Fix build with gcc-4.8

PATCH In review Martin Jansa 2 participants 7 messages Jun 1, 2013 – Jun 27, 2013

Share & tools

Martin Jansa

author

2013-06-01 18:03 UTC #0 lore raw

PATCH 1/1 webkit-efl: Fix build with gcc-4.8

---
 ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
 meta-efl/recipes-efl/webkit/webkit-efl_svn.bb      |  3 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch

meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch new file +43 -0

new file mode 100644
index 0000000..f553663
@@ -0,0 +1,43 @@
+From 3de7c4633751c3e55152d4e2429dfcc0f69a1de3 Mon Sep 17 00:00:00 2001
+From: Martin Jansa <[email protected]>
+Date: Sat, 1 Jun 2013 19:23:54 +0200
+Subject: [PATCH] ewk: include Element.h for hasTagName function
+
+* ewebkit build fails like gtk in http://trac.webkit.org/changeset/72745
+  | ../../../lib/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::Node::hasTagName(WebCore::QualifiedName const&) const'
+  | collect2: error: ld returned 1 exit status
+  | make[2]: *** [bin/DumpRenderTree] Error 1
+
+Signed-off-by: Martin Jansa <[email protected]>
+---
+ Source/WebKit/efl/ewk/ewk_frame.cpp | 1 +
+ Source/WebKit/efl/ewk/ewk_view.cpp  | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/Source/WebKit/efl/ewk/ewk_frame.cpp b/Source/WebKit/efl/ewk/ewk_frame.cpp
+index fd1ffd2..c86601a 100644
+--- a/Source/WebKit/efl/ewk/ewk_frame.cpp
++++ b/Source/WebKit/efl/ewk/ewk_frame.cpp
+@@ -32,6 +32,7 @@
+ #include "FocusController.h"
+ #include "FrameLoaderClientEfl.h"
+ #include "FrameView.h"
++#include "Element.h"
+ #include "HTMLCollection.h"
+ #include "HTMLHeadElement.h"
+ #include "HTMLImageElement.h"
+diff --git a/Source/WebKit/efl/ewk/ewk_view.cpp b/Source/WebKit/efl/ewk/ewk_view.cpp
+index 9798e94..7a5da60 100644
+--- a/Source/WebKit/efl/ewk/ewk_view.cpp
++++ b/Source/WebKit/efl/ewk/ewk_view.cpp
+@@ -36,6 +36,7 @@
+ #include "FocusController.h"
+ #include "FrameLoaderClientEfl.h"
+ #include "FrameView.h"
++#include "Element.h"
+ #include "GraphicsContext.h"
+ #include "HTMLElement.h"
+ #include "HTMLInputElement.h"
+-- 
+1.8.2.1
+

meta-efl/recipes-efl/webkit/webkit-efl_svn.bb +2 -1

index be5a534..ce73431 100644
@@ -12,7 +12,7 @@ DEPENDS = "icu libxslt sqlite3 gperf-native bison-native flex-native jpeg \
 # 120145 and 122103 introduces dependency on libsoup-2.39.3 and glib-networking-2.33.2
 SRCREV = "120144"
 PV = "1.9.3+svnr${SRCPV}"
-PR = "r2"
+PR = "r3"
 
 SRCREV_FORMAT = "source"

@@ -22,6 +22,7 @@ SRC_URI = "\
     svn://svn.webkit.org/repository/webkit/trunk;module=Source;name=source;protocol=http;subdir=src \
     svn://svn.webkit.org/repository/webkit/trunk/;module=WebKitLibraries;protocol=http;subdir=src \
     svn://svn.webkit.org/repository/webkit/trunk/;module=Tools;protocol=http;subdir=src \
+    file://0001-ewk-include-Element.h-for-hasTagName-function.patch \
     file://CMakeLists.txt \
     file://bison-2.6.patch \
 "

Signature · 1 line

1.8.2.1

Martin Jansa

author

2013-06-02 08:09 UTC #1 lore raw

Quoted 5 lines · Martin Jansa

---
 ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
 meta-efl/recipes-efl/webkit/webkit-efl_svn.bb      |  3 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch

Ignore this one, it works on armv7a, but fails the same on armv4t and x86_64 + there is ICE when building for armv5te.

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Martin Jansa

author

2013-06-06 12:34 UTC #2 lore raw

Quoted 9 lines · Martin Jansa

Quoted 5 lines · Martin Jansa
---
 ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
 meta-efl/recipes-efl/webkit/webkit-efl_svn.bb      |  3 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
Ignore this one, it works on armv7a, but fails the same on armv4t and x86_64 + there is ICE when building for armv5te.

I've merged this in the end, because it fixed webkit-efl build on jenkins (and it looks like building from scratch works for other archs I'm building locally too).

Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it triggers ICE:

/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
}
^
(insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])

        (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
            (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
     (nil))

/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897 Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
{standard input}: Assembler messages:
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive

Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have recipes for it and report upstream if needed

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Khem Raj

2013-06-11 08:08 UTC #3 lore raw

Quoted 34 lines · Martin Jansa

Quoted 9 lines · Martin Jansa
Quoted 5 lines · Martin Jansa
---
 ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
 meta-efl/recipes-efl/webkit/webkit-efl_svn.bb      |  3 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
Ignore this one, it works on armv7a, but fails the same on armv4t and x86_64 + there is ICE when building for armv5te.
I've merged this in the end, because it fixed webkit-efl build on jenkins (and it looks like building from scratch works for other archs I'm building locally too).
Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it triggers ICE:
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
}
^
(insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
        (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
            (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
     (nil))
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897 Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
{standard input}: Assembler messages:
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive

Quoted 2 lines

Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have recipes for it and report upstream if needed

hmmm it needs to be reported. Can you generate preprocessed file and put it somewhere accessible

Quoted 9 lines

--
Martin 'JaMa' Jansa jabber: [email protected]
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Martin Jansa

author

2013-06-11 08:41 UTC #4 lore raw

Quoted 35 lines · Khem Raj

Quoted 34 lines · Martin Jansa
Quoted 9 lines · Martin Jansa
Quoted 5 lines · Martin Jansa
---
 ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
 meta-efl/recipes-efl/webkit/webkit-efl_svn.bb      |  3 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
Ignore this one, it works on armv7a, but fails the same on armv4t and x86_64 + there is ICE when building for armv5te.
I've merged this in the end, because it fixed webkit-efl build on jenkins (and it looks like building from scratch works for other archs I'm building locally too).
Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it triggers ICE:
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
}
^
(insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
        (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
            (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
     (nil))
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897 Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
{standard input}: Assembler messages:
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive

Quoted 5 lines

Quoted 2 lines
Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have recipes for it and report upstream if needed
hmmm it needs to be reported. Can you generate preprocessed file and put it somewhere accessible

I plan to, I just wanted to reproduce it with 4.8.1 and backported
http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00784.html to see if it wasn't fixed upstream already.

I guess we were all waiting for you to return from holidays and update gcc to 4.8.1 :).

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Khem Raj

2013-06-11 08:44 UTC #5 lore raw

Quoted 2 lines · Martin Jansa

I guess we were all waiting for you to return from holidays and update gcc to 4.8.1 :).

infact i do have 4.8.1 recipes cooking :)

Martin Jansa

author

2013-06-27 15:58 UTC #6 lore raw

In reply to Martin Jansa

Quoted 42 lines · Martin Jansa

Quoted 35 lines · Khem Raj
Quoted 34 lines · Martin Jansa
Quoted 9 lines · Martin Jansa
Quoted 5 lines · Martin Jansa
---
 ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
 meta-efl/recipes-efl/webkit/webkit-efl_svn.bb      |  3 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
Ignore this one, it works on armv7a, but fails the same on armv4t and x86_64 + there is ICE when building for armv5te.
I've merged this in the end, because it fixed webkit-efl build on jenkins (and it looks like building from scratch works for other archs I'm building locally too).
Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it triggers ICE:
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
}
^
(insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
        (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
            (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
     (nil))
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897 Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
{standard input}: Assembler messages:
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
Quoted 5 lines
Quoted 2 lines
Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have recipes for it and report upstream if needed
hmmm it needs to be reported. Can you generate preprocessed file and put it somewhere accessible

Quoted 6 lines

I plan to, I just wanted to reproduce it with 4.8.1 and backported
http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00784.html to see if it wasn't fixed upstream already.
I guess we were all waiting for you to return from holidays and update gcc to 4.8.1 :).

Done
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57735

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]