tegra2: Add paz00 support

RFC PATCH New Stephen Warren 4 participants 15 messages Nov 19, 2011 – Nov 28, 2011

lore

Share & tools

lore

Stephen Warren

author

2011-11-19 20:47 UTC #0 lore raw

cover tegra2: Add paz00 support

This patch series adds support for the Toshiba AC100 Tegra netbook.

I'm posting it as an RFC because:

a) The AC100 is designed by Compal and marketed by Toshiba. Should we put the files into board/nvidia (since it uses an NVIDIA SoC), or create a board/toshiba or board/compal directory to contain this?

b) It'll need rebasing on top of some of the many outstanding Tegra patches before it can be applied.

Stephen Warren (3):
MAINTAINERS: Fix my email address
tegra2: Fix conflicting pinmux for UARTA
tegra2: Add support for Paz00 (Toshiba AC100)

 MAINTAINERS                 |    3 +-
 board/nvidia/common/board.c |   12 ++++++
 board/nvidia/paz00/Makefile |   49 ++++++++++++++++++++++++
 board/nvidia/paz00/paz00.c  |   88 +++++++++++++++++++++++++++++++++++++++++++
 boards.cfg                  |    1 +
 include/configs/paz00.h     |   59 +++++++++++++++++++++++++++++
 6 files changed, 211 insertions(+), 1 deletions(-)
 create mode 100644 board/nvidia/paz00/Makefile
 create mode 100644 board/nvidia/paz00/paz00.c
 create mode 100644 include/configs/paz00.h

Signature · 1 line

1.7.5.4

Stephen Warren

author

2011-11-19 20:47 UTC #1 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.

Signed-off-by Stephen Warren <[email protected]>

---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

MAINTAINERS +1 -1

index 567dc61..c532c29 100644
@@ -877,7 +877,7 @@ Tom Warren <[email protected]>
 	seaboard	Tegra2 (ARM7 & A9 Dual Core)
 
 Tom Warren <[email protected]>
-Stephen Warren <[email protected]>
+Stephen Warren <[email protected]>
 
 	ventana		Tegra2 (ARM7 & A9 Dual Core)

Signature · 1 line

1.7.5.4

Wolfgang Denk

Applied

2011-11-28 18:58 UTC #2 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

Dear Stephen Warren,

Quoted 6 lines · In message <[email protected]> you wrote:

I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.
Signed-off-by Stephen Warren <[email protected]>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"More software projects have gone awry for lack of calendar time than
for all other causes combined."
                         - Fred Brooks, Jr., _The Mythical Man Month_

Wolfgang Denk

2011-11-28 19:01 UTC #3 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

In reply to Stephen Warren

Dear Stephen Warren,

Quoted 6 lines · In message <[email protected]> you wrote:

I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.
Signed-off-by Stephen Warren <[email protected]>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Wrong. Not applied, as this doesn't apply to mainline.

Please fix.

Best regards,

Wolfgang Denk

Signature · 8 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The alternative to genuflecting before the  god  of  code-bumming  is
finding  a  better  algorithm.  It should be clear that none such was
available. If your code is too slow, you must make it faster.  If  no
better algorithm is available, you must trim cycles.
                                 - td at alice.UUCP (Tom Duff) 29 Aug 88

Stephen Warren

author

2011-11-28 19:34 UTC #4 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

Quoted 11 lines · Wolfgang Denk

Dear Stephen Warren,
Quoted 6 lines · In message <[email protected]> you wrote:
I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.
Signed-off-by Stephen Warren <[email protected]>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wrong. Not applied, as this doesn't apply to mainline.

This series relies on other Tegra patches, both from myself and from others (Simon Glass in particular). Those other patches were posted a long time ago, so I assumed they'd be merged first, and didn't explicitly mention the dependency.

I imagine this patch series will go in via the new Tegra tree, so Tom Warren will sort out all the dependencies, based on the list of outstanding patches that Simon posted recently.

Signature · 1 line

nvpublic

Wolfgang Denk

2011-11-28 19:41 UTC #5 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

Dear Stephen Warren,

Quoted 3 lines · In message <[email protected]> you wrote:

Quoted 3 lines

 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

...

Quoted 4 lines

This series relies on other Tegra patches, both from myself and from others (Simon Glass in particular). Those other patches were posted a long time ago, so I assumed they'd be merged first, and didn't explicitly mention the dependency.

But this is global code, that should not go through another repo.

Also, this is a completely independent change, that should be applicable directly.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Far back in the mists of ancient time, in the great and glorious days
of the former Galactic Empire, life was wild, rich  and  largely  tax
free.         - Douglas Adams, _The Hitchhiker's Guide to the Galaxy_

Stephen Warren

author

2011-11-28 19:45 UTC #6 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

Quoted 12 lines · Wolfgang Denk

Dear Stephen Warren,
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines
Quoted 3 lines
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
...
Quoted 4 lines
This series relies on other Tegra patches, both from myself and from others (Simon Glass in particular). Those other patches were posted a long time ago, so I assumed they'd be merged first, and didn't explicitly mention the dependency.

Quoted 4 lines

But this is global code, that should not go through another repo.
Also, this is a completely independent change, that should be applicable directly.

The reason it doesn't apply is because the line being edited isn't in the code yet. It was only added to the file when I added support for the first board where I was listed as maintainer. I assume you agree that the original addition to MAINTAINERS should be part of the change that added support for that board, and since it's an ARM/Tegra board, that original change should go through the Tegra and ARM custodian trees? I suppose once that's done, this patch can indeed go directly into the main tree. If that flow is fine, I'll simply repost the patch once the appropriate context is in the main repository.

Signature · 1 line

nvpublic

Wolfgang Denk

2011-11-28 20:39 UTC #7 lore raw

RFC PATCH 1/3 MAINTAINERS: Fix my email address

Dear Stephen Warren,

Quoted 10 lines · In message <[email protected]> you wrote:

The reason it doesn't apply is because the line being edited isn't in the code yet. It was only added to the file when I added support for the first board where I was listed as maintainer. I assume you agree that the original addition to MAINTAINERS should be part of the change that added support for that board, and since it's an ARM/Tegra board, that original change should go through the Tegra and ARM custodian trees? I suppose once that's done, this patch can indeed go directly into the main tree. If that flow is fine, I'll simply repost the patch once the appropriate context is in the main repository.

If that other patch has not been commited yet, youshould rather send an update for that broken patch, instead of fixing it later.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many Myths are based on truth
	-- Spock, "The Way to Eden",  stardate 5832.3

Stephen Warren

author

2011-11-19 20:47 UTC #8 lore raw

RFC PATCH 2/3 tegra2: Fix conflicting pinmux for UARTA

In reply to Stephen Warren

Tegra appears to boot with function UARTA pre-selected on mux group SDB. If two mux groups are both set to the same function, it's unclear which group's pins drive the RX signals into the HW module. For UARTA, SDB certainly overrides group IRTX in practice. To solve this, configure some alternative function on SDB to avoid the conflict. Also, tri-state the group to avoid driving any signal onto it until we know what's connected.

Signed-off-by Stephen Warren <[email protected]>

---
 board/nvidia/common/board.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

board/nvidia/common/board.c +12 -0

index c806a6b..13742d7 100644
@@ -88,6 +88,18 @@ static void pin_mux_uart(void)
 
 	pinmux_tristate_disable(PINGRP_IRRX);
 	pinmux_tristate_disable(PINGRP_IRTX);
+
+	/*
+	 * Tegra appears to boot with function UARTA pre-selected on mux
+	 * group SDB. If two mux groups are both set to the same function,
+	 * it's unclear which group's pins drive the RX signals into the
+	 * HW module. For UARTA, SDB certainly overrides group IRTX in
+	 * practice. To solve this, configure some alternative function on
+	 * SDB to avoid the conflict. Also, tri-state the group to avoid
+	 * driving any signal onto it until we know what's connected.
+	 */
+	pinmux_tristate_enable(PINGRP_SDB);
+	pinmux_set_func(PINGRP_SDB,  PMUX_FUNC_SDIO3);
 #endif	/* CONFIG_TEGRA2_ENABLE_UARTA */
 #if defined(CONFIG_TEGRA2_ENABLE_UARTD)
 	pinmux_set_func(PINGRP_GMC, PMUX_FUNC_UARTD);

Signature · 1 line

1.7.5.4

Stephen Warren

author

2011-11-19 20:47 UTC #9 lore raw

RFC PATCH 3/3 tegra2: Add support for Paz00 (Toshiba AC100)

In reply to Stephen Warren

The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook derived from the NVIDIA Tegra Harmony reference board. It ships with Ubuntu, but is often repurposed to run Linux. This patch adds just enough support to get a U-Boot serial console, and the ability access built-in eMMC and the external SD slot.

FIXME: Since this board is not marketed by NVIDIA (Toshiba is the vendor, and Compal the ODM), this board should possibly be moved out of the board/nvidia directory.

Signed-off-by Stephen Warren <[email protected]>

---
 MAINTAINERS                 |    1 +
 board/nvidia/paz00/Makefile |   41 ++++++++++++++++++++++
 board/nvidia/paz00/paz00.c  |   81 +++++++++++++++++++++++++++++++++++++++++++
 boards.cfg                  |    1 +
 include/configs/paz00.h     |   52 +++++++++++++++++++++++++++
 5 files changed, 176 insertions(+), 0 deletions(-)
 create mode 100644 board/nvidia/paz00/Makefile
 create mode 100644 board/nvidia/paz00/paz00.c
 create mode 100644 include/configs/paz00.h

MAINTAINERS +1 -0

index c532c29..e339125 100644
@@ -880,6 +880,7 @@ Tom Warren <[email protected]>
 Stephen Warren <[email protected]>
 
 	ventana		Tegra2 (ARM7 & A9 Dual Core)
+	paz00		Tegra2 (ARM7 & A9 Dual Core)
 
 Lei Wen <[email protected]>

board/nvidia/paz00/Makefile new file +41 -0

41 lines not on this page · raw message

board/nvidia/paz00/paz00.c new file +81 -0

81 lines not on this page · raw message

boards.cfg +1 -0

index 5c2e01b..0d198df 100644
@@ -204,6 +204,7 @@ s5pc210_universal            arm         armv7       universal_c210      samsung
 smdkv310		     arm	 armv7	     smdkv310		 samsung	s5pc2xx
 harmony                      arm         armv7       harmony             nvidia         tegra2
 seaboard                     arm         armv7       seaboard            nvidia         tegra2
+paz00                        arm         armv7       paz00               nvidia         tegra2
 ventana                      arm         armv7       ventana             nvidia         tegra2
 u8500_href                   arm         armv7       u8500               st-ericsson    u8500
 actux1_4_16                  arm         ixp         actux1              -              -           actux1:FLASH2X2

include/configs/paz00.h new file +52 -0

52 lines not on this page · raw message

Signature · 1 line

1.7.5.4

Thierry Reding

2011-11-20 12:10 UTC #10 lore raw

RFC PATCH 3/3 tegra2: Add support for Paz00 (Toshiba AC100)

Quoted 21 lines · Stephen Warren

The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook derived from the NVIDIA Tegra Harmony reference board. It ships with Ubuntu, but is often repurposed to run Linux. This patch adds just enough support to get a U-Boot serial console, and the ability access built-in eMMC and the external SD slot.
FIXME: Since this board is not marketed by NVIDIA (Toshiba is the vendor, and Compal the ODM), this board should possibly be moved out of the board/nvidia directory.
Signed-off-by Stephen Warren <[email protected]>
---
 MAINTAINERS                 |    1 +
 board/nvidia/paz00/Makefile |   41 ++++++++++++++++++++++
 board/nvidia/paz00/paz00.c  |   81 +++++++++++++++++++++++++++++++++++++++++++
 boards.cfg                  |    1 +
 include/configs/paz00.h     |   52 +++++++++++++++++++++++++++
 5 files changed, 176 insertions(+), 0 deletions(-)
 create mode 100644 board/nvidia/paz00/Makefile
 create mode 100644 board/nvidia/paz00/paz00.c
 create mode 100644 include/configs/paz00.h

[...]

Quoted 20 lines

include/configs/paz00.h new file +14 -0

new file mode 100644
index 0000000..fcec6fa
@@ -0,0 +1,52 @@
+/*
+ * Copyright (c) 2010,2011, NVIDIA CORPORATION.  All rights reserved.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.

include/configs/paz00.h line 24

Quoted 10 lines

include/configs/paz00.h new file +10 -0

+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <asm/sizes.h>
+#include "tegra2-common.h"
+
+/* High-level configuration options */
+#define TEGRA2_SYSMEM		"mem=384M at 0M nvmem=128M at 384M"

Can we get rid of this? I think I remember some discussion about the same topic going on the linux-tegra/devicetree mailing lists, where it was decided that /mem-reserve/ entries should be dropped until some driver in the mainline kernel was actually going to use this memory. Perhaps U-Boot should take the same approach.

Thierry

Quoted 33 lines

include/configs/paz00.h new file +28 -0

+#define V_PROMPT		"Tegra2 (Paz00) # "
+#define CONFIG_TEGRA2_BOARD_STRING	"NVIDIA Paz00"
+
+/* Board-specific serial config */
+#define CONFIG_SERIAL_MULTI
+#define CONFIG_TEGRA2_ENABLE_UARTA
+#define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE
+
+#define CONFIG_MACH_TYPE		MACH_TYPE_PAZ00
+/*
+ * The following should be 512MB, but I don't know how to set that value
+ * It doesn't matter, since this isn't really used any more
+ */
+#define CONFIG_SYS_BOARD_ODMDATA	0x200d8011 /* lp1, 1GB */
+
+#define CONFIG_BOARD_EARLY_INIT_F
+
+/* SD/MMC */
+#define CONFIG_MMC
+#define CONFIG_GENERIC_MMC
+#define CONFIG_TEGRA2_MMC
+#define CONFIG_CMD_MMC
+
+#define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_FAT
+#endif /* __CONFIG_H */

Signature · 1 line

1.7.5.4

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111120/b22e5129/attachment.pgp>

Marc Dietrich

2011-11-20 17:39 UTC #11 lore raw

RFC PATCH 3/3 tegra2: Add support for Paz00 (Toshiba AC100)

Hi Stephen,

first, thanks for looking at this!

Quoted 55 lines · On Sunday 20 November 2011 13:10:08 Thierry Reding wrote:

Quoted 23 lines · Stephen Warren
The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook derived from the NVIDIA Tegra Harmony reference board. It ships with Ubuntu, but is often repurposed to run Linux. This patch adds just enough support to get a U-Boot serial console, and the ability access built-in eMMC and the external SD slot.
FIXME: Since this board is not marketed by NVIDIA (Toshiba is the vendor, and Compal the ODM), this board should possibly be moved out of the board/nvidia directory.
Signed-off-by Stephen Warren <[email protected]>
---
 MAINTAINERS                 |    1 +
 board/nvidia/paz00/Makefile |   41 ++++++++++++++++++++++
 board/nvidia/paz00/paz00.c  |   81
 +++++++++++++++++++++++++++++++++++++++++++ boards.cfg               
   |    1 +
 include/configs/paz00.h     |   52 +++++++++++++++++++++++++++
 5 files changed, 176 insertions(+), 0 deletions(-)
 create mode 100644 board/nvidia/paz00/Makefile
 create mode 100644 board/nvidia/paz00/paz00.c
 create mode 100644 include/configs/paz00.h
[...]
Quoted 28 lines
include/configs/paz00.h new file +7 -0
new file mode 100644
index 0000000..fcec6fa
@@ -0,0 +1,52 @@
+/*
+ * Copyright (c) 2010,2011, NVIDIA CORPORATION.  All rights reserved.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or modify
it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details.
+ */
include/configs/paz00.h new file +7 -0
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <asm/sizes.h>
+#include "tegra2-common.h"
+

Quoted 8 lines

include/configs/paz00.h line 24
Quoted 2 lines
include/configs/paz00.h new file +2 -0
+/* High-level configuration options */
+#define TEGRA2_SYSMEM		"mem=384M at 0M nvmem=128M at 384M"
Can we get rid of this? I think I remember some discussion about the same topic going on the linux-tegra/devicetree mailing lists, where it was decided that /mem-reserve/ entries should be dropped until some driver in the mainline kernel was actually going to use this memory. Perhaps U-Boot should take the same approach.

I also vote for this. Additionally, most users prefer mem=448M here. The device was original ships with 448 MB user memory, which was later reduced to 384 MB, maybe because of flash player requirements. I'm also not sure if nvmem is needed at all (maybe for android original kernel only)

Quoted 7 lines

include/configs/paz00.h new file +7 -0

+#define V_PROMPT		"Tegra2 (Paz00) # "
+#define CONFIG_TEGRA2_BOARD_STRING	"NVIDIA Paz00"
+
+/* Board-specific serial config */
+#define CONFIG_SERIAL_MULTI
+#define CONFIG_TEGRA2_ENABLE_UARTA
+#define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE

Quoted 8 lines

Quoted 8 lines
include/configs/paz00.h new file +4 -0
+
+#define CONFIG_MACH_TYPE		MACH_TYPE_PAZ00
+/*
+ * The following should be 512MB, but I don't know how to set that
value
+ * It doesn't matter, since this isn't really used any more
+ */
+#define CONFIG_SYS_BOARD_ODMDATA 0x200d8011 /* lp1, 1GB */

I don't know what is the effect of this paramter, but paz00 has 512 MB. The original valu was 0x8000c0085, AFAIK, which leaves most stuff on the default value.

Marc

Quoted 14 lines

include/configs/paz00.h new file +14 -0

+
+#define CONFIG_BOARD_EARLY_INIT_F
+
+/* SD/MMC */
+#define CONFIG_MMC
+#define CONFIG_GENERIC_MMC
+#define CONFIG_TEGRA2_MMC
+#define CONFIG_CMD_MMC
+
+#define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_FAT
+#endif /* __CONFIG_H */

Stephen Warren

author

2011-11-21 16:46 UTC #12 lore raw

RFC PATCH 3/3 tegra2: Add support for Paz00 (Toshiba AC100)

Quoted 7 lines · Marc Dietrich

Quoted 6 lines · On Sunday 20 November 2011 13:10:08 Thierry Reding wrote:
Quoted 5 lines · Stephen Warren
The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook derived from the NVIDIA Tegra Harmony reference board. It ships with Ubuntu, but is often repurposed to run Linux. This patch adds just enough support to get a U-Boot serial console, and the ability access built-in eMMC and the external SD slot.

...

Quoted 8 lines

Quoted 7 lines
Quoted 1 line
+#define TEGRA2_SYSMEM "mem=384M at 0M nvmem=128M at 384M"
Can we get rid of this? I think I remember some discussion about the same topic going on the linux-tegra/devicetree mailing lists, where it was decided that /mem-reserve/ entries should be dropped until some driver in the mainline kernel was actually going to use this memory. Perhaps U-Boot should take the same approach.

Quoted 4 lines

I also vote for this. Additionally, most users prefer mem=448M here. The device was original ships with 448 MB user memory, which was later reduced to 384 MB, maybe because of flash player requirements. I'm also not sure if nvmem is needed at all (maybe for android original kernel only)

Sounds like a plan. I've done this, and also moved the files to board/compal/paz00 as suggested elsewhere.

Quoted 11 lines

include/configs/paz00.h new file +11 -0

+#define V_PROMPT		"Tegra2 (Paz00) # "
+#define CONFIG_TEGRA2_BOARD_STRING	"NVIDIA Paz00"
+
+/* Board-specific serial config */
+#define CONFIG_SERIAL_MULTI
+#define CONFIG_TEGRA2_ENABLE_UARTA
+#define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE
+
+#define CONFIG_MACH_TYPE		MACH_TYPE_PAZ00
+/*
+ * The following should be 512MB, but I don't know how to set that

Quoted 8 lines

Quoted 4 lines
Quoted 4 lines
value
+ * It doesn't matter, since this isn't really used any more
+ */
+#define CONFIG_SYS_BOARD_ODMDATA 0x200d8011 /* lp1, 1GB */
I don't know what is the effect of this paramter, but paz00 has 512 MB. The original valu was 0x8000c0085, AFAIK, which leaves most stuff on the default value.

OK, I've switched to that value (where did you extract it from, BTW), and after fixing a bug in arch/arm/cpu/armv7/tegra2/board.c:query_sdram_size() (default==512M, not 1G), it all works.

Signature · 1 line

nvpublic

Thierry Reding

2011-11-20 12:05 UTC #13 lore raw

cover tegra2: Add paz00 support

In reply to Stephen Warren

Quoted 7 lines · Stephen Warren

This patch series adds support for the Toshiba AC100 Tegra netbook.
I'm posting it as an RFC because:
a) The AC100 is designed by Compal and marketed by Toshiba. Should we put the files into board/nvidia (since it uses an NVIDIA SoC), or create a board/toshiba or board/compal directory to contain this?

I don't think it should go into board/nvidia. Directories below board are supposed to be vendor directories and NVIDIA isn't the vendor of the AC100. I have a slight tendency for preferring toshiba over compal mostly because I think that's what people will be looking for first.

Thierry

Quoted 8 lines

b) It'll need rebasing on top of some of the many outstanding Tegra patches before it can be applied.
Stephen Warren (3):
MAINTAINERS: Fix my email address
tegra2: Fix conflicting pinmux for UARTA
tegra2: Add support for Paz00 (Toshiba AC100)

Quoted 16 lines

 MAINTAINERS                 |    3 +-
 board/nvidia/common/board.c |   12 ++++++
 board/nvidia/paz00/Makefile |   49 ++++++++++++++++++++++++
 board/nvidia/paz00/paz00.c  |   88 +++++++++++++++++++++++++++++++++++++++++++
 boards.cfg                  |    1 +
 include/configs/paz00.h     |   59 +++++++++++++++++++++++++++++
 6 files changed, 211 insertions(+), 1 deletions(-)
 create mode 100644 board/nvidia/paz00/Makefile
 create mode 100644 board/nvidia/paz00/paz00.c
 create mode 100644 include/configs/paz00.h

Signature · 1 line

1.7.5.4

Marc Dietrich

2011-11-20 17:45 UTC #14 lore raw

cover tegra2: Add paz00 support

Quoted 10 lines · On Sunday 20 November 2011 13:05:58 Thierry Reding wrote:

Quoted 8 lines · Stephen Warren
This patch series adds support for the Toshiba AC100 Tegra netbook.
I'm posting it as an RFC because:
a) The AC100 is designed by Compal and marketed by Toshiba. Should we put
the files into board/nvidia (since it uses an NVIDIA SoC), or create a board/toshiba or board/compal directory to contain this?

Quoted 4 lines

I don't think it should go into board/nvidia. Directories below board are supposed to be vendor directories and NVIDIA isn't the vendor of the AC100. I have a slight tendency for preferring toshiba over compal mostly because I think that's what people will be looking for first.

we had this discussion during addition of devicetree support to paz00 in the linux kernel already. The balance tended more into the direction of Compal, because 1) there exist two machines with different names with this board (Toshiba AC100 and Dynabook AZ) and 2) Toshibas/Dynabooks code name seems to be "Procyon" while paz00 is the code name at Compal. Having compal/paz00 in the kernel and Toshiba/procyon in u-boot would just add confusion and renaming everything is maybe not worth the effort (Toshiba/paz00 is totaly wrong).

Marc

Quoted 19 lines

Quoted 19 lines
b) It'll need rebasing on top of some of the many outstanding Tegra patches before it can be applied.
Stephen Warren (3):
MAINTAINERS: Fix my email address
tegra2: Fix conflicting pinmux for UARTA
tegra2: Add support for Paz00 (Toshiba AC100)
 MAINTAINERS                 |    3 +-
 board/nvidia/common/board.c |   12 ++++++
 board/nvidia/paz00/Makefile |   49 ++++++++++++++++++++++++
 board/nvidia/paz00/paz00.c  |   88
 +++++++++++++++++++++++++++++++++++++++++++ boards.cfg               
   |    1 +
 include/configs/paz00.h     |   59 +++++++++++++++++++++++++++++
 6 files changed, 211 insertions(+), 1 deletions(-)
 create mode 100644 board/nvidia/paz00/Makefile
 create mode 100644 board/nvidia/paz00/paz00.c
 create mode 100644 include/configs/paz00.h