Skip to contentSkip to conversation

Make Python IPv6 aware

PATCH In review [email protected] 4 participants 5 messages Jun 3, 2013 – Jun 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make Python IPv6 aware

I found that gateone would crash with a socket error when Python isn't compiled with IPv6 support. This patch enables it when DISTRO_FEATURES includes ipv6.

#1 lore raw

PATCH 1/1 Make Python IPv6 aware

From: Dan McGregor <[email protected]>

Wrap this around DISTRO_FEATURES, because we don't want it unconditionally enabled.

---
 meta/recipes-devtools/python/python.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/python/python.inc +2 -0
index d0ed55b..4618eb3 100644
@@ -19,6 +19,7 @@ inherit autotools
 PYTHONLSBOPTS = "--with-wctype-functions"
 PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
 
+ENABLE_IPV6 = "--enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes', 'no', d)}"
 EXTRA_OECONF = "\
   --with-threads \
   --with-pymalloc \
@@ -27,5 +28,6 @@ EXTRA_OECONF = "\
   --with-signal-module \
   --with-wctype-functions \
   --enable-shared \
+  ${ENABLE_IPV6} \
   ${PYTHONLSBOPTS} \
 "
Signature · 1 line
1.8.1.4
#2 lore raw

Hi Dan,

Quoted 21 lines · On Monday 03 June 2013 16:12:14 [email protected] wrote:

From: Dan McGregor <[email protected]>

Wrap this around DISTRO_FEATURES, because we don't want it unconditionally enabled.

---
 meta/recipes-devtools/python/python.inc | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-devtools/python/python.inc index d0ed55b..4618eb3 100644

meta/recipes-devtools/python/python.inc +1 -0
@@ -19,6 +19,7 @@ inherit autotools
 PYTHONLSBOPTS = "--with-wctype-functions"
 PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
 
+ENABLE_IPV6 = "--enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6',
 'yes', 'no', d)}" EXTRA_OECONF = "\
   --with-threads \
   --with-pymalloc \

meta/recipes-devtools/python/python.inc EXTRA_OECONF = "\ · line 33

Quoted 6 lines
meta/recipes-devtools/python/python.inc +1 -0
@@ -27,5 +28,6 @@ EXTRA_OECONF = "\
   --with-signal-module \
   --with-wctype-functions \
   --enable-shared \
+  ${ENABLE_IPV6} \
   ${PYTHONLSBOPTS} \
 "

OE-Core patches need to go to [email protected] rather than this list. Also, the shortlog (first line of the commit message) should start with the recipe / component being changed, so in this case it should be something like "python: enable IPv6 based on DISTRO_FEATURES". Additionally, do you need to use an additional ENABLE_IPV6 variable here or can you just include the expression within the EXTRA_OECONF expression?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#3 lore raw
In reply to [email protected]

Hi Dan,

in my layer, I simply activate IPv6 support for python with a simple bbappend file:

https://github.com/bmwcarit/meta-ros/blob/master/recipes-devtools/python/pyt
hon_2.7.3.bbappend

Lukas

Quoted 16 lines

-----Ursprüngliche Nachricht-----
Von: [email protected] [mailto:[email protected]] Im Auftrag von [email protected]
Gesendet: Dienstag, 4. Juni 2013 00:12
An: [email protected]
Betreff: [oe] [oe-core][PATCH] Make Python IPv6 aware

I found that gateone would crash with a socket error when Python isn't compiled with IPv6 support. This patch enables it when DISTRO_FEATURES includes ipv6.

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 7 lines · Lukas Bulwahn

Hi Dan,

in my layer, I simply activate IPv6 support for python with a simple bbappend file:

https://github.com/bmwcarit/meta-ros/blob/master/recipes-devtools/python/pyt
hon_2.7.3.bbappend

the patch is worth it only thing is it needs to go to right ml with Pauls comments addressed

Quoted 24 lines

Lukas

Quoted 8 lines

-----Ursprüngliche Nachricht-----
Von: [email protected] [mailto:[email protected]] Im Auftrag von [email protected]
Gesendet: Dienstag, 4. Juni 2013 00:12
An: [email protected]
Betreff: [oe] [oe-core][PATCH] Make Python IPv6 aware

Quoted 8 lines

I found that gateone would crash with a socket error when Python isn't compiled with IPv6 support. This patch enables it when DISTRO_FEATURES includes ipv6.

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel