Skip to contentSkip to conversation

usb, composite: after unregister gadget driver set composite to NULL

U-Boot Applied Heiko Schocher 3 participants 3 messages Jun 4, 2013 – Jun 9, 2013 USB

lore
Share & tools
lore
#0 lore raw

Without this, second usb_composite_register() call fails always with -EINVAL.

Cc Lukasz Majewski <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc Marek Vasut <[email protected]>
---
 drivers/usb/gadget/composite.c | 1 +

1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)

drivers/usb/gadget/composite.c +1 -0
index 0716e52..f867793 100644
@@ -1099,4 +1099,5 @@ void usb_composite_unregister(struct usb_composite_driver *driver)
 	if (composite != driver)
 		return;
 	usb_gadget_unregister_driver(&composite_driver);
+	composite = NULL;
 }
Signature · 1 line
1.7.11.7
Reviewed-by
#1 lore raw

Hi Heiko,

Quoted 16 lines

Without this, second usb_composite_register() call fails always with -EINVAL.

Cc Lukasz Majewski <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc Marek Vasut <[email protected]>
---
 drivers/usb/gadget/composite.c | 1 +

1 Datei ge?ndert, 1 Zeile hinzugef?gt(+)

(quoted diff) +0 -0

b/drivers/usb/gadget/composite.c index 0716e52..f867793 100644

drivers/usb/gadget/composite.c void usb_composite_unregister(struct · line 1102

Quoted 4 lines
drivers/usb/gadget/composite.c +1 -0
@@ -1099,4 +1099,5 @@ void usb_composite_unregister(struct
 usb_composite_driver *driver) if (composite != driver)
 		return;
 	usb_gadget_unregister_driver(&composite_driver);
+	composite = NULL;

Thanks for spotting.

drivers/usb/gadget/composite.c void usb_composite_unregister(struct · line 1103

Quoted 1 line
drivers/usb/gadget/composite.c +0 -0
 }
Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung R&D Poland Institute (SRPOL) | Linux Platform Group