drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.
Subsystems (2)
PATCH 1/1 drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.
In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used for DDC. Thus the code will always have to rely on a LVDS panel mode supplied by VBT.
In most cases this succeeds, so this didn't get detected for quite a while.
--- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_sdvo.c +1 -1
@@ -1848,7 +1848,7 @@ static void intel_sdvo_get_lvds_modes(struct drm_connector *connector)* Assume that the preferred modes are * arranged in priority order. */ -intel_ddc_get_modes (connector, intel_sdvo->i2c); +intel_ddc_get_modes (connector, &intel_sdvo->ddc);if (list_empty (&connector->probed_modes) == false) goto end;
Signature · 1 line
1.8.1.4
Quoted 7 lines · Egbert Eich
In
intel_sdvo_get_lvds_modes()the wrong i2c adapter record is used for DDC. Thus the code will always have to rely on a LVDS panel mode supplied by VBT.
In most cases this succeeds, so this didn't get detected for quite a while.Signed-off-by Egbert Eich <[email protected]>
Good catch!
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 7 lines · Chris Wilson
Quoted 6 lines · Egbert Eich
In
intel_sdvo_get_lvds_modes()the wrong i2c adapter record is used for DDC. Thus the code will always have to rely on a LVDS panel mode supplied by VBT.
In most cases this succeeds, so this didn't get detected for quite a while.
Quoted 5 lines
Quoted 1 line
Signed-off-by Egbert Eich <[email protected]>Good catch!
Reviewed-by Chris Wilson <[email protected]>
Yeah, nice catch. If my history digging is correct this has been broken in
commit f899fc64cda8569d0529452aafc0da31c042df2e
Author: Chris Wilson <[email protected]> Date: Tue Jul 20 15:44:45 2010 -0700
drm/i915: use GMBUS to manage i2c links
Patch merged with that note added, thanks.
-Daniel
Quoted 8 lines
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch