Skip to contentSkip to conversation

staging: vt6656: clean up MACvSetBBType

PATCH In review Malcolm Priestley 2 participants 2 messages Jun 5, 2013 Staging

lore
Share & tools
lore

Malcolm Priestley

author
#0 lore raw

PATCH 2/13 staging: vt6656: clean up MACvSetBBType

Remove internal white space and camel case.

Camel case changes;
pDevice -> priv
pbyData -> data
byType -> type

Functional change
CONTROLnsRequestOut Length = ARRAY_SIZE(data)

Signed-off-by Malcolm Priestley <[email protected]>
---
 drivers/staging/vt6656/mac.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/staging/vt6656/mac.c +7 -11
index 89d700f..0f8132b8 100644
@@ -84,20 +84,16 @@ void MACbShutdown(struct vnt_private *pDevice)
                         );
 }
 
-void MACvSetBBType(struct vnt_private *pDevice, u8 byType)
+void MACvSetBBType(struct vnt_private *priv, u8 type)
 {
-	u8 pbyData[2];
+	u8 data[2];
 
-    pbyData[0] = byType;
-    pbyData[1] = EnCFG_BBType_MASK;
+	data[0] = type;
+	data[1] = EnCFG_BBType_MASK;
 
-    CONTROLnsRequestOut(pDevice,
-                        MESSAGE_TYPE_WRITE_MASK,
-                        MAC_REG_ENCFG0,
-                        MESSAGE_REQUEST_MACREG,
-                        2,
-                        pbyData
-                        );
+	CONTROLnsRequestOut(priv, MESSAGE_TYPE_WRITE_MASK,
+		MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG,
+		ARRAY_SIZE(data), data);
 }
 
 /*
Signature · 1 line
1.8.1.2
maintainer
#1 lore raw
Quoted 9 lines · Malcolm Priestley

Remove internal white space and camel case.

Camel case changes;
pDevice -> priv
pbyData -> data
byType -> type

Functional change
CONTROLnsRequestOut Length = ARRAY_SIZE(data)

Don't do more than one thing in a patch, don't mix coding style cleanups with function changes please.

Please redo this whole series, odds are, you did the same thing with all of these, right?

thanks,

greg k-h