Skip to contentSkip to conversation

vf610twr: Drop unneeded 'or' operator

PATCH New Fabio Estevam 3 participants 3 messages Jun 5, 2013

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 vf610twr: Drop unneeded 'or' operator

From: Fabio Estevam <[email protected]>

No need to use the or operator, so just remove it.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/vf610twr/vf610twr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -1
index 04fa882..1156194 100644
@@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
 	imx_iomux_v3_setup_multiple_pads(
 		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
 
-	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
+	status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
 
 	return status;
 }
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 vf610twr: Drop unneeded 'or' operator

Hi Fabio,

Quoted 24 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

No need to use the or operator, so just remove it.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/vf610twr/vf610twr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -2
index 04fa882..1156194 100644
@@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
 	imx_iomux_v3_setup_multiple_pads(
 		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
 
-	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
+	status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
 
 	return status;
 }
--
Quoted 1 line

1.8.1.2

Or even better, completely drop status and use "return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);".

Best regards,
Beno?t

#2 lore raw

PATCH 1/1 vf610twr: Drop unneeded 'or' operator

Quoted 24 lines · Beno?t Th?baudeau

Hi Fabio,

Quoted 21 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

No need to use the or operator, so just remove it.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/vf610twr/vf610twr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -1
index 04fa882..1156194 100644
@@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
      imx_iomux_v3_setup_multiple_pads(
              esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
 
-     status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
+     status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
Quoted 8 lines
Quoted 4 lines
board/freescale/vf610twr/vf610twr.c +0 -1
      return status;
 }
--

1.8.1.2

Or even better, completely drop status and use "return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);".

+1 :)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750